From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71DAE20E8 for ; Tue, 7 Feb 2023 10:09:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675764549; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZR0ulCP18stSdAGdIDCbqMw0+hgLOSFlaljh5KnkP+U=; b=CeGDtGYdAT+1n6jjkbN4pFodykZUVl9o3QmS6ol9ID9DaGdXhmzfboJikqoBNs78JWUOFr RX11t7CIFrxi8c4fiXcj7sqScTBCxq9/+dqcvjedJ48mhbrRvlqUk3fjM91bfO93AxnT+R KnWSBuZx3lM0Tmjrxrr8MZZlpjRDHmk= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-623-dbMPrLuLM2m57k5nV6RxkQ-1; Tue, 07 Feb 2023 05:09:06 -0500 X-MC-Unique: dbMPrLuLM2m57k5nV6RxkQ-1 Received: by mail-qt1-f197.google.com with SMTP id hf20-20020a05622a609400b003abcad051d2so8184903qtb.12 for ; Tue, 07 Feb 2023 02:09:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZR0ulCP18stSdAGdIDCbqMw0+hgLOSFlaljh5KnkP+U=; b=xi7wmNqkHrFy9CbMT86HQYDbA+O4QJ92t1K1aaKBFw4dURZeDNjOiMP7k+c/2xOSiq FsY8JBBRA6f9ieGFyY3md/2iRX5i5KxIh4T8licB/lQvjTWaGFJ62NDS1uaMGhXwszj0 TRnN6VAcuJODMFVk7XVWroyj3IikEmQxLFwg5jNPRQXATR89Q3Mpl4szO0JDi15yu1xv ZZYYXOpPk0weMwSnS8zy/f0jwHq+ql3qxs0C9s05as1nzsFrlEP0+tMtZxgWQEGfgPhv 456ulV5sIJ4Wz5Gz8jf6CR0vp8Y/RtEZHrkyNzabPbQkgxC+VxTWAo2qczy+wYRgFn59 yIBw== X-Gm-Message-State: AO0yUKVShX+zxO1X5fyIUvgUyziJTGAy0ddg8D/h1cSG3bU0HP/BJyXB QEjJ4Zdn5QizF+izjI2rTWiMbUlp3ko2T2J8YL8Px2P1V2QmeluH3vlk4j2ujIISB4dUFxGFz1H UN9GT6XQNHYQHQLxf X-Received: by 2002:a05:622a:1106:b0:3b6:3a12:2bf9 with SMTP id e6-20020a05622a110600b003b63a122bf9mr4752922qty.2.1675764545712; Tue, 07 Feb 2023 02:09:05 -0800 (PST) X-Google-Smtp-Source: AK7set+kMUgLmXDnmLUe9OBwQo0pZwTWJP+zfBA/Ea2dEBA2nMdufvraXZdginHor8Q4n1IhuHpRow== X-Received: by 2002:a05:622a:1106:b0:3b6:3a12:2bf9 with SMTP id e6-20020a05622a110600b003b63a122bf9mr4752889qty.2.1675764545475; Tue, 07 Feb 2023 02:09:05 -0800 (PST) Received: from [192.168.0.2] (ip-109-43-176-120.web.vodafone.de. [109.43.176.120]) by smtp.gmail.com with ESMTPSA id p13-20020a05620a056d00b007208dd55183sm9072533qkp.40.2023.02.07.02.09.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Feb 2023 02:09:04 -0800 (PST) Message-ID: <7b32d58b-846f-b8d7-165b-9f505e5f00f0@redhat.com> Date: Tue, 7 Feb 2023 11:09:00 +0100 Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 To: Gavin Shan , kvm@vger.kernel.org, Paolo Bonzini , Sean Christopherson , Steven Price , Cornelia Huck Cc: kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm-riscv@lists.infradead.org, Marc Zyngier , James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , linuxppc-dev@lists.ozlabs.org, Eric Auger References: <20230203094230.266952-1-thuth@redhat.com> <20230203094230.266952-7-thuth@redhat.com> From: Thomas Huth Subject: Re: [PATCH 6/7] KVM: arm64: Change return type of kvm_vm_ioctl_mte_copy_tags() to "int" In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 07/02/2023 01.09, Gavin Shan wrote: > Hi Thomas, > > On 2/3/23 8:42 PM, Thomas Huth wrote: >> This function only returns normal integer values, so there is >> no need to declare its return value as "long". >> >> Signed-off-by: Thomas Huth >> --- >>   arch/arm64/include/asm/kvm_host.h | 4 ++-- >>   arch/arm64/kvm/guest.c            | 4 ++-- >>   2 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm64/include/asm/kvm_host.h >> b/arch/arm64/include/asm/kvm_host.h >> index 35a159d131b5..b1a16343767f 100644 >> --- a/arch/arm64/include/asm/kvm_host.h >> +++ b/arch/arm64/include/asm/kvm_host.h >> @@ -963,8 +963,8 @@ int kvm_arm_vcpu_arch_get_attr(struct kvm_vcpu *vcpu, >>   int kvm_arm_vcpu_arch_has_attr(struct kvm_vcpu *vcpu, >>                      struct kvm_device_attr *attr); >> -long kvm_vm_ioctl_mte_copy_tags(struct kvm *kvm, >> -                struct kvm_arm_copy_mte_tags *copy_tags); >> +int kvm_vm_ioctl_mte_copy_tags(struct kvm *kvm, >> +                   struct kvm_arm_copy_mte_tags *copy_tags); >>   /* Guest/host FPSIMD coordination helpers */ >>   int kvm_arch_vcpu_run_map_fp(struct kvm_vcpu *vcpu); >> diff --git a/arch/arm64/kvm/guest.c b/arch/arm64/kvm/guest.c >> index cf4c495a4321..80e530549c34 100644 >> --- a/arch/arm64/kvm/guest.c >> +++ b/arch/arm64/kvm/guest.c >> @@ -1013,8 +1013,8 @@ int kvm_arm_vcpu_arch_has_attr(struct kvm_vcpu *vcpu, >>       return ret; >>   } >> -long kvm_vm_ioctl_mte_copy_tags(struct kvm *kvm, >> -                struct kvm_arm_copy_mte_tags *copy_tags) >> +int kvm_vm_ioctl_mte_copy_tags(struct kvm *kvm, >> +                   struct kvm_arm_copy_mte_tags *copy_tags) >>   { >>       gpa_t guest_ipa = copy_tags->guest_ipa; >>       size_t length = copy_tags->length; >> > > It's possible for the function to return number of bytes have been copied. > Its type is 'size_t', same to 'unsigned long'. So 'int' doesn't have sufficient > space for it if I'm correct. > > long kvm_vm_ioctl_mte_copy_tags(struct kvm *kvm, >                                 struct kvm_arm_copy_mte_tags *copy_tags) > { >         gpa_t guest_ipa = copy_tags->guest_ipa; >         size_t length = copy_tags->length; >         : >         : > out: >         mutex_unlock(&kvm->slots_lock); >         /* If some data has been copied report the number of bytes copied */ >         if (length != copy_tags->length) >                 return copy_tags->length - length; >         return ret; > } Oh, drat, I thought I had checked all return statements ... this must have fallen through the cracks, sorry! Anyway, this is already a problem now: The function is called from kvm_arch_vm_ioctl() (which still returns a long), which in turn is called from kvm_vm_ioctl() in virt/kvm/kvm_main.c. And that functions stores the return value in an "int r" variable. So the upper bits are already lost there. Also, how is this supposed to work from user space? The normal "ioctl()" libc function just returns an "int" ? Is this ioctl already used in a userspace application somewhere? ... at least in QEMU, I didn't spot it yet... Thomas