From: Marc Zyngier <maz@kernel.org>
To: Fuad Tabba <tabba@google.com>
Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
oliver.upton@linux.dev, james.clark@linaro.org, will@kernel.org,
joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com,
catalin.marinas@arm.com, broonie@kernel.org, qperret@google.com,
kristina.martsenko@arm.com
Subject: Re: [PATCH v3 15/15] KVM: arm64: Renumber remaining vcpu guest configuration flags
Date: Sun, 01 Dec 2024 12:59:57 +0000 [thread overview]
Message-ID: <8634j7v9rm.wl-maz@kernel.org> (raw)
In-Reply-To: <20241128123515.1709777-16-tabba@google.com>
On Thu, 28 Nov 2024 12:35:15 +0000,
Fuad Tabba <tabba@google.com> wrote:
>
> With the vcpu's SVE and PtrAuth configuration flags removed,
> there are gaps in the numbering of the cflag bits. Renumber
> VCPU_INITIALIZED to bit 0 to remove the gaps.
>
> No functional change intended.
>
> Signed-off-by: Fuad Tabba <tabba@google.com>
> ---
> arch/arm64/include/asm/kvm_host.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
> index c5c80c789ad0..2e4afec09728 100644
> --- a/arch/arm64/include/asm/kvm_host.h
> +++ b/arch/arm64/include/asm/kvm_host.h
> @@ -864,10 +864,10 @@ struct kvm_vcpu_arch {
> #define vcpu_set_flag(v, ...) __vcpu_set_flag((v), __VA_ARGS__)
> #define vcpu_clear_flag(v, ...) __vcpu_clear_flag((v), __VA_ARGS__)
>
> +/* KVM_ARM_VCPU_INIT completed */
> +#define VCPU_INITIALIZED __vcpu_single_flag(cflags, BIT(0))
> /* SVE config completed */
> #define VCPU_SVE_FINALIZED __vcpu_single_flag(cflags, BIT(1))
> -/* KVM_ARM_VCPU_INIT completed */
> -#define VCPU_INITIALIZED __vcpu_single_flag(cflags, BIT(3))
>
> /* Exception pending */
> #define PENDING_EXCEPTION __vcpu_single_flag(iflags, BIT(0))
Please fold this with the relevant patches, even if that makes two
consecutive renumbering patches.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2024-12-01 13:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 12:35 [PATCH v3 00/15] KVM: arm64: Rework guest VM fixed feature handling and trapping in pKVM Fuad Tabba
2024-11-28 12:35 ` [PATCH v3 01/15] KVM: arm64: Consolidate allowed and restricted VM feature checks Fuad Tabba
2024-11-28 12:35 ` [PATCH v3 02/15] KVM: arm64: Group setting traps for protected VMs by control register Fuad Tabba
2024-11-28 12:35 ` [PATCH v3 03/15] KVM: arm64: Move checking protected vcpu features to a separate function Fuad Tabba
2024-11-28 12:35 ` [PATCH v3 04/15] KVM: arm64: Use KVM extension checks for allowed protected VM capabilities Fuad Tabba
2024-11-28 12:35 ` [PATCH v3 05/15] KVM: arm64: Initialize feature id registers for protected VMs Fuad Tabba
2024-11-28 12:35 ` [PATCH v3 06/15] KVM: arm64: Set protected VM traps based on its view of feature registers Fuad Tabba
2024-11-28 12:35 ` [PATCH v3 07/15] KVM: arm64: Rework specifying restricted features for protected VMs Fuad Tabba
2024-11-28 12:35 ` [PATCH v3 08/15] KVM: arm64: Remove fixed_config.h header Fuad Tabba
2024-11-28 12:35 ` [PATCH v3 09/15] KVM: arm64: Remove redundant setting of HCR_EL2 trap bit Fuad Tabba
2024-11-28 12:35 ` [PATCH v3 10/15] KVM: arm64: Calculate cptr_el2 traps on activating traps Fuad Tabba
2024-11-28 12:35 ` [PATCH v3 11/15] KVM: arm64: Refactor kvm_reset_cptr_el2() Fuad Tabba
2024-11-28 12:35 ` [PATCH v3 12/15] KVM: arm64: Fix the value of the CPTR_EL2 RES1 bitmask for nVHE Fuad Tabba
2024-11-28 12:35 ` [PATCH v3 13/15] KVM: arm64: Remove PtrAuth guest vcpu flag Fuad Tabba
2024-11-28 12:35 ` [PATCH v3 14/15] KVM: arm64: Convert the SVE guest vcpu flag to a vm flag Fuad Tabba
2024-12-01 12:58 ` Marc Zyngier
2024-12-01 16:01 ` Fuad Tabba
2024-12-02 12:57 ` Fuad Tabba
2024-12-02 14:29 ` Marc Zyngier
2024-12-02 14:47 ` Fuad Tabba
2024-11-28 12:35 ` [PATCH v3 15/15] KVM: arm64: Renumber remaining vcpu guest configuration flags Fuad Tabba
2024-12-01 12:59 ` Marc Zyngier [this message]
2024-12-02 9:16 ` Fuad Tabba
2024-11-28 16:31 ` [PATCH v3 00/15] KVM: arm64: Rework guest VM fixed feature handling and trapping in pKVM James Clark
2024-11-28 17:35 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8634j7v9rm.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.clark@linaro.org \
--cc=joey.gouly@arm.com \
--cc=kristina.martsenko@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=oliver.upton@linux.dev \
--cc=qperret@google.com \
--cc=suzuki.poulose@arm.com \
--cc=tabba@google.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox