From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C74D1EBA09; Tue, 10 Jun 2025 17:01:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749574899; cv=none; b=BNEsDxtXeKoAdGiFshQwuO5BLR6sF1JI1JIEd2HFDIL6zk6j3FAX+O9GdmTQVYciYtXmxjYvS5NF+xRYRbzwxSyqJLv0y4fRlC/tcQZD/sWVj2v81aoJMeWFGxOoPx97GEmoyvPBVHYeVFJGOi23p+xYyUjzpA7kXJOMOori5lY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749574899; c=relaxed/simple; bh=w7A2d0/ZPQU1PcKL9vOuHlBvVkGEXfQTlobUa93FGTM=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=a8y+ewwdu1ngfTVaRWdjHRcFoigi/GgmAq7RHvEq8DVHF96EOASKFBXOAcZHcgxfLoFlgF3LrJ6OgW0WjQYGOHruH+VwwL+q5L6zIKbja/GX/Ln5VEYUPbJ4d3yYW3L8bZ7/eRgpnOoWhPzbKy4UQ/+cPzXZzQTmM5LiJCnXDOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HTUGdKBS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HTUGdKBS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6B54C4CEED; Tue, 10 Jun 2025 17:01:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749574898; bh=w7A2d0/ZPQU1PcKL9vOuHlBvVkGEXfQTlobUa93FGTM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HTUGdKBSck1rEp0kYQFUjdP88z9Ava2g7ZcwFJBewIGHYzspMPQZThx+s56gFtSq/ wUZK+LZg1YSRAouIphy7nSud0KdzfDxQHTcGFTt7U7Y2HFDiURxaj5D/BI0qBYxhz5 wF66Rfwk4V4jSV8lkJdi6VIONdIZXnGixeHIqM5WdhXPlKjWXYf2qLkOJI4fQyH1av Tdqb/Z/Qt/qHaSbqYDuB3KilGGY0ytG4zibtLUMLcKAAgCAIpYBkYYct3Cb3LvzpoM V8G0VuCYdWoA1QmapPcgN+9uheedSYkMWDSr8FTFOajsblcx4Vtg+Kh9oCxZsneG8E JPgyLVH9TkZSA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uP2Lw-005aZO-Cj; Tue, 10 Jun 2025 18:01:36 +0100 Date: Tue, 10 Jun 2025 18:01:35 +0100 Message-ID: <864iwnedjk.wl-maz@kernel.org> From: Marc Zyngier To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Mark Rutland , Ada Couprie Diaz , linux-kernel@vger.kernel.org, Oliver Upton , Joey Gouly , kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-kselftest@vger.kernel.org Subject: Re: [PATCH V3 2/2] KVM: selftests: Change MDSCR_EL1 register holding variables as uint64_t In-Reply-To: <20250610053128.4118784-3-anshuman.khandual@arm.com> References: <20250610053128.4118784-1-anshuman.khandual@arm.com> <20250610053128.4118784-3-anshuman.khandual@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, ada.coupriediaz@arm.com, linux-kernel@vger.kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-kselftest@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 10 Jun 2025 06:31:28 +0100, Anshuman Khandual wrote: > > Change MDSCR_EL1 register holding local variables as uint64_t that reflects > its true register width as well. > > Cc: Marc Zyngier > Cc: Oliver Upton > Cc: Joey Gouly > Cc: kvm@vger.kernel.org > Cc: kvmarm@lists.linux.dev > Cc: linux-kernel@vger.kernel.org > Cc: linux-kselftest@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Reviewed-by: Ada Couprie Diaz > Signed-off-by: Anshuman Khandual > --- > tools/testing/selftests/kvm/arm64/debug-exceptions.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/kvm/arm64/debug-exceptions.c b/tools/testing/selftests/kvm/arm64/debug-exceptions.c > index c7fb55c9135b..e34963956fbc 100644 > --- a/tools/testing/selftests/kvm/arm64/debug-exceptions.c > +++ b/tools/testing/selftests/kvm/arm64/debug-exceptions.c > @@ -140,7 +140,7 @@ static void enable_os_lock(void) > > static void enable_monitor_debug_exceptions(void) > { > - uint32_t mdscr; > + uint64_t mdscr; > > asm volatile("msr daifclr, #8"); > > @@ -223,7 +223,7 @@ void install_hw_bp_ctx(uint8_t addr_bp, uint8_t ctx_bp, uint64_t addr, > > static void install_ss(void) > { > - uint32_t mdscr; > + uint64_t mdscr; > > asm volatile("msr daifclr, #8"); > Why change this in the place that matters *the least*? arch/arm64/kernel/debug-monitors.c is full of 32bit manipulation of this register, and that's only one example of it. So if you are going to change this, please do it fully, not as a random change in a random file. Thanks, M. -- Without deviation from the norm, progress is not possible.