From: Marc Zyngier <maz@kernel.org>
To: Ryan Roberts <ryan.roberts@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Oliver Upton <oliver.upton@linux.dev>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
James Morse <james.morse@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Ard Biesheuvel <ardb@kernel.org>,
Anshuman Khandual <anshuman.khandual@arm.com>,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev
Subject: Re: [PATCH v4 00/12] KVM: arm64: Support FEAT_LPA2 at hyp s1 and vm s2
Date: Mon, 23 Oct 2023 10:42:04 +0100 [thread overview]
Message-ID: <864jih65g3.wl-maz@kernel.org> (raw)
In-Reply-To: <2a1c314b-1fa4-47ac-a977-fba1ce06d614@arm.com>
On Fri, 20 Oct 2023 16:22:29 +0100,
Ryan Roberts <ryan.roberts@arm.com> wrote:
>
> On 20/10/2023 11:54, Marc Zyngier wrote:
> > Hi Ryan,
> >
> > On Mon, 09 Oct 2023 19:49:56 +0100,
> > Ryan Roberts <ryan.roberts@arm.com> wrote:
> >>
> >> Hi All,
> >>
> >> This adds support for FEAT_LPA2 to KVM for both hypervisor stage 1 (for the
> >> nvhe/protected modes) and the vm stage 2 translation tables (for all modes).
> >> FEAT_LPA2 enables 52 bit PAs and VAs for 4KB and 16KB granules (note this is
> >> already supported for 64KB granules via the FEAT_LPA and FEAT_LVA extensions).
> >> The series does not include support for FEAT_LPA2 in the kernel stage 1. This
> >> support is provided separately by Ard Biesheuvel's series at [4]. The two series
> >> are mostly independent.
> >>
> >> This is a small update from v3, rebased onto v6.6-rc5 and incorporating some
> >> minor changes based on review comments from Oliver.
> >>
> >> NOTE: I've included my patch to update the range-based tlbi functions to work
> >> with LPA2 in this version, because KVM has started using range-based tlbi
> >> invalidation as of v6.6-rc1. I've done this in such a way that KVM-originated
> >> calls will use the LPA2 format if LPA2 is in use by KVM, but the
> >> kernel-originated calls are hardcoded to never use the LPA2 format. If merging
> >> with Ard's series, you will need to update the 2 calls to __flush_tlb_range_op()
> >> from __flush_tlb_range() appropriately.
> >>
> >>
> >> Testing
> >> =======
> >>
> >> Testing has been done exclusively on the FVP and covers my boot matrix tests
> >> and kvm selftests.
> >>
> >> The host/guest config boot matrix gives the same (expected) results as for the
> >> v3 submission; of 180 conifgs, 12 fail, and these are all due to attempting to
> >> load the host kernel into high memory which isn't expected to work until the
> >> kernel has FEAT_LPA2 support for its stage 1. (refer to v1 posting for details
> >> on the exact configs).
> >>
> >> KVM selftests have been enhanced to support P52V48 4K and 16K guest modes, and
> >> all tests have been run against a P48V48_4K host and a P52V52_4K host (a run
> >> takes about 10 hours on FVP, sigh, but I can test a few more host configs if
> >> useful).
> >
> > Have you tried with the (brand new) "arm64_sw.hvhe=1" command-line
> > option, which enables VHE for the EL2 hypervisor only? I expect things
> > to work, but it would be good to make sure...
>
> No, I haven't tried. I did notice it when I rebased but convinced myself that it
> doesn't affect the page table stuff. I'm happy to give it a spin once I've
> rebased to v6.7-rc1 though.
It does affect the page-table format (KVM_PTE_LEAF_ATTR_LO_S1_AP_RO
and co), so I'm taking the view that whatever is not tested doesn't
work.
Thanks for giving it a go!
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2023-10-23 9:42 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 18:49 [PATCH v4 00/12] KVM: arm64: Support FEAT_LPA2 at hyp s1 and vm s2 Ryan Roberts
2023-10-09 18:49 ` [PATCH v4 01/12] arm64/mm: Update non-range tlb invalidation routines for FEAT_LPA2 Ryan Roberts
2023-10-19 8:03 ` Marc Zyngier
2023-10-19 9:22 ` Ryan Roberts
2023-10-20 8:05 ` Marc Zyngier
2023-10-20 12:39 ` Ryan Roberts
2023-10-20 13:02 ` Marc Zyngier
2023-10-20 13:21 ` Ryan Roberts
2023-10-20 13:41 ` Marc Zyngier
2023-10-09 18:49 ` [PATCH v4 02/12] arm64/mm: Update range-based " Ryan Roberts
2023-10-19 21:06 ` Marc Zyngier
2023-10-20 14:55 ` Ryan Roberts
2023-10-09 18:49 ` [PATCH v4 03/12] arm64/mm: Add FEAT_LPA2 specific ID_AA64MMFR0.TGRAN[2] Ryan Roberts
2023-10-09 18:50 ` [PATCH v4 04/12] KVM: arm64: Add ARM64_HAS_LPA2 CPU capability Ryan Roberts
2023-10-20 8:16 ` Marc Zyngier
2023-10-20 15:03 ` Ryan Roberts
2023-10-23 9:34 ` Marc Zyngier
2023-11-13 11:57 ` Ryan Roberts
2023-11-13 12:16 ` Marc Zyngier
2023-10-09 18:50 ` [PATCH v4 05/12] KVM: arm64: Add new (V)TCR_EL2 field definitions for FEAT_LPA2 Ryan Roberts
2023-10-09 18:50 ` [PATCH v4 06/12] KVM: arm64: Use LPA2 page-tables for stage2 and hyp stage1 Ryan Roberts
2023-10-20 9:16 ` Marc Zyngier
2023-10-20 15:06 ` Ryan Roberts
2023-10-23 9:36 ` Marc Zyngier
2023-10-09 18:50 ` [PATCH v4 07/12] KVM: arm64: Prepare TCR_EL2.PS in cpu_prepare_hyp_mode() Ryan Roberts
2023-10-20 9:21 ` Marc Zyngier
2023-10-20 15:07 ` Ryan Roberts
2023-10-09 18:50 ` [PATCH v4 08/12] KVM: arm64: Convert translation level parameter to s8 Ryan Roberts
2023-10-20 10:42 ` Marc Zyngier
2023-10-20 15:11 ` Ryan Roberts
2023-10-09 18:50 ` [PATCH v4 09/12] KVM: arm64: Support up to 5 levels of translation in kvm_pgtable Ryan Roberts
2023-10-09 18:50 ` [PATCH v4 10/12] KVM: arm64: Allow guests with >48-bit IPA size on FEAT_LPA2 systems Ryan Roberts
2023-10-09 18:50 ` [PATCH v4 11/12] KVM: selftests: arm64: Determine max ipa size per-page size Ryan Roberts
2023-10-09 18:50 ` [PATCH v4 12/12] KVM: selftests: arm64: Support P52V48 4K and 16K guest_modes Ryan Roberts
2023-10-20 10:54 ` [PATCH v4 00/12] KVM: arm64: Support FEAT_LPA2 at hyp s1 and vm s2 Marc Zyngier
2023-10-20 15:22 ` Ryan Roberts
2023-10-23 9:42 ` Marc Zyngier [this message]
2023-10-23 15:00 ` Ryan Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864jih65g3.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=anshuman.khandual@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=oliver.upton@linux.dev \
--cc=ryan.roberts@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox