From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11D267E
	for <kvmarm@lists.linux.dev>; Sat, 26 Aug 2023 11:00:54 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6CCF4C433C7;
	Sat, 26 Aug 2023 11:00:54 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1693047654;
	bh=X41PDJdMO0gnlTrmtcDGVGZwynUUJOdLMa1Q9jrx2HQ=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
	b=FAuNhKJTvFhah7imrXetu5JEHxar7uw/T4utlppAfNH2TpJ0e/hZ6k+6Yk0DEaeMh
	 bSbfxzILIxd44so0h16y+o8dtMnmJIDyjhY1hbtFVbBNC8JP7MT9q/LcKobA3cYsTO
	 Wg9roAu39PBMEQBkAP8Vju/YLxO+VCEbq6dM0TfXqjU8lu8dKVVNMiz8FkpbNJFb6K
	 SXzbMmtW0rgwHwuM+mG3S0x2yB979KVjmi4dXF69x7eOzWj3CpYExnkimacqrydy7a
	 Dbd07alH/SSLYwmYs2jD0L/VD5vtwXVWyPYi5YAzIyEBptW+PWNn9Oj9Ks2mkDGQKH
	 X/DMDcffzaDig==
Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org)
	by disco-boy.misterjones.org with esmtpsa  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.95)
	(envelope-from <maz@kernel.org>)
	id 1qZr27-008H2L-2G;
	Sat, 26 Aug 2023 12:00:47 +0100
Date: Sat, 26 Aug 2023 12:00:46 +0100
Message-ID: <868r9yf4pt.wl-maz@kernel.org>
From: Marc Zyngier <maz@kernel.org>
To: Kalesh Singh <kaleshsingh@google.com>
Cc: Vincent Donnefort <vdonnefort@google.com>,
	oliver.upton@linux.dev,
	kvmarm@lists.linux.dev,
	qperret@google.com,
	smostafa@google.com,
	linux-arm-kernel@lists.infradead.org,
	kernel-team@android.com,
	will@kernel.org
Subject: Re: [PATCH v2] KVM: arm64: Remove size-order align in the nVHE hyp private VA range
In-Reply-To: <CAC_TJvcwWRSs-YcP-_awLn2VU9m-AT8HzSq+aKHvSPkpRw5=OA@mail.gmail.com>
References: <20230811112037.1147863-1-vdonnefort@google.com>
	<CAC_TJvcwWRSs-YcP-_awLn2VU9m-AT8HzSq+aKHvSPkpRw5=OA@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
Precedence: bulk
X-Mailing-List: kvmarm@lists.linux.dev
List-Id: <kvmarm.lists.linux.dev>
List-Subscribe: <mailto:kvmarm+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:kvmarm+unsubscribe@lists.linux.dev>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-SA-Exim-Connect-IP: 185.219.108.64
X-SA-Exim-Rcpt-To: kaleshsingh@google.com, vdonnefort@google.com, oliver.upton@linux.dev, kvmarm@lists.linux.dev, qperret@google.com, smostafa@google.com, linux-arm-kernel@lists.infradead.org, kernel-team@android.com, will@kernel.org
X-SA-Exim-Mail-From: maz@kernel.org
X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false

Hey Kalesh,

On Fri, 11 Aug 2023 22:55:11 +0100,
Kalesh Singh <kaleshsingh@google.com> wrote:
>=20
> On Fri, Aug 11, 2023 at 4:20=E2=80=AFAM Vincent Donnefort <vdonnefort@goo=
gle.com> wrote:
> >
> > commit f922c13e778d ("KVM: arm64: Introduce
> > pkvm_alloc_private_va_range()") and commit 92abe0f81e13 ("KVM: arm64:
> > Introduce hyp_alloc_private_va_range()") added an alignment for the
> > start address of any allocation into the nVHE hypervisor private VA
> > range.

[...]

>
> Otherwise lgtm, Reviewed-by: Kalesh Singh <kaleshsingh@google.com>

Thanks for taking the time to review this.

Just a small nit: in the future, can you make sure your tags appear on
a separate line? This allows tools like 'b4' to automatically collect
them. It's not a huge deal, but I'd like to make sure to get the
credit you deserve.

Thanks again,

	M.

--=20
Without deviation from the norm, progress is not possible.