From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52754FBFD for ; Thu, 4 May 2023 15:08:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 09FD5C433D2; Thu, 4 May 2023 15:08:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683212924; bh=axENV78rQZpqfN8ChHqOHY0QRi+reeRgjbPExDDK+rI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ClC5Scz0FilRJcKHjsrN61BDZIyQi8wZY6luMlT8Nd0WfCIAsU8AtefBFKfDWYQel UkhpfizTeZkNJXhJ6HH/Qoor8knP72kIWfmd8MmNg4UOHuD+rURHuSj2BlJyILFyaS MoNfpuPKMniaMaj99PCdw6wJ1magbvuFeoU/Kj8urRreczQz/gOin4ZFbpccAeb7TZ kZLpekEgyAuv89jZWRfB0oK2c9yYEJrcFEvWVM3W8+ENUb/g3acBCb/J8PKEkjcwiS FSqR9Tj0dD6Z5UdTp0VeECd32LZYbLcGteJT+kauOFO4bH5KFmHsdpunLEt61kxX46 Wt52EUGr2MfbA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1puaZV-00CxWA-Lf; Thu, 04 May 2023 16:08:41 +0100 Date: Thu, 04 May 2023 16:08:41 +0100 Message-ID: <86mt2kgmme.wl-maz@kernel.org> From: Marc Zyngier To: Shivam Kumar Cc: pbonzini@redhat.com, seanjc@google.com, james.morse@arm.com, borntraeger@linux.ibm.com, aravind.retnakaran@nutanix.com, david@redhat.com, kvm@vger.kernel.org, Shaju Abraham , Manish Mishra , Anurag Madnawat , Suzuki K Poulose , Zenghui Yu , Oliver Upton , kvmarm , linux-arm-kernel Subject: Re: [PATCH v9 3/3] KVM: arm64: Dirty quota-based throttling of vcpus In-Reply-To: <20230504144328.139462-4-shivam.kumar1@nutanix.com> References: <20230504144328.139462-1-shivam.kumar1@nutanix.com> <20230504144328.139462-4-shivam.kumar1@nutanix.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: shivam.kumar1@nutanix.com, pbonzini@redhat.com, seanjc@google.com, james.morse@arm.com, borntraeger@linux.ibm.com, aravind.retnakaran@nutanix.com, david@redhat.com, kvm@vger.kernel.org, shaju.abraham@nutanix.com, manish.mishra@nutanix.com, anurag.madnawat@nutanix.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 04 May 2023 15:43:31 +0100, Shivam Kumar wrote: > > Call update_dirty_quota whenever a page is marked dirty with > appropriate arch-specific page size. Process the KVM request > KVM_REQ_DIRTY_QUOTA_EXIT (raised by update_dirty_quota) to exit to > userspace with exit reason KVM_EXIT_DIRTY_QUOTA_EXHAUSTED. > > Suggested-by: Shaju Abraham > Suggested-by: Manish Mishra > Co-developed-by: Anurag Madnawat > Signed-off-by: Anurag Madnawat > Signed-off-by: Shivam Kumar > --- > arch/arm64/kvm/Kconfig | 1 + > arch/arm64/kvm/arm.c | 5 +++++ > arch/arm64/kvm/mmu.c | 1 + > 3 files changed, 7 insertions(+) > > diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig > index f531da6b362e..06144ad3cfae 100644 > --- a/arch/arm64/kvm/Kconfig > +++ b/arch/arm64/kvm/Kconfig > @@ -43,6 +43,7 @@ menuconfig KVM > select SCHED_INFO > select GUEST_PERF_EVENTS if PERF_EVENTS > select INTERVAL_TREE > + select HAVE_KVM_DIRTY_QUOTA > help > Support hosting virtualized guest machines. > > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c > index 14391826241c..f0280c1c1c06 100644 > --- a/arch/arm64/kvm/arm.c > +++ b/arch/arm64/kvm/arm.c > @@ -792,6 +792,11 @@ static int check_vcpu_requests(struct kvm_vcpu *vcpu) > > if (kvm_dirty_ring_check_request(vcpu)) > return 0; > + > + if (kvm_check_request(KVM_REQ_DIRTY_QUOTA_EXIT, vcpu)) { > + vcpu->run->exit_reason = KVM_EXIT_DIRTY_QUOTA_EXHAUSTED; > + return 0; > + } > } > > return 1; > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > index 3b9d4d24c361..93c52f7464c9 100644 > --- a/arch/arm64/kvm/mmu.c > +++ b/arch/arm64/kvm/mmu.c > @@ -1419,6 +1419,7 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > /* Mark the page dirty only if the fault is handled successfully */ > if (writable && !ret) { > kvm_set_pfn_dirty(pfn); > + update_dirty_quota(kvm, fault_granule); > mark_page_dirty_in_slot(kvm, memslot, gfn); > } > I already raised this against the previous version of series: fault_granule isn't the amount of memory that gets mapped. I urge you to actually read the code you're modifying. Ignoring reviewer comments is not going to help merging this series. And yes, I ignored your reply because it didn't make any sense... It is also basic courtesy to Cc the maintainers and reviewers of that code, as well as the relevant MLs (get_maintainers.pl is, as usual, your friend). M. -- Without deviation from the norm, progress is not possible.