From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E67F3596B; Thu, 12 Jun 2025 14:11:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749737498; cv=none; b=Nf1LRrjLxrxiILjKxPiRt7PkUxyRMVfiwZmYCSou3n7RfH0bSQ925I3DIoM9rw74gEKKhRlDYK1xHtMS/5QluD+bQGCMBhbmOwvwhb8NVRsR/Z57LiqoWqA2DfjBhMTMl0hmnHGUDEumlsnb8kuB8QfLJDmjJQUMn20sfmq5MOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749737498; c=relaxed/simple; bh=eVcT22CR6MUvmIdjYr3MtOpYN2U0aHt7Hy7WNsb7NkM=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=RVAj/7WpB8sQnelRsleZW9Rw65M49T+Ui7o4oRYWCoxu+ZiGKERyUN3hUzUH8QM3xwHIQAJqPTOa//yRcM/e8zqmphLTNiGAH0qAD6xSTTCGlwk2We9s6dQi+AL7SBWlmS+s+6c3DAfdlcobJq+GHpsaqbjn9jfmT2KOw0U1wsU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rF1dgaeH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rF1dgaeH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C053DC4CEEA; Thu, 12 Jun 2025 14:11:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749737496; bh=eVcT22CR6MUvmIdjYr3MtOpYN2U0aHt7Hy7WNsb7NkM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rF1dgaeHPS7gQ0UjeHj1ioH3nZys3BESMWp2LfjYJNHYhw5M9lc1TIihF5xWfoxXK 5iCWIOSnDgcG+jFBZDdO0ywovQxdgyD7ph3XLqnazH6rknAxTxP8K/DoxpW0iUCIW8 HYWkSEUH5+jJM8bJ8ntZOqzFEJUiYia5B5ISrRg7X09jz4efh2nPXP3mUQuJ7Tuw25 WxRLc7225gaD7Ey274985yUp5TX2VKwcrrwlvvZQotqll2x9vGDLT+6Oo4iRlq90q1 1aCGQKjoVi17yK7bFTJAnCP4/sHsroEyROlll7hzgeZrF7mcpnI+EhpKvTSxERiPrg oA60e9XLjelIA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1uPieU-006GX7-24; Thu, 12 Jun 2025 15:11:34 +0100 Date: Thu, 12 Jun 2025 15:11:33 +0100 Message-ID: <86sek5cane.wl-maz@kernel.org> From: Marc Zyngier To: Luo Jie Cc: Yury Norov , Rasmus Villemoes , Julia Lawall , "Nicolas\ Palix" , Catalin Marinas , Will Deacon , Oliver Upton , Joey Gouly , Suzuki K Poulose , Zenghui Yu , , , , , , , , , , Subject: Re: [PATCH v4 0/5] Add FIELD_MODIFY() helper In-Reply-To: <20250612-field_modify-v4-0-ae4f74da45a6@quicinc.com> References: <20250612-field_modify-v4-0-ae4f74da45a6@quicinc.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: quic_luoj@quicinc.com, yury.norov@gmail.com, linux@rasmusvillemoes.dk, Julia.Lawall@inria.fr, nicolas.palix@imag.fr, catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, andrew@lunn.ch, quic_kkumarcs@quicinc.com, quic_linchen@quicinc.com, quic_leiwei@quicinc.com, quic_suruchia@quicinc.com, quic_pavir@quicinc.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 12 Jun 2025 14:46:07 +0100, Luo Jie wrote: > > Add the helper FIELD_MODIFY() to the FIELD_XXX family of bitfield > macros. It is functionally similar as xxx_replace_bits(), but adds > the compile time checking to catch incorrect parameter type errors. > > This series also converts the four instances of opencoded FIELD_MODIFY() > that are found in the core kernel files, to instead use the new > FIELD_MODIFY() macro. This is achieved with Coccinelle, by adding > the script field_modify.cocci. > > The changes are validated on IPQ9574 SoC which uses ARM64 architecture. > > Signed-off-by: Luo Jie I already indicated that the *pre-existing* set of helpers are enough for what we want to do, that we *already* use them for KVM/arm64, and that I didn't need nor want two ways to do the same thing in the same code base. My opinion hasn't changed on that front, and I don't see a point in these patches. M. -- Without deviation from the norm, progress is not possible.