From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EFB51BDC6 for ; Mon, 23 Oct 2023 18:19:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SQlOiKX/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31B9CC433C9; Mon, 23 Oct 2023 18:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698085184; bh=oS4z+Mn7/hwPC7bpjt/NEir6aeKFv3WVk0pLVerqzFw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SQlOiKX/tPZPymq+Xg2Z6Xpi9AS+MXP05zyw3Ng7z7apeSdOL+E/U8V+gToVXJxti j/QPFhH6ZQBPPqZIl25EZa2U2kAC/tXgHgbanJ5lFc5JDmjBQR5ZtyVMkgInHreYdh 6YgKJbSzOWIsTJcJ7muXYx42fAYolMzOjwJsQ6gR7aTOdidcMRlbMcflr/16pJkfov IOQFMgTnKZF/BJtBziMQzskTpBowwToKN7gIbU+0uIeI27BthgK9ex3VPiWHa7WLuy qyoaidWIivH061C6n04JcJR87Z8HbLyNlJ2XD2pPa3I9YDrCRymN/rUHmrroP4g15A KbQKEFUgxoZwA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1quzWf-006wp4-Cd; Mon, 23 Oct 2023 19:19:41 +0100 Date: Mon, 23 Oct 2023 19:19:39 +0100 Message-ID: <86sf6142x0.wl-maz@kernel.org> From: Marc Zyngier To: Raghavendra Rao Ananta Cc: Oliver Upton , Alexandru Elisei , James Morse , Suzuki K Poulose , Paolo Bonzini , Zenghui Yu , Shaoqin Huang , Jing Zhang , Reiji Watanabe , Colton Lewis , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v8 00/13] KVM: arm64: PMU: Allow userspace to limit the number of PMCs on vCPU In-Reply-To: References: <20231020214053.2144305-1-rananta@google.com> <86v8ax4hae.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: rananta@google.com, oliver.upton@linux.dev, alexandru.elisei@arm.com, james.morse@arm.com, suzuki.poulose@arm.com, pbonzini@redhat.com, yuzenghui@huawei.com, shahuang@redhat.com, jingzhangos@google.com, reijiw@google.com, coltonlewis@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 23 Oct 2023 18:58:19 +0100, Raghavendra Rao Ananta wrote: >=20 > On Mon, Oct 23, 2023 at 6:09=E2=80=AFAM Marc Zyngier wro= te: > > > > On Fri, 20 Oct 2023 22:40:40 +0100, > > Raghavendra Rao Ananta wrote: > > > > > > Hello, > > > > > > The goal of this series is to allow userspace to limit the number > > > of PMU event counters on the vCPU. We need this to support migration > > > across systems that implement different numbers of counters. > > > > [...] > > > > I've gone through the initial patches, and stopped before the tests > > (which I usually can't be bothered to review anyway). > > > > The comments I have a relatively minor and could be applied as fixes > > on top if Oliver can be convinced to do so. Note that patch #4 has an > > attribution issue. > > > > > base-commit: 0a3a1665cbc59ee8d6326aa6c0b4a8d1cd67dda3 > > > > maz@valley-girl:~/hot-poop/arm-platforms$ git describe 0a3a1665cbc59ee8= d6326aa6c0b4a8d1cd67dda3 > > fatal: 0a3a1665cbc59ee8d6326aa6c0b4a8d1cd67dda3 is neither a commit nor= blob > > > > Can you please make an effort to base your postings on a known, stable > > commit? A tagged -rc would be best. but certainly not a random commit. > > > I usually do base on a known -rc. But this series needed a couple of > series from kvmarm/next (mentioned in the original patch), and hence I > rebased on top of them. Well, that commit has since disappeared, as git cannot find it (as demonstrated above). Which is why I insist on a public tag as a base, as everything else is completely volatile. > How do you suggest I handle this in the future? Rebase to a known > -rc on mainline, apply the required series, and then my series on > top? No. You base your own series on an -rc (ideally, -rc3). If there is a conflict with another series, it is our job (Oliver and I) to fix it (bonus points if you indicate a resolution for the conflict in the cover letter). If there is a hard dependency (something that would actively prevent your series from working at all), you cherry-pick the minimal set of patches that makes your own series functional as a *prefix*, and post the whole thing, including the patches you depend on. Oliver and I will make sure the common prefix is dealt with without duplication. And for what it is worth, this series directly applies on v6.6-rc3 without a conflict. M. --=20 Without deviation from the norm, progress is not possible.