From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B930398916 for ; Tue, 17 Mar 2026 08:23:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773735828; cv=none; b=nr3Ulo9qiNEu2zK5f5//tDDiXYF+nXxN+/45CIqWP0RqicvwNwIN0TVjI392gumtWYAAyHfmvm5UHLFvT0oUe2YSZRe/u+NPhnihXLk28Dgm+CPJLO0OPOnSCOq9cmX6nPRV+TH9yN5RrCDyu15WC3DjpSMYJy/4RikIEfS5GwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773735828; c=relaxed/simple; bh=a29QAEXIGssouyozNOpQMVvz8FzM/vNaQNbQJrxfEYk=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=ROGIvhH4T7dtKKse+SJ0Uu535/6+vQn68eIZjSMIs93Fbdrf8iEysozlxge+9pY/nMgf6DjvnRoBw7kBnhzbHP5yWXiQr6uGZviaYx9CcZP/G39injXNe6/NajGpQD0JjHVSNlXlNTdn/ABUC2y3LPfC/csE4MPyU+XhhD431Dk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kKrBrRlg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kKrBrRlg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9501C2BCB0; Tue, 17 Mar 2026 08:23:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773735827; bh=a29QAEXIGssouyozNOpQMVvz8FzM/vNaQNbQJrxfEYk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kKrBrRlg2nhfZpCWNy1iNa2WlY9Wtv1i55T8nPtDy8VCdv4zNkVTSPPhgp1DfuhqH 6M+u0hHC8fjox1sArJoq4PuEvh3rksh7Kc+0uUDF6wnjJSVeDWDRIIzZOkJoH9APcL JHjlaTPYECqXJGRiSgFCSrTfJJug2/tfwnfD8DJrfIS14MqejoJOBlSRs+L+bcYk2H icxg3DzfUIuC2fq4ALW7Mi8ea0Y35UEY8NSRjp2I4G+bEU/a75kl+15tFp/R9ut6fC GLol39g7ByGK6oQcOcY8X4iosNTV34oIAC4+RUcdhmpz4cTp5K6PPC7XsBlLfgoR+Z NsHoC3xrTfciQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w2PiL-00000002jJL-3pGs; Tue, 17 Mar 2026 08:23:46 +0000 Date: Tue, 17 Mar 2026 08:23:45 +0000 Message-ID: <86tsue6ezy.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Joey Gouly , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Will Deacon , Quentin Perret Subject: Re: [PATCH 00/17] KVM: arm64: More user_mem_abort() rework In-Reply-To: References: <20260316175451.1866175-1-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tabba@google.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, joey.gouly@arm.com, suzuki.poulose@arm.com, oupton@kernel.org, yuzenghui@huawei.com, will@kernel.org, qperret@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 16 Mar 2026 20:33:03 +0000, Fuad Tabba wrote: > > On Mon, 16 Mar 2026 at 20:26, Fuad Tabba wrote: > > > > Hi Marc, > > > > On Mon, 16 Mar 2026 at 17:55, Marc Zyngier wrote: > > > > > > Piqued by Fuad's initial set of patches[1] splitting user_mem_abort() > > > into more "edible" functions, I've added my on take on top of it with > > > a few goals in mind: > > > > > > - contextualise the state by splitting kvm_s2_fault into more granular > > > structures > > > > > > - reduce the amount of state that is visible and/or mutable by any > > > single function > > > > > > - reduce the number of variable that simply cache state that is > > > already implicitly available (and often only a helper away) > > > > > > I find the result reasonably attractive, and throwing it at a couple > > > of machines didn't result in anything out of the ordinary. > > > > > > For those interested, I have stashed a branch at [2], and I'd > > > appreciate some feedback on the outcome. > > > > > > [1] https://lore.kernel.org/all/20260306140232.2193802-1-tabba@google.com/ > > > [2] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=hack/user_mem_abort-rework > > > > The series in hack/user_mem_abort-rework is different from this one. > > Here are the first few patches: > > And I just realized it's because they're based on _my_ patches ... doh! :D I thought I was clear when I wrote "I've added my on take on top of it", but maybe not. In any case, I didn't feel the need to redo what you had already done -- I don't think I'd have come up with something better. In any case, I'd appreciate your feedback! Thanks, M. -- Without deviation from the norm, progress is not possible.