From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 831D942058 for ; Mon, 18 Dec 2023 12:25:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="is9QCy1K" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0AA00C433C7; Mon, 18 Dec 2023 12:25:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702902353; bh=I+Ee4XNk8J4rYzmdxemVXEwThjz6c4BZEplm9T6nQkM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=is9QCy1K1Gk+mwJm/CMmBl9Y4LEhp7TAMi8rgjJd6l8xWu7j724EGjWUszANk7He5 lZDJM4wUnO6ZcVC0MjBDmUrBgzck/NzFnr6XSLQGp1BGgFwKi9YeiBlTvvD4EHUNIG 2IqKTnyj/HjqzAvimP3FQRKw3dzmA7x9je4CSoAibOXaoDVBne6Ifgjxa3xf1xL6gn o3eKyuXLHz+PDrZWbEPiUlg7/bCWh0T7oAcbAkD1dXU3E7Y2VS1r5AISdgXBAqp2yh wMPSS0FMdCICPd8RGB+MLsd68zGca76pqP1t2xhpSduTrLQQLhN/iirK9DiZI+8+1Z LGNTve+1+JQFA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rFCgw-0052LG-Ae; Mon, 18 Dec 2023 12:25:50 +0000 Date: Mon, 18 Dec 2023 12:25:49 +0000 Message-ID: <86ttofae9e.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: kvmarm@lists.linux.dev, oliver.upton@linux.dev, broonie@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, eric.auger@redhat.com, jingzhangos@google.com, joey.gouly@arm.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 14/17] KVM: arm64: Macros for setting/clearing FGT bits In-Reply-To: References: <20231214100158.2305400-1-tabba@google.com> <20231214100158.2305400-15-tabba@google.com> <86wmtbalx9.wl-maz@kernel.org> <86v88vahn8.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tabba@google.com, kvmarm@lists.linux.dev, oliver.upton@linux.dev, broonie@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, eric.auger@redhat.com, jingzhangos@google.com, joey.gouly@arm.com, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 18 Dec 2023 11:17:55 +0000, Fuad Tabba wrote: >=20 > Hi Marc, >=20 > On Mon, Dec 18, 2023 at 11:12=E2=80=AFAM Marc Zyngier wr= ote: > ... > > if (cpu_has_amu()) > > update_fgt_traps(vcpu, HAFGRTR_EL2); > > > > If that seems sensible to you, I'll fold it in, as I'd like to do > > without a respin if we can avoid it. >=20 > Looks good to me. Thanks Marc! Please have a look at [1] to see what I have done (AMU fixes and my suggestion for the FGT macros), and let me know if that's OK with you. I've given it a go on my M2 with NV (only a couple of minor conflicts) and nothing caught fire. Thanks, M. [1] https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/l= og/?h=3Dkvm-arm64/fgt-rework --=20 Without deviation from the norm, progress is not possible.