From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BD023B8BD3 for ; Mon, 2 Mar 2026 13:47:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772459227; cv=none; b=A+7s7c1aZb/EkG/dMwoQ0qANOnivNRmXoabWIroDO+0CwcFYZPhVHJyZ7tneyN4t4X/AIfTk+mnJPOg+32s8s34ajFb7l0Ccz7dtFm5LKgQJSld73w/vlZWHh7bIxBYv8jec7fiosFtqowl4tZIQoBPhGc/xfQTOnTMRwyD2j9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772459227; c=relaxed/simple; bh=fnrVuWdCxiQ73UQl0XAvQdItKVM2mxC6yCuvV6oynm0=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=juJh1Xjwmg+BaPDgeX2jlwgQjwJGUqvijMjd6eebkRzLtHaZ2urkpjo3gwNWXq3Gj79OqgbwDezw6oTbA/s3tIyOtuB0/B2A3s2KkfUJqfwkPomGzzHShI7OQIp0YkDdSArtDnjZsiDt0eT3SqUXFCANs2WbUX+tlG1kcvP/wwk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ft6G2wfY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ft6G2wfY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F1F62C19423; Mon, 2 Mar 2026 13:47:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772459227; bh=fnrVuWdCxiQ73UQl0XAvQdItKVM2mxC6yCuvV6oynm0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ft6G2wfYSdskF14l0dwOvUhz1/6cInbe/5QeqkwionvHwINWGx4ykj/puuh+ng8Oj QP/czaYRKio4y0JKiFOQlD4QA8u18c4HOS3KQ6nav1o5p01zDQsy1wjrUI2eFVhmLe 2IEAnmnTYM8ZB2xWK5b/em68nFEuozWjwFov9CLjxdmkGbm+Uh6yhF/+Gh0IswGVX9 nn5F7Vv6rEhSP/YUsQ3XR+HPEdjCkxISl/kN6dT3juZEaUNMpobPrshVOv2CKfIFrH ZbGy3f4/i3Mx3Q6TBY+gLlQUrmKTDpALFNKQHlZvauC4RqSlgThXelNEm629AdG5sw PDxgD6sEBnErA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vx3c0-0000000FFxs-30fx; Mon, 02 Mar 2026 13:47:04 +0000 Date: Mon, 02 Mar 2026 13:47:04 +0000 Message-ID: <86v7fe8ht3.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, Will Deacon , Catalin Marinas , Mark Rutland , Joey Gouly , Suzuki K Poulose , Oliver Upton , Zenghui Yu Subject: Re: [PATCH v2 01/11] arm64: Skip update of an idreg field affected by an override In-Reply-To: References: <20260302115653.1517326-1-maz@kernel.org> <20260302115653.1517326-2-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tabba@google.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, will@kernel.org, catalin.marinas@arm.com, mark.rutland@arm.com, joey.gouly@arm.com, suzuki.poulose@arm.com, oupton@kernel.org, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 02 Mar 2026 13:14:15 +0000, Fuad Tabba wrote: > > On Mon, 2 Mar 2026 at 13:05, Fuad Tabba wrote: > > > > Hi Marc, > > > > On Mon, 2 Mar 2026 at 11:57, Marc Zyngier wrote: > > > > > > When computing the new value od an idreg that contains a field > > > > nit: od->of > > > > > affected by an override, do not update that particular field. > > > > > > The value computed at init-time must be kept as-is, as that's > > > what the user has asked for, for better or worse. > > > > > > Signed-off-by: Marc Zyngier > > Another nit, should you add a fixes tag, since this flaw is tired to > the original override facility? i.e., > 8f266a5d878a ("arm64: cpufeature: Add global feature override facility"). Yup, good point. > > > Reviewed-by: Fuad Tabba Thanks! M. -- Without deviation from the norm, progress is not possible.