From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v4 21/21] KVM: arm64: Trap RAS error registers and set HCR_EL2's TERR & TEA Date: Tue, 31 Oct 2017 06:32:53 +0000 Message-ID: <86y3nr3jze.fsf@arm.com> References: <20171019145807.23251-1-james.morse@arm.com> <20171019145807.23251-22-james.morse@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B9FE849D4F for ; Tue, 31 Oct 2017 02:31:24 -0400 (EDT) Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xjWmLCYHWkUh for ; Tue, 31 Oct 2017 02:31:23 -0400 (EDT) Received: from foss.arm.com (foss.arm.com [217.140.101.70]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 9F4C249D24 for ; Tue, 31 Oct 2017 02:31:23 -0400 (EDT) In-Reply-To: <20171019145807.23251-22-james.morse@arm.com> (James Morse's message of "Thu, 19 Oct 2017 15:58:07 +0100") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu To: James Morse Cc: Jonathan.Zhang@cavium.com, Catalin Marinas , Julien Thierry , Will Deacon , wangxiongfeng2@huawei.com, linux-arm-kernel@lists.infradead.org, Dongjiu Geng , kvmarm@lists.cs.columbia.edu List-Id: kvmarm@lists.cs.columbia.edu On Thu, Oct 19 2017 at 4:58:07 pm BST, James Morse wrote: > From: Dongjiu Geng > > ARMv8.2 adds a new bit HCR_EL2.TEA which routes synchronous external > aborts to EL2, and adds a trap control bit HCR_EL2.TERR which traps > all Non-secure EL1&0 error record accesses to EL2. > > This patch enables the two bits for the guest OS, guaranteeing that > KVM takes external aborts and traps attempts to access the physical > error registers. > > ERRIDR_EL1 advertises the number of error records, we return > zero meaning we can treat all the other registers as RAZ/WI too. > > Signed-off-by: Dongjiu Geng > [removed specific emulation, use trap_raz_wi() directly for everything, > rephrased parts of the commit message] > Signed-off-by: James Morse Reviewed-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny.