From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67EB333EF for ; Wed, 7 Dec 2022 18:35:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15C2CC433D6; Wed, 7 Dec 2022 18:35:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670438109; bh=sVcbtfBNRQTSOCViL39SYHzhwZF2eDOnFH0Gn4JxkRE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LnMuvV6gZKNmzx5u3Sihs4afP4trtGLFc7MAuiJoBjmrjL4fBGYRwMH9Zot0GcovP vpZ5VGFu/YZ/wrKbs7iIjT1eIdPiTbUS8Ij+M12jwlh/qkNOkmz6829g+60wd0AvTf Tm5ZroXXXfa6hNhFqBm1LmZ9u/bsIHq+8s4CuzK/eH/71G0LV7fO6LC3AHzkXETw/T fQYbuhPi5nXEbBrkLx8XmxKimjj2Hi6KDzi8nbRegpjEyt3ry/5SYajReE4kyWKxIK azofdhtTR0hO1KxYdHDNfUMnsa+yrI8ZKJD5MX5xuaqwcd5W/dThI11gpjpHYBxXWO SmWvfonWOJoIg== Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p2zG6-00BBUH-Oc; Wed, 07 Dec 2022 18:35:06 +0000 Date: Wed, 07 Dec 2022 18:33:26 +0000 Message-ID: <871qpbt66h.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v1 1/3] arm64/sysreg: Add definition for ICC_NMIAR1_EL1 In-Reply-To: References: <20221206131144.115774-1-broonie@kernel.org> <20221206131144.115774-2-broonie@kernel.org> <86fsdrlaz5.wl-maz@kernel.org> <86bkofl08v.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: broonie@kernel.org, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Wed, 07 Dec 2022 18:16:10 +0000, Mark Brown wrote: > > [1 ] > On Wed, Dec 07, 2022 at 03:08:48PM +0000, Marc Zyngier wrote: > > Mark Brown wrote: > > > > Given the textual conflict with the ISR patch and the fact that the NMI > > > series needs both anyway it seemed more productive to just carry them > > > both in the cleanup series even if this one isn't immediately used. > > > I thought the point of this series was to extract stuff that was > > otherwise useful, independently of the NMI series. > > I tend to view the system register definitions as just generally useful, > this being system register definitions plus a cleanup that could be done > on top. I tend to view the *unused* system register definition as pointless churn. We'll have to agree to disagree on that one. > > > I must have misunderstood its purpose. This is instead making things > > harder to follow. Oh well. > > I am hopeful that the extra cognative load of an additional register > definition will be managable. You never know. M. -- Without deviation from the norm, progress is not possible.