From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 977BDC433EF for ; Mon, 7 Mar 2022 16:52:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2CC6E4B20B; Mon, 7 Mar 2022 11:52:24 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sLvwqPxSs+SF; Mon, 7 Mar 2022 11:52:23 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 225F84B0CB; Mon, 7 Mar 2022 11:52:23 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2B2AC4B08D for ; Mon, 7 Mar 2022 11:52:22 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ir8vbgtCf9j6 for ; Mon, 7 Mar 2022 11:52:21 -0500 (EST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 004D54B0B4 for ; Mon, 7 Mar 2022 11:52:20 -0500 (EST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3AFCF61161; Mon, 7 Mar 2022 16:52:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EE56C340E9; Mon, 7 Mar 2022 16:52:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1646671938; bh=/JbDy1Wdxx5UrVmpwE8J1sNcP7rgJOTzMhZ4KOZT5eo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WL4DuGw/pHMPftDa/BR7gw9a1uxWnilgWUrzuF5vtwBCjtr7KTUg/gEcQulZCz5r1 Zv6LeiRVZSRHUfwxKoWLLlROxQew6GdEFxj7dOnmCCqVQCD40Np3db82fj9La+mfsA TVzSWKqOAEpjwpc8j2Iyy3Fh8U9EGG2lq2a9wjk5B5Nlqp2Gv34BaQgCnuOHD0Wco9 4I3KxL82LpiaTCt70dvoNGcbnx7dSlSoUQ56uYLHk+hnSnMq5Gs1UOXEO9HOgQxrIh rm0cvx1g19XJ2A3vdwxoubASTbtxwoL9NGm9Q6CrSC1QFhiEj+YTeGqtHLVZ5rMmoc fVEVo2RdPgczA== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nRGam-00CqSm-6k; Mon, 07 Mar 2022 16:52:16 +0000 Date: Mon, 07 Mar 2022 16:52:15 +0000 Message-ID: <8735jt1z9c.wl-maz@kernel.org> From: Marc Zyngier To: Alexandru Elisei Subject: Re: [PATCH v6 43/64] KVM: arm64: nv: arch_timer: Support hyp timer emulation In-Reply-To: References: <20220128121912.509006-1-maz@kernel.org> <20220128121912.509006-44-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: alexandru.elisei@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, andre.przywara@arm.com, christoffer.dall@arm.com, jintack@cs.columbia.edu, haibo.xu@linaro.org, gankulkarni@os.amperecomputing.com, chase.conklin@arm.com, linux@armlinux.org.uk, james.morse@arm.com, suzuki.poulose@arm.com, karl.heubaum@oracle.com, mihai.carabas@oracle.com, miguel.luis@oracle.com, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kernel-team@android.com, kvm@vger.kernel.org, Andre Przywara , Christoffer Dall , Chase Conklin , kvmarm@lists.cs.columbia.edu, mihai.carabas@oracle.com, Ganapatrao Kulkarni , "Russell King \(Oracle\)" , linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Mon, 07 Mar 2022 16:28:44 +0000, Alexandru Elisei wrote: > > Hi, > > On Mon, Mar 07, 2022 at 03:48:19PM +0000, Marc Zyngier wrote: > > On 2022-03-07 14:52, Alexandru Elisei wrote: > > > Hi, > > > > > > I was under the impression that KVM's nested virtualization doesn't > > > support > > > AArch32 in the guest, why is the subject about hyp mode aarch32 timers? > > > > Where did you see *ANY* mention of AArch32? > > I saw an implicit mention of aarch32 when the commit message used > the term "hyp", which is the name of an aarch32 execution mode. > > > > > Or is that a very roundabout way to object to the 'hyp' name? > > Bingo. > > > If that's the case, just apply a mental 's/hyp/el2/' substitution. > > I'm a bit confused about that. Is that something that anyone reading > the patch should apply mentally when reading the patch, or is it > something that you plan to change in the commit subject? Big picture: maz@hot-poop:~/arm-platforms$ git grep -i hyp arch/arm64/|wc -l 1701 maz@hot-poop:~/arm-platforms$ git grep -i el2 arch/arm64/|wc -l 1008 Are we going to also repaint all these 'hyp' references? I really appreciate all the hard work you are putting in carefully reviewing the code. I *really* do. But bickering on this really doesn't help, and I know you understand exactly what this subject line means (you've been reviewing KVM code for long enough, and won't fool anyone). The point you are trying to make really is moot. Everybody understands that HYP means EL2. I'd even argue that it is clearer than EL2, because it indicates that we're running at EL2 with the role of a hypervisor, which isn't that clear with running with VHE. And if they don't understand that, it unfortunately means they can't really review this code. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm