From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1C1229B76C for ; Thu, 12 Jun 2025 15:53:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749743601; cv=none; b=IarbyS6X4IKSi1nE/dx2y+8P6pXP1x5WO1lYXQBWN/K5lNnIIWti0PfYT4djuqNosvBcJPxNZu3HEntvAq0G+awEgK/aEa/2JdrTZGOeW7nYMLaHQMMIu7GCfFg9XDJuPgjsHxrBaHnAoFLry/QK/sf1ekY+CB58YoselPGI1cg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749743601; c=relaxed/simple; bh=UQrVYsGc6/MyapNa6tWxlij5FlBMTrwN8q2oOiwMZCU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=jh6ihyNbnke4XDhLKMrfBkXnjLu0CJmyoDuT6DmY+propYWZ0KtrjVFCnpzdZcwtc3wocPcut6Gq+znC3TnsvcuZYiznwm54BiaipWeYw6qnOlfK3rp3qn0N4y8KeSjtLLK0lIENqAG7RR+NKtLn5FcBSFkfziS3kUXKXjB7lvU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SnSWtPvA; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SnSWtPvA" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749743598; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mUI+8vjhhSyqNoE3QrTGQqAzBmNIFi2uvoVlnXIO0eY=; b=SnSWtPvAtdkpD1TDdcyn7ofhWcTK++7YgzFNpIXdm0M1YpqKnxlxfVha1EJyYc8H8DXUlG sl4MibHhN4D3Yi5A3xpN9mcVJRDTlrJajx3KYeveISAQeBmscmSthG54j/dELVBx1b8FlG iZZycncfTjH2UHWR4AHpCJqtta7tZnI= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-5BU_AqztPBOJLHDrdiDD7Q-1; Thu, 12 Jun 2025 11:53:15 -0400 X-MC-Unique: 5BU_AqztPBOJLHDrdiDD7Q-1 X-Mimecast-MFC-AGG-ID: 5BU_AqztPBOJLHDrdiDD7Q_1749743593 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B97CF1956089; Thu, 12 Jun 2025 15:53:12 +0000 (UTC) Received: from localhost (unknown [10.45.224.54]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7EAD118003FC; Thu, 12 Jun 2025 15:53:10 +0000 (UTC) From: Cornelia Huck To: Peter Maydell Cc: eric.auger.pro@gmail.com, eric.auger@redhat.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, kvmarm@lists.linux.dev, richard.henderson@linaro.org, alex.bennee@linaro.org, maz@kernel.org, oliver.upton@linux.dev, sebott@redhat.com, shameerali.kolothum.thodi@huawei.com, armbru@redhat.com, berrange@redhat.com, abologna@redhat.com, jdenemar@redhat.com, agraf@csgraf.de, shahuang@redhat.com, mark.rutland@arm.com, philmd@linaro.org, pbonzini@redhat.com Subject: Re: [PATCH v7 08/14] arm/cpu: Store id_isar0-7 into the idregs array In-Reply-To: Organization: "Red Hat GmbH, Sitz: Werner-von-Siemens-Ring 12, D-85630 Grasbrunn, Handelsregister: Amtsgericht =?utf-8?Q?M=C3=BCnchen=2C?= HRB 153243, =?utf-8?Q?Gesch=C3=A4ftsf=C3=BChrer=3A?= Ryan Barnhart, Charles Cachera, Avril Crosse O'Flaherty" References: <20250515153907.151174-1-cohuck@redhat.com> <20250515153907.151174-9-cohuck@redhat.com> <87a56d9dlb.fsf@redhat.com> User-Agent: Notmuch/0.38.3 (https://notmuchmail.org) Date: Thu, 12 Jun 2025 17:53:07 +0200 Message-ID: <874iwl9ct8.fsf@redhat.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On Thu, Jun 12 2025, Peter Maydell wrote: > On Thu, 12 Jun 2025 at 16:36, Cornelia Huck wrote: >> >> On Thu, Jun 12 2025, Peter Maydell wrote: >> >> > On Thu, 15 May 2025 at 16:40, Cornelia Huck wrote: >> >> >> >> From: Eric Auger >> >> >> >> Reviewed-by: Richard Henderson >> >> Reviewed-by: Sebastian Ott >> >> Signed-off-by: Eric Auger >> >> Signed-off-by: Cornelia Huck >> >> --- >> >> hw/intc/armv7m_nvic.c | 12 ++-- >> >> target/arm/cpu-features.h | 36 +++++----- >> >> target/arm/cpu.c | 24 +++---- >> >> target/arm/cpu.h | 7 -- >> >> target/arm/cpu64.c | 28 ++++---- >> >> target/arm/helper.c | 14 ++-- >> >> target/arm/kvm.c | 21 ++---- >> >> target/arm/tcg/cpu-v7m.c | 90 +++++++++++++----------- >> >> target/arm/tcg/cpu32.c | 144 +++++++++++++++++++++----------------- >> >> target/arm/tcg/cpu64.c | 108 ++++++++++++++-------------- >> >> 10 files changed, 243 insertions(+), 241 deletions(-) >> > >> > This doesn't compile: >> > >> > ../../target/arm/tcg/cpu-v7m.c:70:5: error: incompatible pointer types >> > initializing 'ARMISARe >> > gisters *' (aka 'struct ARMISARegisters *') with an expression of type >> > 'uint64_t *' (aka 'unsigned long *') >> > [-Werror,-Wincompatible-pointer-types] >> > 70 | SET_IDREG(idregs, ID_ISAR0, 0x01141110); >> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> > ../../target/arm/cpu.h:875:26: note: expanded from macro 'SET_IDREG' >> > 875 | ARMISARegisters *i_ = (ISAR); >> > \ >> > | ^ ~~~~~~ >> > ../../target/arm/tcg/cpu-v7m.c:71:5: error: incompatible pointer types >> > initializing 'ARMISARegisters *' (aka 'struct ARMISARegisters *') with >> > an expression of type 'uint64_t *' (aka 'unsigned long *') >> > [-Werror,-Wincompatible-pointer-types] >> > 71 | SET_IDREG(idregs, ID_ISAR1, 0x02111000); >> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> > ../../target/arm/cpu.h:875:26: note: expanded from macro 'SET_IDREG' >> > 875 | ARMISARegisters *i_ = (ISAR); >> > \ >> > | ^ ~~~~~~ >> > >> > (and more similar errors until the compiler gives up). >> >> What configs/compiler are you using? I obviously would have fixed that >> if I had hit it... > > This is clang 18.1.3 (1ubuntu1) on x86-64 Linux, configured with > > '../../configure' '--cc=clang' '--cxx=clang++' '--enable-ubsan' > '--target-list=arm-softmmu,arm-linux-user,aarch64-softmmu,aarch64-linux-user' > > Whatever the problem is, it goes away on a later patch, so probably > it's just that some fragment in a later patch needs to move into > this one. Ok, I should do more automated builds after every patch, because I forget to do that too often. (I usually build with gcc.)