From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FD8E18C348 for ; Thu, 8 Aug 2024 12:00:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723118407; cv=none; b=hvK2zvMCmzV4pC2CQWGvUgIlEQf3DFwMb5KbWenhgMawuoIdLeXCtbZ7LjdNWZEz4kd2U1L37Tvd+XKEZ1AcraBsfTS8COUiD7jdoIUcLvVnC/az8dIlfSKC2JRLOtpF/n316LMdXPHoPLf5WTKQ8qbZSb/xquEwFkel4WYi+bM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723118407; c=relaxed/simple; bh=4VJkCGOnJpRwR4YKBH81A1uxdWFs9jOzqwkiDCMslRY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=COWwSVER0HqJZuoqv7GgFE4u01OdI3wz0L//ZQdjvuWf3sVkVXfQ3FtYgmi6myh2YHhpn34e0kvInHf6Lsbr1NSalP+mAo6UAxhCuu9sLRWgzES3GjASLRAKcSOidI6zMriwld2f9Qg9ryn6zPIarhCo/7sc/s0/fWGgEF0VFC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ddkuFE9F; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ddkuFE9F" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3685b3dbcdcso489400f8f.3 for ; Thu, 08 Aug 2024 05:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723118403; x=1723723203; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=l8fBZbfSfQMp8/8SurSvfBz+MaimrqNdI2CubOLP3Ew=; b=ddkuFE9FINzia0qQVVaAQtZuEXNAIekNuYkVjCLYxZyvoCdYq1EEgTZx2+1AOrzHqt +31SUlBnAGOJ3JBSQYO66KKvQvP5QfHjsLIzws812nAW0O5c5nVf6fCLOO1CvOPDh5oK Lzw6NNaIXWLRKVugiwcSxG/lfgdfWXCaSQBjhhslNoOO47IsjeA7Jkkp3WP2zljECXlP pSiWXIF6m7UxwyEqa1Gl3LCvcBuqYhHXMdQI6BMMYHT6Ux1CP9a7iWJ5HW/BiPZEJa0w Lo/G490AaghDCjLxE4LDa3KBmPgjeaytGziiOh25PJ7sBROW/mXaPdMqBcBAi8ZRahgb +Z1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723118403; x=1723723203; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l8fBZbfSfQMp8/8SurSvfBz+MaimrqNdI2CubOLP3Ew=; b=GWnRU1iGYc9ImjDjojUN99+EPmtq/+DqbmBrc6/GgDhjs/1lyugWCWL0UxJw6iIbMu lGtBLkigJkC9s+VV4oWTcW/ZKpEv+30NMLkITI7R7MQ0H4+U7qYUOC2IJt+wOU0nyzX2 QTyVc1BW3Tybcoi6ADTIRrzeG88ldHnaNw/QU2C66RUODK+RqUKdcaDa8eMD1/ZGET65 Kc9GZhn4eJ0qG9fJUUvkZWFbeeDRu+PXUiYr5RDSQPEss3dUggDLvrJMyWjhuCg3n+81 FsAnYbSJik/wcO6HvZkeMapYNKgzN1dRaRrpwxeJgfBeWo3WWLXUIGmzxDcngwLByNyQ e+4g== X-Forwarded-Encrypted: i=1; AJvYcCUCFGxdCfAmIbjA/N7KoXohLVY6Kt5SKCf3BkGvhI80KotOvDU1K78Q1R05up48yst2L/O7K82pTgA83cm6vlTFCNP+wcoy X-Gm-Message-State: AOJu0Yx8NTt9lXQ+qyJM3kxd48+DnIbwCcSEirOC2f4lKtIKNstK886C BbCbZvpjlW3shNIJISDcu5tGNKhpaqnxXae+j4+00G1oD5ClouWfxtPGFmNHIIk= X-Google-Smtp-Source: AGHT+IHHX2fBYyF3bzrkIN6FI+lRc2WcNWD9HizbtFbwpwdbf6zDJoYFHOfDyhNaZKL5sM+Jijm6XQ== X-Received: by 2002:a5d:698f:0:b0:367:8fee:443b with SMTP id ffacd0b85a97d-36d27561461mr1129489f8f.41.1723118402280; Thu, 08 Aug 2024 05:00:02 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36d27156c8asm1700288f8f.24.2024.08.08.05.00.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Aug 2024 05:00:01 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 751635F769; Thu, 8 Aug 2024 13:00:00 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , David Stevens Subject: Re: [PATCH v12 13/84] KVM: Annotate that all paths in hva_to_pfn() might sleep In-Reply-To: <20240726235234.228822-14-seanjc@google.com> (Sean Christopherson's message of "Fri, 26 Jul 2024 16:51:22 -0700") References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-14-seanjc@google.com> Date: Thu, 08 Aug 2024 13:00:00 +0100 Message-ID: <87bk23ql6n.fsf@draig.linaro.org> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sean Christopherson writes: > Now that hva_to_pfn() no longer supports being called in atomic context, > move the might_sleep() annotation from hva_to_pfn_slow() to > hva_to_pfn(). The commentary for hva_to_pfn_fast disagrees. /* * The fast path to get the writable pfn which will be stored in @pfn, * true indicates success, otherwise false is returned. It's also the * only part that runs if we can in atomic context. */ static bool hva_to_pfn_fast(struct kvm_follow_pfn *kfp, kvm_pfn_t *pfn) At which point did it loose the ability to run in the atomic context? I couldn't work it out from the commits. > > Signed-off-by: Sean Christopherson > --- > virt/kvm/kvm_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 84c73b4fc804..03af1a0090b1 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -2807,8 +2807,6 @@ static int hva_to_pfn_slow(unsigned long addr, bool= *async, bool write_fault, > struct page *page; > int npages; >=20=20 > - might_sleep(); > - > if (writable) > *writable =3D write_fault; >=20=20 > @@ -2947,6 +2945,8 @@ kvm_pfn_t hva_to_pfn(unsigned long addr, bool inter= ruptible, bool *async, > kvm_pfn_t pfn; > int npages, r; >=20=20 > + might_sleep(); > + > if (hva_to_pfn_fast(addr, write_fault, writable, &pfn)) > return pfn; --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro