From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06183C433EF for ; Wed, 24 Nov 2021 18:09:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B490C4B1D2; Wed, 24 Nov 2021 13:09:28 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Nj1WO8+KaFUU; Wed, 24 Nov 2021 13:09:27 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 790DE4B0F1; Wed, 24 Nov 2021 13:09:27 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B0DC14B0B9 for ; Wed, 24 Nov 2021 13:09:25 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fNMJPDzLl6g9 for ; Wed, 24 Nov 2021 13:09:24 -0500 (EST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 266254B0F1 for ; Wed, 24 Nov 2021 13:09:24 -0500 (EST) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6100C60FE8; Wed, 24 Nov 2021 18:09:22 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mpwhn-007dLK-9U; Wed, 24 Nov 2021 18:09:15 +0000 Date: Wed, 24 Nov 2021 18:09:14 +0000 Message-ID: <87czmpcto5.wl-maz@kernel.org> From: Marc Zyngier To: Tyler Baicar Subject: Re: [PATCH 1/2] ACPI/AEST: Initial AEST driver In-Reply-To: <20211124170708.3874-2-baicar@os.amperecomputing.com> References: <20211124170708.3874-1-baicar@os.amperecomputing.com> <20211124170708.3874-2-baicar@os.amperecomputing.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: baicar@os.amperecomputing.com, patches@amperecomputing.com, abdulhamid@os.amperecomputing.com, darren@os.amperecomputing.com, catalin.marinas@arm.com, will@kernel.org, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, lorenzo.pieralisi@arm.com, guohanjun@huawei.com, sudeep.holla@arm.com, rafael@kernel.org, lenb@kernel.org, tony.luck@intel.com, bp@alien8.de, mark.rutland@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, tabba@google.com, marcan@marcan.st, keescook@chromium.org, jthierry@redhat.com, masahiroy@kernel.org, samitolvanen@google.com, john.garry@huawei.com, daniel.lezcano@linaro.org, gor@linux.ibm.com, zhangshaokun@hisilicon.com, tmricht@linux.ibm.com, dchinner@redhat.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-acpi@vger.kernel.org, linux-edac@vger.kernel.org, ishii.shuuichir@fujitsu.com, Vineeth.Pillai@microsoft.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: abdulhamid@os.amperecomputing.com, daniel.lezcano@linaro.org, rafael@kernel.org, catalin.marinas@arm.com, ishii.shuuichir@fujitsu.com, guohanjun@huawei.com, vincenzo.frascino@arm.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, lorenzo.pieralisi@arm.com, masahiroy@kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, samitolvanen@google.com, patches@amperecomputing.com, lenb@kernel.org, keescook@chromium.org, gor@linux.ibm.com, anshuman.khandual@arm.com, john.garry@huawei.com, zhangshaokun@hisilicon.com, Vineeth.Pillai@microsoft.com, bp@alien8.de, darren@os.amperecomputing.com, dchinner@redhat.com, tglx@linutronix.de, linux-edac@vger.kernel.org, tony.luck@intel.com, jthierry@redhat.com, marcan@marcan.st, linux-kernel@vger.kernel.org, sudeep.holla@arm.com, tmricht@linux.ibm.com X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, 24 Nov 2021 17:07:07 +0000, Tyler Baicar wrote: > > Add support for parsing the ARM Error Source Table and basic handling of > errors reported through both memory mapped and system register interfaces. > > Assume system register interfaces are only registered with private > peripheral interrupts (PPIs); otherwise there is no guarantee the > core handling the error is the core which took the error and has the > syndrome info in its system registers. > > Add logging for all detected errors and trigger a kernel panic if there is > any uncorrected error present. > > Signed-off-by: Tyler Baicar > --- > MAINTAINERS | 1 + > arch/arm64/include/asm/ras.h | 52 ++++ > arch/arm64/include/asm/sysreg.h | 2 + > arch/arm64/kernel/Makefile | 1 + > arch/arm64/kernel/ras.c | 125 +++++++++ > arch/arm64/kvm/sys_regs.c | 2 + > drivers/acpi/arm64/Kconfig | 3 + > drivers/acpi/arm64/Makefile | 1 + > drivers/acpi/arm64/aest.c | 450 ++++++++++++++++++++++++++++++++ > include/linux/acpi_aest.h | 50 ++++ > include/linux/cpuhotplug.h | 1 + > 11 files changed, 688 insertions(+) > create mode 100644 arch/arm64/include/asm/ras.h > create mode 100644 arch/arm64/kernel/ras.c > create mode 100644 drivers/acpi/arm64/aest.c > create mode 100644 include/linux/acpi_aest.h > > diff --git a/MAINTAINERS b/MAINTAINERS > index 5250298d2817..aa0483726606 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -382,6 +382,7 @@ ACPI FOR ARM64 (ACPI/arm64) > M: Lorenzo Pieralisi > M: Hanjun Guo > M: Sudeep Holla > +R: Tyler Baicar > L: linux-acpi@vger.kernel.org > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > S: Maintained Isn't this a bit premature? This isn't even mentioned in the commit message, only in passing in the cover letter. > diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h > index 16b3f1a1d468..6bbed061d835 100644 > --- a/arch/arm64/include/asm/sysreg.h > +++ b/arch/arm64/include/asm/sysreg.h > @@ -230,6 +230,8 @@ > #define SYS_ERXADDR_EL1 sys_reg(3, 0, 5, 4, 3) > #define SYS_ERXMISC0_EL1 sys_reg(3, 0, 5, 5, 0) > #define SYS_ERXMISC1_EL1 sys_reg(3, 0, 5, 5, 1) > +#define SYS_ERXMISC2_EL1 sys_reg(3, 0, 5, 5, 2) > +#define SYS_ERXMISC3_EL1 sys_reg(3, 0, 5, 5, 3) > #define SYS_TFSR_EL1 sys_reg(3, 0, 5, 6, 0) > #define SYS_TFSRE0_EL1 sys_reg(3, 0, 5, 6, 1) > > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > index e3ec1a44f94d..dc15e9896db4 100644 > --- a/arch/arm64/kvm/sys_regs.c > +++ b/arch/arm64/kvm/sys_regs.c > @@ -1573,6 +1573,8 @@ static const struct sys_reg_desc sys_reg_descs[] = { > { SYS_DESC(SYS_ERXADDR_EL1), trap_raz_wi }, > { SYS_DESC(SYS_ERXMISC0_EL1), trap_raz_wi }, > { SYS_DESC(SYS_ERXMISC1_EL1), trap_raz_wi }, > + { SYS_DESC(SYS_ERXMISC2_EL1), trap_raz_wi }, > + { SYS_DESC(SYS_ERXMISC3_EL1), trap_raz_wi }, > This looks like a fix that would deserve its own patch. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm