From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E6EC32E69C for ; Mon, 24 Nov 2025 21:25:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764019539; cv=none; b=SUurKSVoaE73fI6fH2LqtDck/U+cVadW9ZNXh9+oV7hYAQXqS+W3Q5a3J8avrP2LNjkBQpUnDuUEIA/iKi4NNYGz6iySI+2s2cgQd7yaklkvhTe7lCPrKqxw0fxFXmSgJ/98f1iV8onzrMKltQg6J8o3Lh28UEuCs30PhkowhbQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764019539; c=relaxed/simple; bh=IpQ8nkiZSNmMXfvD0PdcmN2xhvobxWovSWeKwhUHOck=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=gMR6UnBBphQX7CcIxlTqdEytDmOq4EidIzzfz0PoKgb9F05n5vmbcNWQSGN4gpOu3CA7Q2MQ+qxkd1i3btltrgDEgjin0io3uDHikEte91KF9ZUlOHnQbfAAN4FWn9VoE2xfXz+6m7hFrdhqL1L4LXX4KNxGGXLPMgnq80EUgh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iwbRaPa7; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iwbRaPa7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF050C4CEF1; Mon, 24 Nov 2025 21:25:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764019538; bh=IpQ8nkiZSNmMXfvD0PdcmN2xhvobxWovSWeKwhUHOck=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iwbRaPa7OQhvPvL3zXjpLJhEcMednA0rLYVmleZFDDZr/QJmlKzyFqN0ks2Gnz18a 1xyrExoBPEvgixcHpcTGPwKscy2Gtz1sllPbQwATCa/iWiDwkCFdjWqQ0OkxwwAdB+ Ykfjl/jBMuUUm976XH6+4zGvqCU0q1ZA9CQEEuNOHrLl7VCzpO8k6hL80xRGn06lsu UPQI1O6xXrgmzknegCvq+zR3co52eLvc3qOQhn6fa73GiFXnyIZY+yDRufbJYdOF8E TESLWTKGJtgx/0q0pdhzBVTR4Z8wMal7+O9VVHJjjapc0hu6StR4GF3L7etfHf96sj kszQyXLZEIzNg== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vNe40-00000007yhT-1KWC; Mon, 24 Nov 2025 21:25:36 +0000 Date: Mon, 24 Nov 2025 21:25:35 +0000 Message-ID: <87fra3f7hs.wl-maz@kernel.org> From: Marc Zyngier To: Oliver Upton Cc: kvmarm@lists.linux.dev, Joey Gouly , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH v3 00/15] KVM: arm64: nv: Implement FEAT_XNX and FEAT_HAF In-Reply-To: <20251124190158.177318-1-oupton@kernel.org> References: <20251124190158.177318-1-oupton@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oupton@kernel.org, kvmarm@lists.linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 24 Nov 2025 19:01:42 +0000, Oliver Upton wrote: > > Fixes all the issues Marc found in v2: > > v2: https://lore.kernel.org/kvmarm/20251117224325.2431848-1-oupton@kernel.org/ > > v2 -> v3: > - Don't use uninitialized XN value in kvm_pgtable_stage2_relax_perms() > - Pass vcpu pointer directly in the stage-2 PTW > - Ensure LL/SC swap implementation correctly handles compare failures > - Fix SRCU imbalance Thanks for the quick respin, this looks pretty good now. I've taken it for a ride on the usual setup, and this time nothing caught fire. FWIW: Reviewed-by: Marc Zyngier Tested-by: Marc Zyngier M. -- Jazz isn't dead. It just smells funny.