From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17CE616F267 for ; Thu, 1 Aug 2024 09:53:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722506031; cv=none; b=Rk86cKGrxwlowHo9OLeVIsraOdZBlqCz21TqAcfN/PQjXhQnKdJUkmlZ/BmlDB5sQ069I7vE5H5jCdCEA4vZPvg5xX7o1P4t9dECvqsv46RGB/gZN+Kd7BWX2Vw7q0CpBjU/XrUK+uxo0wGAKrV7wcTyLoVtYarVJugZsYCA4uk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722506031; c=relaxed/simple; bh=RZpvv9TExV/YqUUjMHmoW7U1MADjmJXiZRuzMf5dgoY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=EMkSRGi2uKC7+K7Rte30hxiRpafQd+7aqmrjIDM/zSVE3CTLkL7U0kz9uAFV8HeajtK14Vb3Ob/6kWfIgdsYFzbkr948lePeWsS2BKHh6nZia6h/koW/xXS2ov8jvx9/oZx+3avsjZnRSAFv4vnE+Ah0+oJWbx+ITREDEutRrAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JxlpAED4; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JxlpAED4" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5a79df5af51so3486278a12.0 for ; Thu, 01 Aug 2024 02:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722506028; x=1723110828; darn=lists.linux.dev; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=8MGDW2w0EUrwnI4S//nT3S+vOipXyZxOwDlAdIY1JMk=; b=JxlpAED4oqR2gRgi4lAt9v4jqFsHhstbX3fk6rH1KuHqH8KTim9/ZwRy6y7IAJ1ilo SL9Wnl7vQ1Q+N6LAldn32HZB4Bw+y+T/ISNaK/CbdYjFmA2aEoivf+E3Acf2dBu3QF8+ fqqmyed1zUuKXvF5ah7+uVjW5muhrT2C23lMeXvYEmD/9hQUl62BSdjBw0NHd3N/6sb7 X9Z+qv5kXP4n1Ops4Ok/cuFdVoUAMSx8FjtHjLu5bNgyYzxGKCpnMsDHWduI7uv4eaNm Le+01isRFuWZSzzwEP2Jigx9xV+y0QJvy9OQgoMFnHM2qThXYejryEVOIqh8Sy8phFxo 3Kyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722506028; x=1723110828; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8MGDW2w0EUrwnI4S//nT3S+vOipXyZxOwDlAdIY1JMk=; b=D2+/0pO0zoFWh/iR82GUvTpAC/HkbB5S/jJ5tH++Y6NcFaq9sDPM6vTjUaSHsJNYY3 gSlsdsvtG1AcqQ1kZrXYOJ+/uG/rR8iWP2xQFKtcFJdB9n1E87DlvfSTzYReP8ij7a+X UBPSWheCn7JEJBZSlL+WttfYPiS7RKSZkyGAqymLsbfoBfz6VTLINnUonCPE2riJZMlw zXCcyWi2jRbQlSc/IcIOuhfsgCfcilG6bDmdfQh3O2HJLDf2hd4kjpXqQ7CQdsmugzwY Cd4mNCjjBKq+cxS+1M6d4NBJTAg/R+rZyLcN4/QNOwGFqOm/iYgRYSFwnXNIbqS6wJIM 1n1A== X-Forwarded-Encrypted: i=1; AJvYcCU6D/0Hh4c9ihNeOsA2JCTFu1H/s1LLVp11ekB+siO+Hd/aYLHmbQMxqtq4BfIJiO2Szge0QamKiTCPkOS6uzHJz9yzmEDZ X-Gm-Message-State: AOJu0YyyYwrqM3NrNLQtb+oAbXO0xh+mHtumA3PDVCgfyKVNp4lr0W7S 3MM5PqcOah+1+PU914mcoBVtzi71bYQckMqFoki6haYTiQhHKrR/BJqXSkG/MAg= X-Google-Smtp-Source: AGHT+IHNrw29WKyolinu6cyXHFfq+0WsM6WXcBxZ1/oFvQaGEtI1aOWo6VY84S/JlZwJgkWdM0qlVw== X-Received: by 2002:a05:6402:440d:b0:57d:5442:a709 with SMTP id 4fb4d7f45d1cf-5b778dc53f8mr879162a12.0.1722506028149; Thu, 01 Aug 2024 02:53:48 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5b5257f39adsm2866327a12.96.2024.08.01.02.53.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Aug 2024 02:53:41 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id CC0595F80C; Thu, 1 Aug 2024 10:53:39 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , David Stevens Subject: Re: [PATCH v12 24/84] KVM: Use plain "struct page" pointer instead of single-entry array In-Reply-To: <20240726235234.228822-25-seanjc@google.com> (Sean Christopherson's message of "Fri, 26 Jul 2024 16:51:33 -0700") References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-25-seanjc@google.com> Date: Thu, 01 Aug 2024 10:53:39 +0100 Message-ID: <87le1gefh8.fsf@draig.linaro.org> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sean Christopherson writes: > Use a single pointer instead of a single-entry array for the struct page > pointer in hva_to_pfn_fast(). Using an array makes the code unnecessarily > annoying to read and update. > > No functional change intended. > > Signed-off-by: Sean Christopherson Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro