From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7F4225B091; Sat, 1 Aug 2026 13:36:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785591408; cv=none; b=AgtxQRs5vU7cjjsh4mpopSX/zx30OjE4esmGLWkulIU7aq8gaMhk+TjD6fsgs6aTdISHucN+BhDb1twjVZQRuznuM8DgM1X2yeoIaOdwlhzMEhQW0Abt5Mvi/nhVwaH7rb/MMBGXqC7wehceNmONXyXRr7eC6t0jdMpXIsnQxBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785591408; c=relaxed/simple; bh=4lKE/JPr11JJMVfr6ze6B58tQIRtPBSCcs0d1AhqCas=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=SxXuKilBPfYCmNG9GyRV5ZCnPykATAsod6sSVt5aPrMRJP2b1QESVd+0X6xrlz6sioliaxhk5R/CsUOydmAuI5hAq10pNiqZtfSDm7Mx3Wi3eYHQwV4DSKqciZhvFo40uLKKfkGkgzZTrb6/z+3PA+M+/VBKPLj66GtgqkFNOfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZIL7mpol; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZIL7mpol" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B52F61F00AC4; Sat, 1 Aug 2026 13:36:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785591407; bh=92dPf4qeonlx2miTfxvE81cldvTp+iKhucxLs3AX8kY=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=ZIL7mpolIQDGuznVf5TXeM1+vhycp08kSHiXlbHnBWr6ajm4tCdZJhTsX2A1DG2dc ASBv/EypboYl7zFOAzijjCBsWQCht3ZMKzmYpHBxwtzXJGyWDk2LcvVPRXNJnI+AJN bnYUXl/JHyx0g26WGZWTrBXzufjDMLATKwEjbjt+M5nZfYbgCNBMDLyvZGvOU8LNxt xI4YXU5qRYEJ5uDuiBaCQNIXjc5c+9KhDKhycaNCo1ot2cNiZOXOebdazfqoNTyWOi oFlMRXATzLkJ7kvxOHjrgTmvMGs9dmWq0YoFzRB1SmEdfKoQrcOtHKBNiG+RiPwzAs JJE/n2qnoIC1g== Received: from sofa.misterjones.org ([185.219.108.64] helo=lobster-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wq9tN-0000000BGvn-45wp; Sat, 01 Aug 2026 13:36:46 +0000 Date: Sat, 01 Aug 2026 14:40:57 +0100 Message-ID: <87pl02ot5i.wl-maz@kernel.org> From: Marc Zyngier To: sashiko-reviews@lists.linux.dev Cc: "Oliver Upton" , kvm@vger.kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH 4/6] KVM: arm64: Correctly handle end of VA space TLBI invalidation In-Reply-To: <20260801130337.EB2BA1F00AC4@smtp.kernel.org> References: <20260801124818.366274-1-maz@kernel.org> <20260801124818.366274-5-maz@kernel.org> <20260801130337.EB2BA1F00AC4@smtp.kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: sashiko-reviews@lists.linux.dev, oupton@kernel.org, kvm@vger.kernel.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Sat, 01 Aug 2026 14:03:37 +0100, sashiko-bot@kernel.org wrote: > > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > > Pre-existing issues: > - [High] Missing sign-extension in `decode_range_tlbi()` breaks > - Stage-1 range TLB invalidations (e.g., `TLBI RVAE1`) for TTBR1 > - addresses. Yup, that's yet another bug. I'll queue this: diff --git a/arch/arm64/include/asm/kvm_nested.h b/arch/arm64/include/asm/kvm_nested.h index cc48817a5bf7a..f1ce0d9fd50ef 100644 --- a/arch/arm64/include/asm/kvm_nested.h +++ b/arch/arm64/include/asm/kvm_nested.h @@ -290,6 +290,7 @@ static inline u64 decode_range_tlbi(u64 val, u64 *range, u16 *asid) } base = (val & GENMASK(36, 0)) << shift; + base = (u64)sign_extend64(base, 48); if (asid) *asid = FIELD_GET(TLBIR_ASID_MASK, val); Thanks, M. -- Jazz isn't dead. It just smells funny.