From mboxrd@z Thu Jan  1 00:00:00 1970
From: Punit Agrawal <punit.agrawal@arm.com>
Subject: Re: [PATCH v6 1/8] KVM: arm/arm64: Share common code in user_mem_abort()
Date: Mon, 16 Jul 2018 14:28:24 +0100
Message-ID: <87r2k3mhs7.fsf@e105922-lin.cambridge.arm.com>
References: <20180716110857.19310-1-punit.agrawal@arm.com>
        <20180716110857.19310-2-punit.agrawal@arm.com>
        <c28e1aa4-c0f1-8010-6a11-005e7f1db01c@arm.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <c28e1aa4-c0f1-8010-6a11-005e7f1db01c@arm.com> (Suzuki
        K. Poulose's message of "Mon, 16 Jul 2018 13:45:05 +0100")
Sender: linux-kernel-owner@vger.kernel.org
To: Suzuki K Poulose <Suzuki.Poulose@arm.com>
Cc: kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, will.deacon@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
List-Id: kvmarm@lists.cs.columbia.edu

Hi Suzuki,

Suzuki K Poulose <Suzuki.Poulose@arm.com> writes:

> On 16/07/18 12:08, Punit Agrawal wrote:
>> The code for operations such as marking the pfn as dirty, and
>> dcache/icache maintenance during stage 2 fault handling is duplicated
>> between normal pages and PMD hugepages.
>>
>> Instead of creating another copy of the operations when we introduce
>> PUD hugepages, let's share them across the different pagesizes.
>>
>> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
>> Cc: Christoffer Dall <christoffer.dall@arm.com>
>> Cc: Marc Zyngier <marc.zyngier@arm.com>
>
> Thanks for splitting the patch. It looks much simpler this way.
>
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>

Thanks for reviewing the patches.

Punit

> _______________________________________________
> kvmarm mailing list
> kvmarm@lists.cs.columbia.edu
> https://lists.cs.columbia.edu/mailman/listinfo/kvmarm