From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6C3DCCA47B for ; Fri, 8 Jul 2022 08:05:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 42FE34B6B6; Fri, 8 Jul 2022 04:05:34 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sfQ4C1tjUzpP; Fri, 8 Jul 2022 04:05:33 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 20BAB4B651; Fri, 8 Jul 2022 04:05:33 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id BC4A94B64B for ; Fri, 8 Jul 2022 04:05:31 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YaRdxmjww79h for ; Fri, 8 Jul 2022 04:05:30 -0400 (EDT) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 9E1E24B648 for ; Fri, 8 Jul 2022 04:05:30 -0400 (EDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B82B062619; Fri, 8 Jul 2022 08:05:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23ADFC341C8; Fri, 8 Jul 2022 08:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657267529; bh=QtAuw959KuTNtR8cxJBTQZYkriCeywcshOCm/oZxxx0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Beg0f7gbAlHooxeO1KGbh7oDxPWT+OnCe9cSa/R044hKFWZFckT7cIklOCP1QmW/k IbuOO0z69OvMJ55MQAakcflrglXbQlA0b23rY9uGguSClMJzsbfFXxevInYepP/g16 ZNW8nJQAMhbQtD8YUoomCj5dSTHS1yNTH939EkrgJAueMblB+c5bH2sM/ThhIW2ouG A8m/dlmkKBtGvOEC4yIaP3jCYlc64dUvhmanOuvGk/uhqIKUI1b/eqeXSv1iHyLkAn eOCXS7XjDNEpEdjj6Uvu6m35ccVMI9hmjSvybStlC6YXqH0zxecySxnIhdqxWt8xwW 7HrI+tjpS7QYg== Received: from [213.208.244.172] (helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1o9izO-0065zO-PW; Fri, 08 Jul 2022 09:05:27 +0100 Date: Fri, 08 Jul 2022 09:05:25 +0100 Message-ID: <87sfnckp16.wl-maz@kernel.org> From: Marc Zyngier To: Reiji Watanabe Subject: Re: [PATCH 04/19] KVM: arm64: Push checks for 64bit registers into the low-level accessors In-Reply-To: References: <20220706164304.1582687-1-maz@kernel.org> <20220706164304.1582687-5-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 213.208.244.172 X-SA-Exim-Rcpt-To: reijiw@google.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, schspa@gmail.com, kernel-team@android.com, oliver.upton@linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: kvm@vger.kernel.org, Schspa Shi , Oliver Upton , kernel-team@android.com, kvmarm@lists.cs.columbia.edu, Linux ARM X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, 08 Jul 2022 07:13:36 +0100, Reiji Watanabe wrote: > > Hi Marc, > > On Wed, Jul 6, 2022 at 9:43 AM Marc Zyngier wrote: > > > > Make sure the check occurs on every paths where we can pick > > a sysreg from userspace, including the GICv3 paths. > > > > Signed-off-by: Marc Zyngier > > --- > > arch/arm64/kvm/sys_regs.c | 10 ++++------ > > 1 file changed, 4 insertions(+), 6 deletions(-) > > > > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > > index 0fbdb21a3600..89e7eddea937 100644 > > --- a/arch/arm64/kvm/sys_regs.c > > +++ b/arch/arm64/kvm/sys_regs.c > > @@ -2656,6 +2656,10 @@ const struct sys_reg_desc *get_reg_by_id(u64 id, > > { > > struct sys_reg_params params; > > > > + /* 64 bit is the only way */ > > + if (KVM_REG_SIZE(id) != sizeof(__u64)) > > + return NULL; > > This doesn't seem to be necessary since the equivalent check > is done by index_to_params(). Ah, well spotted. Amusing how many times we check for the same thing! I'll simplify the patch and amend the commit message. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm