From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41C321E1A2 for ; Thu, 10 Aug 2023 14:43:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B119AC433C7; Thu, 10 Aug 2023 14:43:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691678606; bh=MjMPBofj9eixKpMqEVyk0yamw7dMCKm//JFQsitXUOQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=G10d5hVjRTjzj9efCgSrdYmFKSG/1wbZm/+5H0OG2PoQ+KV3x/v+Uq/FWWFvNKbcm PWfvj/6Hp1EaBfMFmDwuU0LbZI/4ecgLupDb9n+islaE1Z+hu9+kxuy1w67AHj0a2c 6ch5/EhlSLJegSDHq4oXi5CUjPfFWynhjtL13N4zY55Dl0fkBRPBTh0slixdUQ13Cn gu7YSxXqiH847+GLgDu3xfaZFYOmj0O4QaIiTqUQc4j/j5Pf1gezTfU8XN/0YMTRZB nueFK9mNhiaQhGAWz7QF1/efofdDVCRLZCSkk+VgK+zFvV2qoo/93tXd8Vm9QgzmBL 7jovM2cCiLBNA== Received: from c-xd4ed8728.customers.hiper-net.dk ([212.237.135.40] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1qU6sm-003qzZ-8w; Thu, 10 Aug 2023 15:43:24 +0100 Date: Thu, 10 Aug 2023 15:43:32 +0100 Message-ID: <87v8dnot4b.wl-maz@kernel.org> From: Marc Zyngier To: Miguel Luis Cc: "kvmarm@lists.linux.dev" , "kvm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Catalin Marinas , Eric Auger , Mark Brown , Mark Rutland , Will Deacon , Alexandru Elisei , Andre Przywara , Chase Conklin , Ganapatrao Kulkarni , Darren Hart , James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu Subject: Re: [PATCH v3 14/27] KVM: arm64: nv: Add trap forwarding infrastructure In-Reply-To: <65770FF0-A864-4678-8280-AE9BD666CC12@oracle.com> References: <20230808114711.2013842-1-maz@kernel.org> <20230808114711.2013842-15-maz@kernel.org> <65770FF0-A864-4678-8280-AE9BD666CC12@oracle.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 212.237.135.40 X-SA-Exim-Rcpt-To: miguel.luis@oracle.com, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, eric.auger@redhat.com, broonie@kernel.org, mark.rutland@arm.com, will@kernel.org, alexandru.elisei@arm.com, andre.przywara@arm.com, chase.conklin@arm.com, gankulkarni@os.amperecomputing.com, darren@os.amperecomputing.com, james.morse@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, yuzenghui@huawei.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Hi Miguel, On Wed, 09 Aug 2023 19:28:08 +0100, Miguel Luis wrote: > > Hi Marc, > > > On 8 Aug 2023, at 11:46, Marc Zyngier wrote: [...] > > + for (int id = __MULTIPLE_CONTROL_BITS__; > > + id < (__COMPLEX_CONDITIONS__ - 1); > > This condition seems to be discarding the last MCB from being checked, > which IIUC it must also be checked. Indeed, well caught. Now fixed. Thanks, M. -- Without deviation from the norm, progress is not possible.