From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF1898BF1 for ; Wed, 7 Dec 2022 19:15:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8979DC433C1; Wed, 7 Dec 2022 19:15:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670440559; bh=ZPzK6q04L/2RwzpjReiIvxe9bN5AwfjCz4hPurBM3P4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Sbpol4z0UAZgjcs6rlWJ6c6LhxqgnbXX2zYkfGjfs8wwCeaE+bln8HMyPJLgjxFpZ o7cloxgnqnz1BEwIIK9ZuEizvCNH6xWteJl+DWrzpa/Ct9s/jLHuHEseOhIE0kTg7y 3KJy2Yk0aLmsSC3jY/UW36c9XdaHm2umk45MBsdIir+enqDRDSo9YOfC47EGVQsHja YoekoJxRCiFT2mntBFPmmYz4A+U7GbwhzjgBogkzCjXT/9tvsXhspGk7mtXiRTdwxp ooHuWXUpTp9jPcerf+UJFHppxZp+3XocepFqKl7dUL76AWbG7zXrJx4twPezxh5+PF 55tiuL5Dhi9Ug== Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p2ztd-00BBoa-4z; Wed, 07 Dec 2022 19:15:57 +0000 Date: Wed, 07 Dec 2022 19:14:16 +0000 Message-ID: <87v8mnrppz.wl-maz@kernel.org> From: Marc Zyngier To: Mark Brown Cc: Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Mark Rutland , Sami Mujawar , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev Subject: Re: [PATCH v2 05/14] arm64/asm: Introduce assembly macros for managing ALLINT In-Reply-To: References: <20221112151708.175147-1-broonie@kernel.org> <20221112151708.175147-6-broonie@kernel.org> <86tu29lpwt.wl-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: broonie@kernel.org, catalin.marinas@arm.com, will@kernel.org, lpieralisi@kernel.org, mark.rutland@arm.com, Sami.Mujawar@arm.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 05 Dec 2022 18:24:09 +0000, Mark Brown wrote: > > On Mon, Dec 05, 2022 at 05:29:54PM +0000, Marc Zyngier wrote: > > On Sat, 12 Nov 2022 15:16:59 +0000, > > Mark Brown wrote: > > > > In order to allow assembly code to ensure that not even superpriorty > > > interrupts can preempt it provide macros for enabling and disabling > > ^ > > \ Insert comma here > > That would give ...not even superpriority interrupts can preempt, it" > which doesn't make sense to me? Well, clearly the ^ is misaligned, and should probably(?) be after the 'it'. Try reading the sentence out loud, only taking a breath when you encounter a punctuation sign. That should give you an idea of what is missing... M. -- Without deviation from the norm, progress is not possible.