From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F8C0C433F5 for ; Tue, 16 Nov 2021 14:54:43 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 8DEA561A6C for ; Tue, 16 Nov 2021 14:54:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8DEA561A6C Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1E2954B1AF; Tue, 16 Nov 2021 09:54:42 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@suse.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u4HT34-znvT4; Tue, 16 Nov 2021 09:54:40 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A94834B0F1; Tue, 16 Nov 2021 09:54:40 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 449E54B0F1 for ; Tue, 16 Nov 2021 09:54:39 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gTCZlp3EuhXY for ; Tue, 16 Nov 2021 09:54:38 -0500 (EST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id F2F564B0DE for ; Tue, 16 Nov 2021 09:54:37 -0500 (EST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9619D2114E; Tue, 16 Nov 2021 14:54:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1637074476; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a+v9JQYnrs8peEURXnbQYKeNePpdGGkZ2eqbcqMIENw=; b=R9CHzFMjCfoDrZrR23Q7ONwMki3szKy/Y/3Em0W9RqXHXk+W4uJkbCB/9+M7Ti/Y2VTSdv dViIzdYoqwwsNeannyWOjKI7Axy+AbRXq90q9uUYxVDavtIP8vxKOCWhc8KxaLcGXpIk65 LKCpdXLycTCAsV+YzhRK+Uxer4GirQo= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EF01213C1B; Tue, 16 Nov 2021 14:54:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7nsLOSvGk2GBJAAAMHmgww (envelope-from ); Tue, 16 Nov 2021 14:54:35 +0000 Subject: Re: [PATCH 0/5] KVM: Turn the vcpu array into an xarray To: Paolo Bonzini , Marc Zyngier , kvm@vger.kernel.org, linux-mips@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linuxppc-dev@lists.ozlabs.org References: <20211105192101.3862492-1-maz@kernel.org> <6232cbcb-b2e2-e79f-a520-43d552f35243@suse.com> From: Juergen Gross Message-ID: <959bb356-d938-9923-a495-46afc6615bc3@suse.com> Date: Tue, 16 Nov 2021 15:54:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Cc: Huacai Chen , Janosch Frank , Christian Borntraeger , Anup Patel , David Hildenbrand , Nicholas Piggin , Atish Patra , Aleksandar Markovic , Paul Mackerras , Michael Ellerman , kernel-team@android.com, Claudio Imbrenda X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2290753686434491684==" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============2290753686434491684== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yUY7U7fkULwGsgK6oZmRHXu9bthtAqpUi" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --yUY7U7fkULwGsgK6oZmRHXu9bthtAqpUi Content-Type: multipart/mixed; boundary="xZHqINRDpzDyjI9JAQ2G7U3R0z87b2fth"; protected-headers="v1" From: Juergen Gross To: Paolo Bonzini , Marc Zyngier , kvm@vger.kernel.org, linux-mips@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linuxppc-dev@lists.ozlabs.org Cc: Huacai Chen , Aleksandar Markovic , Anup Patel , Atish Patra , Christian Borntraeger , Janosch Frank , David Hildenbrand , Claudio Imbrenda , Nicholas Piggin , Sean Christopherson , Paul Mackerras , Michael Ellerman , James Morse , Suzuki K Poulose , Alexandru Elisei , kernel-team@android.com Message-ID: <959bb356-d938-9923-a495-46afc6615bc3@suse.com> Subject: Re: [PATCH 0/5] KVM: Turn the vcpu array into an xarray References: <20211105192101.3862492-1-maz@kernel.org> <6232cbcb-b2e2-e79f-a520-43d552f35243@suse.com> In-Reply-To: --xZHqINRDpzDyjI9JAQ2G7U3R0z87b2fth Content-Type: multipart/mixed; boundary="------------6207551A8E57C6ACC07B0BFF" Content-Language: en-US This is a multi-part message in MIME format. --------------6207551A8E57C6ACC07B0BFF Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 16.11.21 15:21, Paolo Bonzini wrote: > On 11/16/21 15:13, Juergen Gross wrote: >> On 05.11.21 20:20, Marc Zyngier wrote: >>> The kvm structure is pretty large. A large portion of it is the vcpu >>> array, which is 4kB on x86_64 and arm64 as they deal with 512 vcpu >>> VMs. Of course, hardly anyone runs VMs this big, so this is often a >>> net waste of memory and cache locality. >>> >>> A possible approach is to turn the fixed-size array into an xarray, >>> which results in a net code deletion after a bit of cleanup. >>> >>> This series is on top of the current linux/master as it touches the >>> RISC-V implementation. Only tested on arm64. >>> >>> Marc Zyngier (5): >>> =C2=A0=C2=A0 KVM: Move wiping of the kvm->vcpus array to common code >>> =C2=A0=C2=A0 KVM: mips: Use kvm_get_vcpu() instead of open-coded acce= ss >>> =C2=A0=C2=A0 KVM: s390: Use kvm_get_vcpu() instead of open-coded acce= ss >>> =C2=A0=C2=A0 KVM: x86: Use kvm_get_vcpu() instead of open-coded acces= s >>> =C2=A0=C2=A0 KVM: Convert the kvm->vcpus array to a xarray >>> >>> =C2=A0 arch/arm64/kvm/arm.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 | 10 +--------- >>> =C2=A0 arch/mips/kvm/loongson_ipi.c=C2=A0=C2=A0 |=C2=A0 4 ++-- >>> =C2=A0 arch/mips/kvm/mips.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 | 23 ++--------------------- >>> =C2=A0 arch/powerpc/kvm/powerpc.c=C2=A0=C2=A0=C2=A0=C2=A0 | 10 +-----= ---- >>> =C2=A0 arch/riscv/kvm/vm.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 | 10 +--------- >>> =C2=A0 arch/s390/kvm/kvm-s390.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |= 26 ++++++-------------------- >>> =C2=A0 arch/x86/kvm/vmx/posted_intr.c |=C2=A0 2 +- >>> =C2=A0 arch/x86/kvm/x86.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 9 +-------- >>> =C2=A0 include/linux/kvm_host.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |= =C2=A0 7 ++++--- >>> =C2=A0 virt/kvm/kvm_main.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 | 33 ++++++++++++++++++++++++++------- >>> =C2=A0 10 files changed, 45 insertions(+), 89 deletions(-) >>> >> >> For x86 you can add my: >> >> Tested-by: Juergen Gross >=20 > Heh, unfortunately x86 is the only one that needs a change in patch 4. = > I'll Cc you on my version. I guess the changes in kvm_main.c are more important for my series. :-) I've replaced patch 4 with your variant and everything is still working. Not sure how relevant that is, though. Juergen --------------6207551A8E57C6ACC07B0BFF Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjrioyspZKOBy= cWx w3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2kaV2KL9650I1SJvedYm8O= f8Z d621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y= 9bf IhWUiVXEK7MlRgUG6MvIj6Y3Am/BBLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xq= G7/ 377qptDmrk42GlSKN4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR= 3Jv c3MgPGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsEFgIDA= QIe AQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4FUGNQH2lvWAUy+dnyT= hpw dtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3TyevpB0CA3dbBQp0OW0fgCetToGIQrg0= MbD 1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u+6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbv= oPH Z8SlM4KWm8rG+lIkGurqqu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v= 5QL +qHI3EIPtyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVyZ= 2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJCAcDAgEGFQgCC= QoL BBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4RF7HoZhPVPogNVbC4YA6lW7Dr= Wf0 teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz78X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC= /nu AFVGy+67q2DH8As3KPu0344TBDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0Lh= ITT d9jLzdDad1pQSToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLm= XBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkMnQfvUewRz= 80h SnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMBAgAjBQJTjHDXAhsDBwsJC= AcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJn= FOX gMLdBQgBlVPO3/D9R8LtF9DBAFPNhlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1= jnD kfJZr6jrbjgyoZHiw/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0= N51 N5JfVRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwPOoE+l= otu fe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK/1xMI3/+8jbO0tsn1= tqS EUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuZGU+wsB5BBMBAgAjBQJTjHDrA= hsD BwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3= g3O ZUEBmDHVVbqMtzwlmNC4k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5= dM7 wRqzgJpJwK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu5= D+j LRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzBTNh30FVKK1Evm= V2x AKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37IoN1EblHI//x/e2AaIHpzK5h88N= Eaw QsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpW= nHI s98ndPUDpnoxWQugJ6MpMncr0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZR= wgn BC5mVM6JjQ5xDk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNV= bVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mmwe0icXKLk= pEd IXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0Iv3OOImwTEe4co3c1mwARA= QAB wsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMvQ/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEw= Tbe 8YFsw2V/Buv6Z4Mysln3nQK5ZadD534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1= vJz Q1fOU8lYFpZXTXIHb+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8= VGi wXvTyJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqcsuylW= svi uGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5BjR/i1DG86lem3iBDX= zXs ZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------6207551A8E57C6ACC07B0BFF-- --xZHqINRDpzDyjI9JAQ2G7U3R0z87b2fth-- --yUY7U7fkULwGsgK6oZmRHXu9bthtAqpUi Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmGTxisFAwAAAAAACgkQsN6d1ii/Ey8G zAf+JgCNR94TFkw/W/EQ+E/eewdZ/t21kKTYOYfYkvGLjhbQvPaiFaI9VyJ3RIHTIJzHHYIg2cs6 CVQfGqfejImkrO8ZuAUYVpxKLDJSZ4f5sHZgSkY9BWgi8g6FBW+6pUUJNB+zvQkQOIkgSI3pEAa7 hNgUXGRerRALQuRMOs+d5JXU8taJ0xxp/nhdnfVzTeD5jIMmgp4caVtjsqbl4ta/m2UuT1sckxHe wSb6u81OirVsuzm3cSJUbF741VK1RcqX2fVy+SHaI6K257GvAb8zOi7PbqI9d4u0gx73/RlMJYUk E+3C0euqqlu3pS/thZh3+jAN4WUQnhS66gH80TPDkg== =uEM7 -----END PGP SIGNATURE----- --yUY7U7fkULwGsgK6oZmRHXu9bthtAqpUi-- --===============2290753686434491684== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm --===============2290753686434491684==--