From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEC50126F02; Wed, 7 Aug 2024 15:35:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723044919; cv=none; b=SMn+wX4WVk60sE+9nBslLiY3AumQMFd0HjHvwG0vIkFnwwjOVVN2UC8HhJJezFAS9S9SIa3+1VoXLMsD2djNKlQCnB8sH95hbWDgsBv057+Ctte8BkGFS+tCIeIzL8e1IR4x7Btod44Smq6ZViccSMnFPcIXXvulUbbWKrWvnhQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723044919; c=relaxed/simple; bh=wm+VWb1rIQaode09oZdE3sEothizpQCW8kQNxXyWPUY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=nKQvCKjC/I1c11gc6kVTHSY0KK+fRWZgf847HSSFStHkGhus+QuJECtLSammZfbf/I3Xi4bfL+jSIccXebYS1Zc9HqR7IsnOSuxo0nHHDu9WLrApPUxr/C393mhOFSjqsfLL8Gj2B8g9P+zx1kwHWBJOu/HvhVwR5kJ9g+arL0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ATifhC0X; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ATifhC0X" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BF5EC4AF54; Wed, 7 Aug 2024 15:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723044919; bh=wm+VWb1rIQaode09oZdE3sEothizpQCW8kQNxXyWPUY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ATifhC0Xqq0fEe+6e3QBEUliaGC/RbH+BLtwnYSFm80CEEuXHBNyAhkdxqzD7/He2 PwBneWqEUKypiverT0BJeASdXPA4xWYAl2Fkgm10SugKbi+AvScSanh1joAX8Lfmdz KNRPzst2mgF9+1hD/hVdNmv6TzqF0PgyyUodxI6txDAuQNXQBWeHjjnRiNj0hi9VFR 4s6ZMFW5SFkhmRGf+WuQyky1G/K5ad5iSm4yfiVc+3668PKhJ6odz+5QYopqnVL/FP XR95KBjUkyyEZlo8paXYX4cQdTts2wfmd+JcEtHB6KS9KmZ7swK2irnC/LQ+FHdEOK ieljN71TadH9g== Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-52f04c29588so2572025e87.3; Wed, 07 Aug 2024 08:35:19 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXc8jGR5Blu+4sXQzuWUxl47n1zOkw3D5tGxkYnm9fUuIyWrPuqp78gQLC4ZkYQ6W0j63rkvOacOuL1sd6z0BF2K+XySL3N28/c/X0fDsKPkfLoeN6nMmr66Lftpw== X-Gm-Message-State: AOJu0YzlTBCA1LRmAOyNGP4BsDMESMqIh/51l66DA2fpQhXoxVWGShPv p6/MtVaZLSgQbxLoTOY2aqSKYYOQFQ+qXzkiL7zLddAL+57Z4XYVQTwlU61jpoDB4cjK1QDatua I8mZADZhDReeSFl7GhzVLnmlpB4I= X-Google-Smtp-Source: AGHT+IE/eDS6clCryBkFSzKDJUwO/cLwR+b8LrrNB5prXOgRnnwpkLjNgCVKxPqUzynolVNIM+yIL57HzFJ8CFIwBnI= X-Received: by 2002:a05:6512:3e1e:b0:52c:df51:20bc with SMTP id 2adb3069b0e04-530bb3b1531mr13674055e87.16.1723044917569; Wed, 07 Aug 2024 08:35:17 -0700 (PDT) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240807-macos-build-support-v1-0-4cd1ded85694@samsung.com> <20240807-macos-build-support-v1-5-4cd1ded85694@samsung.com> In-Reply-To: <20240807-macos-build-support-v1-5-4cd1ded85694@samsung.com> From: Masahiro Yamada Date: Thu, 8 Aug 2024 00:34:41 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 05/12] accessiblity/speakup: genmap and makemapdata require linux/version.h To: da.gomez@samsung.com Cc: Nathan Chancellor , Nicolas Schier , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , William Hubbs , Chris Brannon , Kirk Reiser , Samuel Thibault , Paul Moore , Stephen Smalley , Ondrej Mosnacek , Catalin Marinas , Will Deacon , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Greg Kroah-Hartman , Jiri Slaby , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, speakup@linux-speakup.org, selinux@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-serial@vger.kernel.org, llvm@lists.linux.dev, Finn Behrens , "Daniel Gomez (Samsung)" , gost.dev@samsung.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable genmap and makemapdata DO NOT require linux/version.h Removing bogus "#include " is the right fix. On Wed, Aug 7, 2024 at 8:10=E2=80=AFAM Daniel Gomez via B4 Relay wrote: > > From: Daniel Gomez > > Both genmap and makemapdata require the linux/version.h header. To > ensure successful builds on macOS hosts, make sure usr/include is > included in the HOSTCFLAGS. > > Fixes errors: > drivers/accessibility/speakup/genmap.c:13:10: fatal error: 'linux/version= .h' file not found > 13 | #include > | ^~~~~~~~~~~~~~~~~ > 1 error generated. > > drivers/accessibility/speakup/makemapdata.c:13:10: fatal error: 'linux/ve= rsion.h' file not found > 13 | #include > | ^~~~~~~~~~~~~~~~~ > 1 error generated. > > Signed-off-by: Daniel Gomez > --- > drivers/accessibility/speakup/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/accessibility/speakup/Makefile b/drivers/accessibili= ty/speakup/Makefile > index 6f6a83565c0d..74ee0c31370f 100644 > --- a/drivers/accessibility/speakup/Makefile > +++ b/drivers/accessibility/speakup/Makefile > @@ -38,6 +38,7 @@ clean-files :=3D mapdata.h speakupmap.h > # Generate mapdata.h from headers > hostprogs +=3D makemapdata > makemapdata-objs :=3D makemapdata.o > +HOSTCFLAGS_makemapdata.o +=3D -I$(srctree)/usr/include > > quiet_cmd_mkmap =3D MKMAP $@ > cmd_mkmap =3D TOPDIR=3D$(srctree) \ > @@ -51,6 +52,7 @@ $(obj)/mapdata.h: $(obj)/makemapdata > # Generate speakupmap.h from mapdata.h > hostprogs +=3D genmap > genmap-objs :=3D genmap.o > +HOSTCFLAGS_genmap.o +=3D -I$(srctree)/usr/include > $(obj)/genmap.o: $(obj)/mapdata.h > > quiet_cmd_genmap =3D GENMAP $@ > > -- > Git-146) > > -- Best Regards Masahiro Yamada