From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C31AC139573 for ; Fri, 3 May 2024 05:02:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714712557; cv=none; b=r7HtdFWRauIzEKt4wvESe3ArjZusyGMHXyp66eCuDTbAPjniCPm0VRmdIzf+R1BAX55Ncx6UmQFEHVbTCO58AwOqofDmSgECamBil+MOoJPvvB5IjXWD1oJ7ibKHyDQlOjQQR46ijcXH43UcqpAQi1O+aC0n4q+RXaAH2MXEXaU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714712557; c=relaxed/simple; bh=cBnukY5BlVrNn1vJZEl4M/AF9tgtsErHvbbW5hT/4YE=; h=Mime-Version:Content-Type:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=YM1wtMOrfZo/Uig9eLLOw8hqqmH+Yb/Z6Tl6RIB8kZXm+VAoJyPOipOmWBeDNlio3Kd9NvkjxjF1Rr0rGEt3E1qMRnR+WU+RSfi8MbbusWyMD+v5kqJfSi7QL9vTXAIywdXmluJnkOwH3NfdWA0qgYI86PGNbZQTrlDT5hkUOj4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mQvHXQF8; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mQvHXQF8" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1eab16dcfd8so75817395ad.0 for ; Thu, 02 May 2024 22:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714712555; x=1715317355; darn=lists.linux.dev; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=rSj/KgnGwyOGI4p8uMj4rCvUcJ//GtBOBEMmF6tDu80=; b=mQvHXQF8AL1FqG71c0b8LK4rGKW+tIIZe/7R+T5HhaEDH2NmdG6TSsXZ3+idwynlCv F1zHNt5nsWGGU+rRFPzgqhgO3RkGlPatIH67nb4ikweihJMHbVMU+j1+bU+QcqILiEFT 0Cf3i8JbkiYRsCzdKOHRAajDHPzUpq+So1kzDZR1sn6y7syr7jXLxlOIgeHqNNiQvSvZ WSFbkCgg1kxy2sGpReVtVrYHxnS/TzEaU3cfyz0cRAKZyQxMQ3E4gIOiH6WavKWdgzMp aWmuunepR3EtoGgBvB8tbIv/Src0UxEwY4HZwyt5dsubCax96WBtL+50PaGEOudaEO+R hY8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714712555; x=1715317355; h=in-reply-to:references:to:from:subject:cc:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=rSj/KgnGwyOGI4p8uMj4rCvUcJ//GtBOBEMmF6tDu80=; b=omy+o4533CnCCgjPWmZkVVuNc2oPNd/ccovYXdgVURrOsGGjT+AQS8lTmonDwjIe/m Vv6nearlIGoiuPvTxO7QvTtqV6LmjePg8SPeHdIf5Cz3bl0O6+qYSk7IxzfUnXUEEY5M PrHkvR7AuGGj1MLFXy4ZiDTFfgxPb/xl/wE5ckxFSq53TMvTFsvDzAMYTN7JRArn+t7E 491n49kGDlqHRDypNGmP++AHU8CYYynyR0YdRCXEZngJDv9Iiv8B4Zxqrl3+DgPz1roX 1KK1d1rL8Wd0fdRjGUnzeI+Q+74x46YIIX98MFYcodTEzWd5Y0K5zix8FgsmOqQYNUeu QsbA== X-Forwarded-Encrypted: i=1; AJvYcCWHcX910MRF3p3IQIx142Ic+OlxfQ3KV7R6wqZEcXfmng5nsdyIVu7HGr1jmT4BYsmZbilsyrHhyrwpYZvxaC1v7+PzssNz X-Gm-Message-State: AOJu0Yz8ZcvBtWaatTcfU8aZ+DR7+oMzf2SZMAjrbMYa+8SeJC3fucOD C9XLd07vKGzK+bulQzWUP9GLKLDfnfZmaz8oZYXL9ozCG9r3dePz X-Google-Smtp-Source: AGHT+IFil96wxl7AFEXpq/OhBznWcb6U94Zimx6qI1nJZL3/eDpQObCrL1s7ZXi943oAIQ3oBq6JcQ== X-Received: by 2002:a17:902:efd1:b0:1ec:76a6:ea9 with SMTP id ja17-20020a170902efd100b001ec76a60ea9mr1638628plb.26.1714712555147; Thu, 02 May 2024 22:02:35 -0700 (PDT) Received: from localhost ([1.146.23.181]) by smtp.gmail.com with ESMTPSA id i11-20020a17090332cb00b001e9685ad053sm2287720plr.248.2024.05.02.22.02.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 May 2024 22:02:34 -0700 (PDT) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Fri, 03 May 2024 15:02:23 +1000 Message-Id: Cc: "Paolo Bonzini" , "Alexandru Elisei" , "Eric Auger" , "Janosch Frank" , "Claudio Imbrenda" , =?utf-8?q?Nico_B=C3=B6hr?= , "David Hildenbrand" , "Shaoqin Huang" , "Nikos Nikoleris" , "David Woodhouse" , "Ricardo Koller" , "rminmin" , "Gavin Shan" , "Nina Schoetterl-Glausch" , "Sean Christopherson" , , , , Subject: Re: [kvm-unit-tests PATCH v3 0/5] add shellcheck support From: "Nicholas Piggin" To: "Thomas Huth" , "Andrew Jones" X-Mailer: aerc 0.17.0 References: <20240501112938.931452-1-npiggin@gmail.com> <2be99a78-878c-4819-8c42-1b795019af2f@redhat.com> <20240502-d231f770256b3ed812eb4246@orel> <28975cc5-ef8f-4471-baca-0bb792a62084@redhat.com> In-Reply-To: <28975cc5-ef8f-4471-baca-0bb792a62084@redhat.com> On Thu May 2, 2024 at 7:34 PM AEST, Thomas Huth wrote: > On 02/05/2024 10.56, Andrew Jones wrote: > > On Thu, May 02, 2024 at 10:23:22AM GMT, Thomas Huth wrote: > >> On 01/05/2024 13.29, Nicholas Piggin wrote: > >>> This is based on upstream directly now, not ahead of the powerpc > >>> series. > >> > >> Thanks! ... maybe you could also rebase the powerpc series on this now= ? (I > >> haven't forgotten about it, just did not find enough spare time for mo= re > >> reviewing yet) > >> > >>> Since v2: > >>> - Rebased to upstream with some patches merged. > >>> - Just a few comment typos and small issues (e.g., quoting > >>> `make shellcheck` in docs) that people picked up from the > >>> last round. > >> > >> When I now run "make shellcheck", I'm still getting an error: > >> > >> In config.mak line 16: > >> AR=3Dar > >> ^-- SC2209 (warning): Use var=3D$(command) to assign output (or quote = to > >> assign string). > >=20 > > I didn't see this one when testing. I have shellcheck version 0.9.0. > > I'm also using 0.9.0 (from Fedora). Maybe we've got a different default c= onfig? I have 0.10.0 from Debian with no changes to config defaults and no warning. > Anyway, I'm in favor of turning this warning of in the config file, it do= es=20 > not seem to be really helpful in my eyes. What do you think? Maybe it would be useful. I don't mind quoting strings usually, although for this kind of pattern it's a bit pointless and config.mak is also Makefile so that has its own issues. Maybe just disable it for this file? Thanks, Nick