From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2D7223A0 for ; Wed, 11 Sep 2024 00:08:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726013315; cv=none; b=XKPJvUlEz8aFoe+mVlH9tosfP3HAioHsbT1WVSNrFJvu1rlsTL+iBAhoDNYwnykgVsHzy7Hir6Jkdk6YRNs0/HyWQ0wTdmx2WlkM8lQ4GDrLzNMuDozAjIssxFExKbHLKqQNdSKu8joOHR5j/qafvV/VvWasVu3nYVEbaC4ssOs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726013315; c=relaxed/simple; bh=D5+ndBtVapiQkYJsKHG2VeEzF8YWZCa6WToENcX4xGk=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:From:To:Cc: References:In-Reply-To; b=Qx2dAS1KzpJNDqp9AM2bTt0QQcTelmkuAQaBeqaAE1M3WlrJFFNtdeImzIkrg55cq6qcL/rFMxuTsgAQOQf7x/YCk1I6yWTklkSHaCGkl8FZ0jSN4l15thJlUwVDNLjbK8hAIMWhWh07rRbCr5ZYoa0oByiYXLNzBqxZwjE6R2s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T1LqPM+w; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T1LqPM+w" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2053525bd90so53193475ad.0 for ; Tue, 10 Sep 2024 17:08:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726013313; x=1726618113; darn=lists.linux.dev; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GIVoTa7DbVK9Xb7rHJOwqIqIQbFvLn1afRy41hXZ318=; b=T1LqPM+wSJY9muGbKPxmitd5FfnJPQzmXeBoPbjekUh6hbNW6hjRs/p7FqkxdY1RuD TuAMimM3l9A310hkWCqksjEVVLmtu/EwKwkcvtcZJGHj0x/GJArJjVxxUTHdm7pApb8p V4CoOHaE/scpXj5I4VlQZkUOXeFWJ3m50dIcH+oYSqRImbDPbeJmKMyXAtZ1lRyTWYkE lCQCOV9p8JfWuzTC0cD+6SGVmzzzKGYvP0s3dF6Lop9fAtDhBEnLjXDk8iiAA6H6z87t L4G4slSTMjtcihGtW1WaZ/xzMWQkx5eUJVFvyapcHk8mLtB1ngdv5nEiBfipRBNTTahp K/rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726013313; x=1726618113; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=GIVoTa7DbVK9Xb7rHJOwqIqIQbFvLn1afRy41hXZ318=; b=uw0vghlxj3m7OkDKFd0uy1bSkyWwJnl7zyzTsKa1CS1qnn7SbHtYQy0A//8X1jL4Vz 1S9VnosO1wnhiLm0Es+AqrcoVHk68eNI0GFYUJtAfyph1GpWkCZrw4c6dfxZHBMqLANT sVW2qOo1ibVc1j10qqGqce32VPZo6dO00OvVok1uKx22/M3SQRAtyZqNzyjQ31BRoTcs Me64+e022ULq5tBbQ2eYXGcrMyNn7XX8TVGthMg0WOaC2i222eAWcD+/83Pwx9vjCkjc IBmqIHZdOh30Mauw8quNI5UyCpSxP0BYkr54Vib9zL/6Df/gk8cSRwTlioIl9bZ3s3Hb DIOQ== X-Forwarded-Encrypted: i=1; AJvYcCVjwLJC4XPz7D6s5myrHFrQvCfDKiWsMTkVeNKwogY3tZL9lQmyZnqGL+nbgHZDaUg0+/hEeb4=@lists.linux.dev X-Gm-Message-State: AOJu0YzIhZm+XzgcknjoP2PnkzU5eK0PLMXK15modNEnuRKuGB4uu/eg 5g9KrqwzRZ+98z3wo1WkdFzfsCPPH0qCNZIEiAtWeuVL5rHCxys4 X-Google-Smtp-Source: AGHT+IFI8//EbE/gHR4iY1Po7jEcpiXzm01F+imeNjISSHpDyxl/I7se1YOfHzreK/iUzyqJTQp1qg== X-Received: by 2002:a17:903:32c1:b0:206:fd9d:b87f with SMTP id d9443c01a7336-2074c5eb15fmr26527005ad.17.1726013312836; Tue, 10 Sep 2024 17:08:32 -0700 (PDT) Received: from localhost ([1.146.47.52]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20710eea8e3sm53480125ad.174.2024.09.10.17.08.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Sep 2024 17:08:32 -0700 (PDT) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 11 Sep 2024 10:08:23 +1000 Message-Id: Subject: Re: [kvm-unit-tests PATCH v2 1/4] riscv: Drop mstrict-align From: "Nicholas Piggin" To: "Andrew Jones" , , , , , Cc: , , , , , , , , X-Mailer: aerc 0.18.2 References: <20240904105020.1179006-6-andrew.jones@linux.dev> <20240904105020.1179006-7-andrew.jones@linux.dev> In-Reply-To: <20240904105020.1179006-7-andrew.jones@linux.dev> On Wed Sep 4, 2024 at 8:50 PM AEST, Andrew Jones wrote: > The spec says unaligned accesses are supported, so this isn't required > and clang doesn't support it. A platform might have slow unaligned > accesses, but kvm-unit-tests isn't about speed anyway. > > Reviewed-by: Thomas Huth > Signed-off-by: Andrew Jones > --- > riscv/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/riscv/Makefile b/riscv/Makefile > index 179a373dbacf..2ee7c5bb5ad8 100644 > --- a/riscv/Makefile > +++ b/riscv/Makefile > @@ -76,7 +76,7 @@ LDFLAGS +=3D -melf32lriscv > endif > CFLAGS +=3D -DCONFIG_RELOC > CFLAGS +=3D -mcmodel=3Dmedany > -CFLAGS +=3D -mstrict-align > +#CFLAGS +=3D -mstrict-align Just remove the line? Or put a comment there instead to explain. Thanks, Nick