From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F2452E282B for ; Tue, 4 Nov 2025 11:08:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762254508; cv=none; b=oDeVrjO7FSQtUFnCG+Uq+/uOLqWhAhE+3+DgWe/IF3in8Kjs8RBcsWa5hzY9E09In6dx2ofl7ScagzegaWQcNgWXLgrxe1T4RtSFD0YbIROFpkXAffsKySk/VXBQmln4BQHw4Qu96/LQ264AQN434ePb09CfAvLppoPHK2yDPIo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762254508; c=relaxed/simple; bh=hGCmoKsbTJZjLqzPr2g+Pp/EUZnTi1S5B2EwX1vZ0U0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=u7N9QYni5KJa5jJOHWCTwLou6tiYeIF/oZM8YhzptcE9/JstuXgYHwsPGaRphEY8BdYTz2WwbRKN46C+omgcDzR+oxgWkZjybSPAeH+Inz8U0SLf8kxXn/u1NeJ9LNUUX7aGl0Uf3G+aAiXuejeawDHtR6IcXBg9llDr4ih94Mk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=hCoDi+zC; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jackmanb.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hCoDi+zC" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-477563e531cso5001175e9.1 for ; Tue, 04 Nov 2025 03:08:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1762254505; x=1762859305; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=a4cH/AxQtviVkhj7n7m5X/IItvMNFrrOxnPoGxdV9l8=; b=hCoDi+zCBjg5IEKYTw+Pob1lrqfznBH2PxIpIjig3vzwnTObxc2c7nK7NU0ALzSfVG 2lxj5RuTL9EjZGEUJyV8QyxjVfFjwu4FkfdOA5NDGORDQx7lYbwvkAYojYe7f+x44tqo I4QndUOcP0kaKP6OGBXJGBifgMUTKfDEx0mXzioihgCyBffr2OH4h1nhS06pKoju8S36 61BhDgXzPbW0xWh4iV7s6Oouoh/YaqjuBvzEKkCdhowrD0eFAD/VBBljRT6Y83fzjWcd XSwIFeJUkH1Z/pL2OsMhkRuO4C44iPORFatlo7z0rmhuils4G002DkGwzWD1dd1wfEv/ bHFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762254505; x=1762859305; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=a4cH/AxQtviVkhj7n7m5X/IItvMNFrrOxnPoGxdV9l8=; b=RlXPxp3UsEkfwnVna5/lV9kGIMXjM3W3bilBQNituC9cGtmLTniznbUGkJDeYvY6sH Tdd1UQ7GNGLdjaHvKVm0+90kVek5yqnOKRXhgvrzjsR1Rl/v59bV/0y3mWQeRcwBU6sE cDj7/r0KCYjJ1qeHjP6bFLU8RZ5Fr5Q4wewsIq9SkRKkrjnieVYokauxJKw81lgzzWxq x37sqoEWRR3zr4soWzigwzirWz4D/anp9ZqY4cIB3aNtiwjJQ77JKYAzrdCHc95VXNif mU/qP6JD7kUSaFaJtiwSFk2en032Um9HrhnG83mF55H3FWWdkAWo/AiE/pcoZ8exbRxt p4bA== X-Forwarded-Encrypted: i=1; AJvYcCVjcPXKG3tVo+Dp6IzaqiM00rEhcv8/GSRz/4+fmbJT0YpCn2L9cCO2zw0mzIFAICyN+p/nWzk=@lists.linux.dev X-Gm-Message-State: AOJu0YwZOS31IVLxVlK85I+k9KL+F64u3/MvIISINomVrd//VjuYfQM6 MjDaW8gX1Q5ECYCKPTOcHzDbrIK5+xqLYZaHLgavU2UboAKdCiLwAiSr2jZc4VrdzXQWhzUNHEl BDBRM4DC8WHSvJw== X-Google-Smtp-Source: AGHT+IHvMIGMZ3oRYsIKBDomkCS6KVzlMOaVYE+CMhTF6/Om+i57uqifzVXn/OYDK9jNj1kCcP7uTWSdj5qqlA== X-Received: from wmbg22.prod.google.com ([2002:a05:600c:a416:b0:477:14b8:19f6]) (user=jackmanb job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:1549:b0:477:e66:4077 with SMTP id 5b1f17b1804b1-4773089bd5bmr143775885e9.29.1762254504672; Tue, 04 Nov 2025 03:08:24 -0800 (PST) Date: Tue, 04 Nov 2025 11:08:23 +0000 In-Reply-To: Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250924151101.2225820-4-patrick.roy@campus.lmu.de> <20250924152214.7292-1-roypat@amazon.co.uk> <20250924152214.7292-2-roypat@amazon.co.uk> X-Mailer: aerc 0.21.0 Message-ID: Subject: Re: [PATCH v7 05/12] KVM: guest_memfd: Add flag to remove from direct map From: Brendan Jackman To: Mike Rapoport , Brendan Jackman Cc: "Roy, Patrick" , "pbonzini@redhat.com" , "corbet@lwn.net" , "maz@kernel.org" , "oliver.upton@linux.dev" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "luto@kernel.org" , "peterz@infradead.org" , "willy@infradead.org" , "akpm@linux-foundation.org" , "david@redhat.com" , "lorenzo.stoakes@oracle.com" , "Liam.Howlett@oracle.com" , "vbabka@suse.cz" , "surenb@google.com" , "mhocko@suse.com" , "song@kernel.org" , "jolsa@kernel.org" , "ast@kernel.org" , "daniel@iogearbox.net" , "andrii@kernel.org" , "martin.lau@linux.dev" , "eddyz87@gmail.com" , "yonghong.song@linux.dev" , "john.fastabend@gmail.com" , "kpsingh@kernel.org" , "sdf@fomichev.me" , "haoluo@google.com" , "jgg@ziepe.ca" , "jhubbard@nvidia.com" , "peterx@redhat.com" , "jannh@google.com" , "pfalcato@suse.de" , "shuah@kernel.org" , "seanjc@google.com" , "kvm@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.linux.dev" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "bpf@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "Cali, Marco" , "Kalyazin, Nikita" , "Thomson, Jack" , "derekmn@amazon.co.uk" , "tabba@google.com" , "ackerleytng@google.com" Content-Type: text/plain; charset="UTF-8" On Mon Nov 3, 2025 at 10:50 AM UTC, Mike Rapoport wrote: > On Mon, Nov 03, 2025 at 10:35:38AM +0000, Brendan Jackman wrote: >> On Sat Nov 1, 2025 at 9:39 AM UTC, Mike Rapoport wrote: >> > On Fri, Oct 31, 2025 at 05:30:12PM +0000, Brendan Jackman wrote: >> >> On Wed Sep 24, 2025 at 3:22 PM UTC, Patrick Roy wrote: >> >> > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h >> >> > index 1d0585616aa3..73a15cade54a 100644 >> >> > --- a/include/linux/kvm_host.h >> >> > +++ b/include/linux/kvm_host.h >> >> > @@ -731,6 +731,12 @@ static inline bool kvm_arch_has_private_mem(struct kvm *kvm) >> >> > bool kvm_arch_supports_gmem_mmap(struct kvm *kvm); >> >> > #endif >> >> > >> >> > +#ifdef CONFIG_KVM_GUEST_MEMFD >> >> > +#ifndef kvm_arch_gmem_supports_no_direct_map >> >> > +#define kvm_arch_gmem_supports_no_direct_map can_set_direct_map >> >> > +#endif >> >> > +#endif /* CONFIG_KVM_GUEST_MEMFD */ >> >> >> >> The test robot seems happy so I think I'm probably mistaken here, but >> >> AFAICS can_set_direct_map only exists when ARCH_HAS_SET_DIRECT_MAP, >> >> which powerpc doesn't set. >> > >> > We have stubs returning 0 for architectures that don't have >> > ARCH_HAS_SET_DIRECT_MAP. >> >> I can't see any such stub for can_set_direct_map() specifically? > > include/linux/set_memory.h: > > #ifndef CONFIG_ARCH_HAS_SET_DIRECT_MAP > static inline int set_direct_map_invalid_noflush(struct page *page) > { > return 0; > } > static inline int set_direct_map_default_noflush(struct page *page) > { > return 0; > } > > static inline int set_direct_map_valid_noflush(struct page *page, > unsigned nr, bool valid) > { > return 0; > } > > static inline bool kernel_page_present(struct page *page) > { > return true; > } > #else /* CONFIG_ARCH_HAS_SET_DIRECT_MAP */ > /* > * Some architectures, e.g. ARM64 can disable direct map modifications at > * boot time. Let them overrive this query. > */ > #ifndef can_set_direct_map > static inline bool can_set_direct_map(void) > { > return true; > } > #define can_set_direct_map can_set_direct_map But this is for CONFIG_ARCH_HAS_DIRECT_MAP? I am reading this as a stub to fill in for archs that have set_direct_map_*, but don't have runtime disablement like arm64. Whereas my concern is archs that don't have set_direct_map_* at all, i.e. where we need to unconditionally fail GUEST_MEMFG_FLAG_NO_DIRECT_MAP. (Or would we prefer to just not define it at all on those archs? Not sure what the norms are there, I guess that's a question for KVM/arch maintainers).