From: Catalin Marinas <catalin.marinas@arm.com>
To: Mark Brown <broonie@kernel.org>
Cc: Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
Zhang Lei <zhang.lei@jp.fujitsu.com>,
James Morse <james.morse@arm.com>,
Alexandru Elisei <alexandru.elisei@arm.com>,
Andre Przywara <andre.przywara@arm.com>,
kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/8] arm64/fpsimd: Track the saved FPSIMD state type separately to TIF_SVE
Date: Sun, 13 Nov 2022 22:12:12 +0000 [thread overview]
Message-ID: <Y3FrvJQzvW4YFfEF@arm.com> (raw)
In-Reply-To: <20221021230321.1159287-3-broonie@kernel.org>
On Sat, Oct 22, 2022 at 12:03:15AM +0100, Mark Brown wrote:
> diff --git a/arch/arm64/include/asm/processor.h b/arch/arm64/include/asm/processor.h
> index 445aa3af3b76..3cce0a4c4e8d 100644
> --- a/arch/arm64/include/asm/processor.h
> +++ b/arch/arm64/include/asm/processor.h
> @@ -122,6 +122,11 @@ enum vec_type {
> ARM64_VEC_MAX,
> };
>
> +enum fp_type {
> + FP_STATE_FPSIMD,
> + FP_STATE_SVE,
> +};
More of a nitpick, I still find the type/state naming confusing but I
don't have a better suggestion. Maybe call them FP_TYPE_* or rename the
enum to fp_state_type (up to you really, feel free to leave them as they
are).
Either way, I think having an explicit type of what state is about is a
significant improvement in clarity.
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
next prev parent reply other threads:[~2022-11-13 22:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 23:03 [PATCH v4 0/8] arm64/sve: Clean up KVM integration and optimise syscalls Mark Brown
2022-10-21 23:03 ` [PATCH v4 1/8] KVM: arm64: Discard any SVE state when entering KVM guests Mark Brown
2022-11-13 22:00 ` Catalin Marinas
2022-10-21 23:03 ` [PATCH v4 2/8] arm64/fpsimd: Track the saved FPSIMD state type separately to TIF_SVE Mark Brown
2022-11-13 22:12 ` Catalin Marinas [this message]
2022-11-14 11:10 ` Mark Brown
2022-10-21 23:03 ` [PATCH v4 3/8] arm64/fpsimd: Have KVM explicitly say which FP registers to save Mark Brown
2022-11-13 22:27 ` Catalin Marinas
2022-10-21 23:03 ` [PATCH v4 4/8] arm64/fpsimd: Stop using TIF_SVE to manage register saving in KVM Mark Brown
2022-11-13 22:30 ` Catalin Marinas
2022-10-21 23:03 ` [PATCH v4 5/8] arm64/fpsimd: Load FP state based on recorded data type Mark Brown
2022-11-14 9:24 ` Catalin Marinas
2022-10-21 23:03 ` [PATCH v4 6/8] arm64/fpsimd: SME no longer requires SVE register state Mark Brown
2022-11-14 10:18 ` Catalin Marinas
2022-10-21 23:03 ` [PATCH v4 7/8] arm64/sve: Leave SVE enabled on syscall if we don't context switch Mark Brown
2022-11-14 10:31 ` Catalin Marinas
2022-11-14 11:25 ` Mark Brown
2022-10-21 23:03 ` [PATCH v4 8/8] arm64/fp: Use a struct to pass data to fpsimd_bind_state_to_cpu() Mark Brown
2022-11-14 10:33 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3FrvJQzvW4YFfEF@arm.com \
--to=catalin.marinas@arm.com \
--cc=alexandru.elisei@arm.com \
--cc=andre.przywara@arm.com \
--cc=broonie@kernel.org \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=will@kernel.org \
--cc=zhang.lei@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox