From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 258D7259C for ; Mon, 14 Nov 2022 10:33:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36CEDC433D6; Mon, 14 Nov 2022 10:33:38 +0000 (UTC) Date: Mon, 14 Nov 2022 10:33:34 +0000 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , Marc Zyngier , Zhang Lei , James Morse , Alexandru Elisei , Andre Przywara , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v4 8/8] arm64/fp: Use a struct to pass data to fpsimd_bind_state_to_cpu() Message-ID: References: <20221021230321.1159287-1-broonie@kernel.org> <20221021230321.1159287-9-broonie@kernel.org> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221021230321.1159287-9-broonie@kernel.org> On Sat, Oct 22, 2022 at 12:03:21AM +0100, Mark Brown wrote: > For reasons that are unclear to this reader fpsimd_bind_state_to_cpu() > populates the struct fpsimd_last_state_struct that it uses to store the > active floating point state for KVM guests by passing an argument for > each member of the structure. As the richness of the architecture increases > this is resulting in a function with a rather large number of arguments > which isn't ideal. > > Simplify the interface by using the struct directly as the single argument > for the function, renaming it as we lift the definition into the header. > This could be built on further to reduce the work we do adding storage for > new FP state in various places but for now it just simplifies this one > interface. > > Signed-off-by: Mark Brown I think this looks cleaner. Reviewed-by: Catalin Marinas