From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA5DEC433FE for ; Mon, 6 Dec 2021 10:49:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 572C24B0BA; Mon, 6 Dec 2021 05:49:07 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ivobWxOldrnR; Mon, 6 Dec 2021 05:49:06 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2B0CC4B08F; Mon, 6 Dec 2021 05:49:06 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A05B14B08F for ; Mon, 6 Dec 2021 05:49:04 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9TJ93JbnE2f3 for ; Mon, 6 Dec 2021 05:49:03 -0500 (EST) Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 56BCA4B08E for ; Mon, 6 Dec 2021 05:49:03 -0500 (EST) Received: by theia.8bytes.org (Postfix, from userid 1000) id BB60137E; Mon, 6 Dec 2021 11:48:57 +0100 (CET) Date: Mon, 6 Dec 2021 11:48:23 +0100 From: Joerg Roedel To: Eric Auger Subject: Re: [RFC v16 1/9] iommu: Introduce attach/detach_pasid_table API Message-ID: References: <20211027104428.1059740-1-eric.auger@redhat.com> <20211027104428.1059740-2-eric.auger@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211027104428.1059740-2-eric.auger@redhat.com> Cc: kvm@vger.kernel.org, vivek.gautam@arm.com, vdumpa@nvidia.com, kvmarm@lists.cs.columbia.edu, eric.auger.pro@gmail.com, jean-philippe@linaro.org, yi.l.liu@intel.com, ashok.raj@intel.com, maz@kernel.org, vsethi@nvidia.com, nicolinc@nvidia.com, zhangfei.gao@linaro.org, sumitg@nvidia.com, kevin.tian@intel.com, jacob.jun.pan@linux.intel.com, will@kernel.org, nicoleotsuka@gmail.com, alex.williamson@redhat.com, wangxingang5@huawei.com, chenxiang66@hisilicon.com, linux-kernel@vger.kernel.org, lushenming@huawei.com, iommu@lists.linux-foundation.org, robin.murphy@arm.com X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, Oct 27, 2021 at 12:44:20PM +0200, Eric Auger wrote: > Signed-off-by: Jean-Philippe Brucker > Signed-off-by: Liu, Yi L > Signed-off-by: Ashok Raj > Signed-off-by: Jacob Pan > Signed-off-by: Eric Auger This Signed-of-by chain looks dubious, you are the author but the last one in the chain? > +int iommu_uapi_attach_pasid_table(struct iommu_domain *domain, > + void __user *uinfo) > +{ [...] > + if (pasid_table_data.format == IOMMU_PASID_FORMAT_SMMUV3 && > + pasid_table_data.argsz < > + offsetofend(struct iommu_pasid_table_config, vendor_data.smmuv3)) > + return -EINVAL; This check looks like it belongs in driver specific code. Regards, Joerg _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm