From: Quentin Perret <qperret@google.com>
To: Andrew Walbran <qwandor@google.com>
Cc: kernel-team@android.com, Marc Zyngier <maz@kernel.org>,
linux-kernel@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 06/15] KVM: arm64: Implement kvm_pgtable_hyp_unmap() at EL2
Date: Wed, 15 Dec 2021 16:02:03 +0000 [thread overview]
Message-ID: <YboRe+ZRnqtCymHV@google.com> (raw)
In-Reply-To: <CA+_y_2GJk-F8ju0yXsMc2iwd_yFRQGOY1LW2YV-8bZLANwfCHQ@mail.gmail.com>
Hey Andrew,
On Wednesday 08 Dec 2021 at 14:40:54 (+0000), Andrew Walbran wrote:
> Aha, I didn't realise that block mappings, but it makes sense in that
> case. How about adding a note to the function comment here explaining
> that reasoning? Otherwise it sounds like the caller has to handle it
> somehow.
Well in fact the caller does have to handle it if it decided to use
block mappings. We just decided not to use them in pkvm for now for
simplicity, but I guess that might change at some point. The page-table
library is meant to be architecturally compliant (it can create block
mappings or not, ...) but the decision of which mappings to create is
left to the caller and the handling logic belongs there. At least that's
my view of it. So, I actually like the comment the way it is, it
describes clearly what the function does, and what the caller should
expect. I have a bunch of changes for v4 queued locally, so I'll send it
now with that comment left untouched, but please shout if you have an
idea on how to make it better.
Cheers,
Quentin
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2021-12-15 16:02 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 17:03 [PATCH v3 00/15] KVM: arm64: Introduce kvm_share_hyp() Quentin Perret
2021-12-01 17:03 ` [PATCH v3 01/15] KVM: arm64: Check if running in VHE from kvm_host_owns_hyp_mappings() Quentin Perret
2021-12-09 10:10 ` Will Deacon
2021-12-10 13:37 ` Quentin Perret
2021-12-01 17:03 ` [PATCH v3 02/15] KVM: arm64: Provide {get, put}_page() stubs for early hyp allocator Quentin Perret
2021-12-09 10:12 ` [PATCH v3 02/15] KVM: arm64: Provide {get,put}_page() " Will Deacon
2021-12-01 17:03 ` [PATCH v3 03/15] KVM: arm64: Refcount hyp stage-1 pgtable pages Quentin Perret
2021-12-09 10:29 ` Will Deacon
2021-12-10 14:34 ` Quentin Perret
2021-12-13 12:53 ` Will Deacon
2021-12-01 17:03 ` [PATCH v3 04/15] KVM: arm64: Fixup hyp stage-1 refcount Quentin Perret
2021-12-09 11:09 ` Will Deacon
2021-12-01 17:03 ` [PATCH v3 05/15] KVM: arm64: Hook up ->page_count() for hypervisor stage-1 page-table Quentin Perret
2021-12-01 17:04 ` [PATCH v3 06/15] KVM: arm64: Implement kvm_pgtable_hyp_unmap() at EL2 Quentin Perret
2021-12-07 14:47 ` Andrew Walbran
2021-12-08 9:51 ` Quentin Perret
2021-12-08 14:40 ` Andrew Walbran
2021-12-15 16:02 ` Quentin Perret [this message]
2021-12-01 17:04 ` [PATCH v3 07/15] KVM: arm64: Introduce kvm_share_hyp() Quentin Perret
2021-12-09 11:13 ` Will Deacon
2021-12-10 14:37 ` Quentin Perret
2021-12-01 17:04 ` [PATCH v3 08/15] KVM: arm64: pkvm: Refcount the pages shared with EL2 Quentin Perret
2021-12-09 11:16 ` Will Deacon
2021-12-01 17:04 ` [PATCH v3 09/15] KVM: arm64: Extend pkvm_page_state enumeration to handle absent pages Quentin Perret
2021-12-14 14:47 ` Andrew Walbran
2021-12-01 17:04 ` [PATCH v3 10/15] KVM: arm64: Introduce wrappers for host and hyp spin lock accessors Quentin Perret
2021-12-14 14:48 ` Andrew Walbran
2021-12-14 14:52 ` Will Deacon
2021-12-01 17:04 ` [PATCH v3 11/15] KVM: arm64: Implement do_share() helper for sharing memory Quentin Perret
2021-12-10 15:18 ` Andrew Walbran
2021-12-01 17:04 ` [PATCH v3 12/15] KVM: arm64: Implement __pkvm_host_share_hyp() using do_share() Quentin Perret
2021-12-01 17:04 ` [PATCH v3 13/15] KVM: arm64: Implement do_unshare() helper for unsharing memory Quentin Perret
2021-12-10 15:08 ` Andrew Walbran
2021-12-01 17:04 ` [PATCH v3 14/15] KVM: arm64: Expose unshare hypercall to the host Quentin Perret
2021-12-01 17:04 ` [PATCH v3 15/15] KVM: arm64: pkvm: Unshare guest structs during teardown Quentin Perret
2021-12-09 11:22 ` Will Deacon
2021-12-10 14:48 ` Quentin Perret
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YboRe+ZRnqtCymHV@google.com \
--to=qperret@google.com \
--cc=catalin.marinas@arm.com \
--cc=kernel-team@android.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=qwandor@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).