From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7F0DC433F5 for ; Thu, 17 Feb 2022 16:50:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4C4664A534; Thu, 17 Feb 2022 11:50:25 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A5iEuit67VFK; Thu, 17 Feb 2022 11:50:23 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E8F904A100; Thu, 17 Feb 2022 11:50:23 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C3A8549F1D for ; Thu, 17 Feb 2022 11:50:22 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UFKpZJ5ZNZSI for ; Thu, 17 Feb 2022 11:50:21 -0500 (EST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5DB1E49B0C for ; Thu, 17 Feb 2022 11:50:21 -0500 (EST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C63E3113E; Thu, 17 Feb 2022 08:50:20 -0800 (PST) Received: from monolith.localdoman (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 681DD3F70D; Thu, 17 Feb 2022 08:50:19 -0800 (PST) Date: Thu, 17 Feb 2022 16:50:42 +0000 From: Alexandru Elisei To: Sebastian Ene Subject: Re: [PATCH kvmtool v2] aarch64: Add stolen time support Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: maz@kernel.org, will@kernel.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi, On Thu, Feb 17, 2022 at 03:43:15PM +0000, Alexandru Elisei wrote: > Hi, > > Some general comments while I familiarize myself with the stolen time spec. > > On Thu, Feb 17, 2022 at 03:08:53PM +0000, Sebastian Ene wrote: [..] > > > > + /* Populate the vcpu structure. */ > > + vcpu->kvm = kvm; > > + vcpu->cpu_id = cpu_id; > > + vcpu->cpu_type = vcpu_init.target; > > + vcpu->cpu_compatible = target->compatible; > > + vcpu->is_running = true; > > + > > if (err || target->init(vcpu)) > > die("Unable to initialise vcpu"); > > > > @@ -125,13 +132,6 @@ struct kvm_cpu *kvm_cpu__arch_init(struct kvm *kvm, unsigned long cpu_id) > > vcpu->ring = (void *)vcpu->kvm_run + > > (coalesced_offset * PAGE_SIZE); > > > > - /* Populate the vcpu structure. */ > > - vcpu->kvm = kvm; > > - vcpu->cpu_id = cpu_id; > > - vcpu->cpu_type = vcpu_init.target; > > - vcpu->cpu_compatible = target->compatible; > > - vcpu->is_running = true; > > - > > Why this change? Got it know, it's needed for target->init, which is actually arm_cpu__vcpu_init. Weird that it wasn't that way in the first place, but that's because of the awkwardness of generating the fdt nodes for the gic/timer/pmu. Thanks, Alex > > Thanks, > Alex > > > if (kvm_cpu__configure_features(vcpu)) > > die("Unable to configure requested vcpu features"); > > > > -- > > 2.35.1.265.g69c8d7142f-goog > > > _______________________________________________ > kvmarm mailing list > kvmarm@lists.cs.columbia.edu > https://lists.cs.columbia.edu/mailman/listinfo/kvmarm _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm