From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80BCFC433EF for ; Tue, 3 May 2022 23:52:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 05F0849F0F; Tue, 3 May 2022 19:52:30 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@kernel.org Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Tkb1JDiqG+L5; Tue, 3 May 2022 19:52:28 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id E7D2B49EFB; Tue, 3 May 2022 19:52:28 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 3D35D49EFB for ; Tue, 3 May 2022 19:52:27 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gdbPsL2qpDDi for ; Tue, 3 May 2022 19:52:26 -0400 (EDT) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 14D2749EB5 for ; Tue, 3 May 2022 19:52:26 -0400 (EDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B0295617E5; Tue, 3 May 2022 23:52:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A132C385B1; Tue, 3 May 2022 23:52:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651621944; bh=SWm5tsQRoZWKFpiKOc/x2fsplpE56+E6NZ0o7bJAmkg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RdU9Y8o+nSYI2fDTTzPb/0eeyA8P8n2t8XwH/ZL/A2L6LMYHC+lrpim5HoQ8TUboM eLQGxYwWYZUl425X46i71rLAc79vcKmTfV3g2AtY+gHVKbmnwysBYfJSdGitKnTepk EGP0TBaahqrdZ2tG8DmXoADa7177s/1wWGJZLoVMAOHgxGNM1K25aUQ/9orsmnbxVM JfWAE+E+xMU2ZYp+qg+3BlWH3cRDl1KikjaV5QTIgtXBl0sbJrrl8Hewj1kk8AW+FM TQukq0DQKpYUpxkwnPxYyVTsjUM2S+ldxRIrLx7frcs0onjGBPaU6CRxvVaE4zD0jX eCWQ3z+FHNCWQ== Date: Wed, 4 May 2022 00:52:20 +0100 From: Mark Brown To: Qian Cai Subject: Re: [PATCH v14 00/39] arm64/sme: Initial support for the Scalable Matrix Extension Message-ID: References: <20220419112247.711548-1-broonie@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Cookie: libc6 is not essential :| Cc: Marc Zyngier , Basant Kumar Dwivedi , Will Deacon , Luis Machado , Szabolcs Nagy , Catalin Marinas , Alan Hayward , Salil Akerkar , linux-kselftest@vger.kernel.org, Shuah Khan , Shuah Khan , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Luca Salabrino X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4740160721680617318==" Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu --===============4740160721680617318== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Frr2wg0Yl14gtCx1" Content-Disposition: inline --Frr2wg0Yl14gtCx1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 03, 2022 at 06:23:40PM -0400, Qian Cai wrote: > On Tue, Apr 19, 2022 at 12:22:08PM +0100, Mark Brown wrote: > > This series provides initial support for the ARMv9 Scalable Matrix > > Extension (SME). SME takes the approach used for vectors in SVE and > > extends this to provide architectural support for matrix operations. A > > more detailed overview can be found in [1]. >=20 > Set CONFIG_ARM64_SME=3Dn fixed a warning while running libhugetlbfs tests. >=20 > /* > * There are several places where we assume that the order value = is sane > * so bail out early if the request is out of bound. > */ > if (unlikely(order >=3D MAX_ORDER)) { > WARN_ON_ONCE(!(gfp & __GFP_NOWARN)); > return NULL; > } Ugh, right. These variable sized register sets really don't map entirely cleanly onto the ptrace interface but now you point it out what the code has there is going to give a rather larger number than is sensible. Not fully checked but does the below fix things? Thanks for your testing with this stuff, it's been really helpful. diff --git a/arch/arm64/kernel/ptrace.c b/arch/arm64/kernel/ptrace.c index 47d8a7472171..08c1cb43cf33 100644 --- a/arch/arm64/kernel/ptrace.c +++ b/arch/arm64/kernel/ptrace.c @@ -1447,8 +1447,8 @@ static const struct user_regset aarch64_regsets[] =3D= { }, [REGSET_ZA] =3D { /* SME ZA */ .core_note_type =3D NT_ARM_ZA, - .n =3D DIV_ROUND_UP(ZA_PT_ZA_SIZE(SVE_VQ_MAX), SVE_VQ_BYTES), - .size =3D SVE_VQ_BYTES, + .n =3D 1, + .size =3D ZA_PT_SIZE(SVE_VQ_MAX), .align =3D SVE_VQ_BYTES, .regset_get =3D za_get, .set =3D za_set, --Frr2wg0Yl14gtCx1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmJxwDMACgkQJNaLcl1U h9CQsgf/Q4m/iGl8z+mHVPV4t0ivYDXAhsjtBBB7OiPYEhpKxAjxNwbQkSUHmT4u 1Kuv7QBOrp6c+61UQodXcZ3FGTWr/rXqLoRtMEjkVnxxOi4oeeyj65DqsX/WgsH4 yYMtVGGn5ztDOnyX9pYm131Nv0HHObduTAzoSA/SwGFeRhjuuxCiGdoXTnq9foOv 1mflaITdoUCJPHp0gLo3rksyckeMdf6jI0iPs7haJVd8EifLC4/h65P2//YzU8er LF1CX/sOpOjpHnxMt+EyEIjCMj2eSjdjcJvNrfonaYVR4V3V9rRyCExWHiGdhfsq Y7Y/mCO5ndmsxPekSdBnlUf5/ksNDQ== =TMQ4 -----END PGP SIGNATURE----- --Frr2wg0Yl14gtCx1-- --===============4740160721680617318== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm --===============4740160721680617318==--