From: Ricardo Koller <ricarkol@google.com>
To: Andrew Jones <andrew.jones@linux.dev>
Cc: kvm@vger.kernel.org, maz@kernel.org, kvmarm@lists.cs.columbia.edu
Subject: Re: [kvm-unit-tests PATCH v4 0/4] arm: pmu: Fixes for bare metal
Date: Fri, 12 Aug 2022 10:57:10 -0700 [thread overview]
Message-ID: <YvaUdjguLwvXabIF@google.com> (raw)
In-Reply-To: <20220812063300.ygeyivgzzkyzg3uo@kamzik>
On Fri, Aug 12, 2022 at 08:33:00AM +0200, Andrew Jones wrote:
> On Thu, Aug 11, 2022 at 11:52:06AM -0700, Ricardo Koller wrote:
> > There are some tests that fail when running on bare metal (including a
> > passthrough prototype). There are three issues with the tests. The
> > first one is that there are some missing isb()'s between enabling event
> > counting and the actual counting. This wasn't an issue on KVM as
> > trapping on registers served as context synchronization events. The
> > second issue is that some tests assume that registers reset to 0. And
> > finally, the third issue is that overflowing the low counter of a
> > chained event sets the overflow flag in PMVOS and some tests fail by
> > checking for it not being set.
> >
> > Addressed all comments from the previous version:
> > https://lore.kernel.org/kvmarm/YvPsBKGbHHQP+0oS@google.com/T/#mb077998e2eb9fb3e15930b3412fd7ba2fb4103ca
> > - add pmu_reset() for 32-bit arm [Andrew]
> > - collect r-b from Alexandru
>
> You forgot to pick up Oliver's r-b's and his Link suggestion.
Ahh, yes, sorry Oliver.
> I can do that again, though.
Thanks Andrew
>
> Thanks,
> drew
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next prev parent reply other threads:[~2022-08-12 17:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 18:52 [kvm-unit-tests PATCH v4 0/4] arm: pmu: Fixes for bare metal Ricardo Koller
2022-08-11 18:52 ` [kvm-unit-tests PATCH v4 1/4] arm: pmu: Add missing isb()'s after sys register writing Ricardo Koller
2022-08-11 18:52 ` [kvm-unit-tests PATCH v4 2/4] arm: pmu: Add reset_pmu() for 32-bit arm Ricardo Koller
2022-08-11 18:52 ` [kvm-unit-tests PATCH v4 3/4] arm: pmu: Reset the pmu registers before starting some tests Ricardo Koller
2022-08-11 18:52 ` [kvm-unit-tests PATCH v4 4/4] arm: pmu: Check for overflow in the low counter in chained counters tests Ricardo Koller
2022-08-12 6:33 ` [kvm-unit-tests PATCH v4 0/4] arm: pmu: Fixes for bare metal Andrew Jones
2022-08-12 17:57 ` Ricardo Koller [this message]
2022-08-13 8:13 ` Marc Zyngier
2022-10-28 11:40 ` Andrew Jones
2022-10-28 15:01 ` Marc Zyngier
2022-10-28 15:31 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvaUdjguLwvXabIF@google.com \
--to=ricarkol@google.com \
--cc=andrew.jones@linux.dev \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=maz@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox