From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02355625 for ; Tue, 15 Aug 2023 00:52:32 +0000 (UTC) Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-583d1d0de65so65390067b3.0 for ; Mon, 14 Aug 2023 17:52:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692060752; x=1692665552; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=hk15mUEG36mYzoWqdyXNILxXbUGFuZdN5ezEkvLZ3iM=; b=SUKnvazqj9CVjAezsoD2+y+B/lascXFbPfh2BmPWUTPhsp2ltMrajsTckozDu9ifdm uRoTdnCgOM98B7Rnb91Ve9c/MBRF5IHK3nGacQ54NRHNp4jfWACljRlSNeWuoRdL+3na CtHqlJoC59YHPayYcYzVEhCEfMbZsPVJQIkTDsx0J6ehfskI+bg3C/TTqGB4GfV7K9Vn rRDM2yi+re6usECld7Z4U2WK/2ghsl54KPV4Ycl6v1kRxR+u2a297eNSVYm3jPrYQCL2 cXFmXO9Zt4S3exCCMfQ/QP9nNjQaIR5tBPHnG0PDbMprpJdiffEDLgQQkSHFXTPIaHgD 6rOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692060752; x=1692665552; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=hk15mUEG36mYzoWqdyXNILxXbUGFuZdN5ezEkvLZ3iM=; b=bj9xqMS44/LJ9iGhlE0vjSHIVQWMToFERj5q3datLdamPxD6AgGvtHaDZFEGFWyUBH 2WvRIRbaYzChb2KAoSWzBbJ4EgCg1r7RufiJnV5oIVIFbVDrQlSkkWTHGou0OdnRwRdy 888fzLLfNIsUcP4vod9l+INhS72qTHTEeCjzc9m5vROFCj3xtFHXZHs61ME1Xbjaulmv 8AiUT/17uqdtyFZSqnrUyDb+NDCd0a70Z2SPiVoBHyAfsktqj7f3cgdbsihaS1w2yvXv mG9ZSMfXgcw7vB36LAWoy2JFjSlj+v4H0IUBg3osDLyFTUHf01m72R3D8dDMCJ/tZBlH Z9bQ== X-Gm-Message-State: AOJu0Yxcx8y+8vvZlqOZG3087Mji4k3FlyfkOVMypCavX6Ant5tJXK5f TtZLS30+GVQkNx6vuLO4tN1cSBXKWOI= X-Google-Smtp-Source: AGHT+IEm/gyjzby2m0z7Th7h1NzS+zVz9W6iAdmwDKQNzO5UYu/Tw93ovcYoaLNJ0fJilJkbmSYm3tW9J7c= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:7443:0:b0:d20:7752:e384 with SMTP id p64-20020a257443000000b00d207752e384mr148317ybc.3.1692060751838; Mon, 14 Aug 2023 17:52:31 -0700 (PDT) Date: Mon, 14 Aug 2023 17:52:30 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20230811045127.3308641-1-rananta@google.com> Message-ID: Subject: Re: [PATCH v9 00/14] KVM: arm64: Add support for FEAT_TLBIRANGE From: Sean Christopherson To: Raghavendra Rao Ananta Cc: Oliver Upton , Marc Zyngier , James Morse , Suzuki K Poulose , Paolo Bonzini , Huacai Chen , Zenghui Yu , Anup Patel , Atish Patra , Jing Zhang , Reiji Watanabe , Colton Lewis , David Matlack , Fuad Tabba , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Mon, Aug 14, 2023, Raghavendra Rao Ananta wrote: > On Mon, Aug 14, 2023 at 4:16=E2=80=AFPM Sean Christopherson wrote: > > > > On Fri, Aug 11, 2023, Raghavendra Rao Ananta wrote: > > > The series is based off of upstream v6.5-rc1. > > > > Lies! :-) > > > > This is based off one of the kvmarm.git topic branches (I didn't bother= to figure > > out which one), not v6.5-rc1. > > > Sorry, what am I missing here? My git log is as follows: Hmm, not sure what's going on. Maybe I misinterpreted why `git am` was fai= ling? I assumed it was because there were objects in kvmarm that I didn't have lo= cally, and fetching kvmarm allowed am to complete, though with 3-way merges, which= IIUC shouldn't have been necessary if I was using the exact same base. Or maybe= I messed up and didn't actually reset to 6.5-rc1. > $ git log --oneline upstream_tlbi_range_v9 > 5025857507abe (upstream_tlbi_range_v9) KVM: arm64: Use TLBI > range-based instructions for unmap > 5c0291b99a8fc KVM: arm64: Invalidate the table entries upon a range > 8c46b54d4aaec KVM: arm64: Flush only the memslot after write-protect > 231abaeb7ffc2 KVM: arm64: Implement kvm_arch_flush_remote_tlbs_range() > 5ec291b863309 KVM: arm64: Define kvm_tlb_flush_vmid_range() > 5bcd7a085c34e KVM: arm64: Implement __kvm_tlb_flush_vmid_range() > ea08f9dff7e5b arm64: tlb: Implement __flush_s2_tlb_range_op() > b3178687947c9 arm64: tlb: Refactor the core flush algorithm of __flush_tl= b_range > a4850fa988eef KVM: Move kvm_arch_flush_remote_tlbs_memslot() to common co= de > 306dc4e6afd37 KVM: Allow range-based TLB invalidation from common code > d02785a0a1e01 KVM: Remove CONFIG_HAVE_KVM_ARCH_TLB_FLUSH_ALL > 136fa2d254537 KVM: arm64: Use kvm_arch_flush_remote_tlbs() > e35c68a75170d KVM: Declare kvm_arch_flush_remote_tlbs() globally > 5d592777b9bba KVM: Rename kvm_arch_flush_remote_tlb() to > kvm_arch_flush_remote_tlbs() > 06c2afb862f9d (tag: v6.5-rc1, tag: linux/v6.5-rc1) Linux 6.5-rc1 > c192ac7357683 MAINTAINERS 2: Electric Boogaloo > f71f64210d698 Merge tag 'dma-mapping-6.5-2023-07-09' of > git://git.infradead.org/users/hch/dma-mapping > ... >=20 > Isn't the commit, 06c2afb862f9d (06c2afb862f9d (tag: v6.5-rc1, tag: > linux/v6.5-rc1) Linux 6.5-rc1) the 'base' commit? Ya, should be. Either way, even if this is PEBKAC on my end, using --base would be nice, e= .g. then you can definitely say it's my fault ;-) > > Please try to incorporate git format-patch's "--base" option into your = workflow, > > e.g. I do "git format-patch --base=3DHEAD~$nr" where $nr is the number = of patches > > I am posting. > > > > It's not foolproof, e.g. my approach doesn't help if I have a local pat= ch that > > I'm not posting, but 99% of the time it Just Works and eliminates any a= mbuitity. > > > > You can also do "--base=3Dauto", but that only does the right thing if = your series > > has its upstream branch set to the base/tree that you want your patches= applied > > to (I use the upstream branch for a completely different purpose for my= dev branches).