From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-212.mta0.migadu.com (out-212.mta0.migadu.com [91.218.175.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55A3D138E for ; Thu, 21 Sep 2023 02:11:44 +0000 (UTC) Date: Thu, 21 Sep 2023 02:11:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1695262302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FW3p4VZIzuygrjsMUziYPALYuVKWOnunmv01SSe6GfA=; b=IDZSCRSwygs8bsWOJ77HlflG6hYQLi5RwZzud31RDVA2h87NoE+NQKWu9MzZzjbNqLH9+b 4scDyVusgOwT4VG5EsvTvBzKYaveGm4M4S5WNW0B/5kzm8M/Pu8RU68FHwR3vXIn3JlvJk L7nbPllEEafHK3nvi+EHW8iEeF87PG4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Marc Zyngier Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, James Morse , Suzuki K Poulose , Zenghui Yu , Joey Gouly , Shameerali Kolothum Thodi , Xu Zhao , Eric Auger Subject: Re: [PATCH v2 00/11] KVM: arm64: Accelerate lookup of vcpus by MPIDR values (and other fixes) Message-ID: References: <20230920181731.2232453-1-maz@kernel.org> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230920181731.2232453-1-maz@kernel.org> X-Migadu-Flow: FLOW_OUT Heh, "and other fixes" is quite the understatement :) This looks good to me, only issues I've spotted so far are a few typos that are easty enough to fix when I apply the series. I'll give it a couple days for folks to have a look, but otherwise intend on picking this up for 6.7. On Wed, Sep 20, 2023 at 07:17:20PM +0100, Marc Zyngier wrote: > This is a follow-up on [1], which contains the original patches, only > augmented with a bunch of fixes after Zenghui pointed out that I was > inadvertently fixing bugs (yay!), but that there were plenty more. > > The core of the issue is that we tend to confuse vcpu_id with > vcpu_idx. The first is a userspace-provided value, from which we > derive the default MPIDR_EL1 value, while the second is something that > used to represent the position in the vcpu array, and is now more of > an internal identifier. -- Thanks, Oliver