From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11255199BE for ; Mon, 30 Oct 2023 22:07:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="x0D2CKMd" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-1cc1ddb34ccso24871885ad.1 for ; Mon, 30 Oct 2023 15:07:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698703652; x=1699308452; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=EkAABuzKmGyzNibmrxwxoleV2c1qCswFjV4kStA9p5Y=; b=x0D2CKMdVRDjCdVvyLRB1IomNC9NwMSr5OaofYjtbwiOC66AhAp9iaBBftCY8GEYA0 cSgnyj/gfI2rVhcyyzTiIWR5nCNfmNxi1jBReoNzcNpmb6MH1JDeAT3vkwoOwRRQTyqV xR6lcjNqbmx8coNVRspTNHlP47sl+6DFexI6a3QuOa1p1iIQceZgmjjsNYojGTM0lsoP rUoxuvZMg49xnVYGHiDHq/tLUKtC5O595eXY78dRDGOtF5/SJRkp22usrYw93XI+FNcS cxY/d1EA6Bn0Y+uRt8cp5LoQ3bhju+/YrnmfV54BRNCD675Z7/vQVbRcQCaFpZKDCYxP 51sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698703652; x=1699308452; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EkAABuzKmGyzNibmrxwxoleV2c1qCswFjV4kStA9p5Y=; b=REMFtWIMN3HZD2HGn6Vne0gp1oPdnZrJaeJYtoA/RlZb+1EqwfQnxuXujVNqkaKVnK JY2zJy5F2rOsO8D5+rH3JiS92dLhx/7CRwz7JRtbRA4Wts+eawO9GSafsY9hZ9m7gblX yeVAYI5dDDwZU3jCSMtZSCJDFey79k8y1Yz9EiRJiUE3niEy0Dkuda3Mj47bTDu8GBdF OaqfEl/ArVRO6FQBKxgjsI8+B6crNhn1nFVVen79d2ryQtVm9d4TxMMqV5dVRe1Un5KF uau5Y67NBkotv6B4TC1Yi+FeILdMvhLKMS66Me+N6IA3Cpwh2UGW2HCkBes4r85ijiQy Ui8w== X-Gm-Message-State: AOJu0YzEP3l2oELlfpX7RR6qz/27bDIgU8eeLyL3QXVpwzG6EHOkAI0H wt8EW7Fu1L9c8zFtoevonn2vjqpygO8= X-Google-Smtp-Source: AGHT+IHfmttfYISWufdVkZGI1GGv3oPE0CaVU/9uw2yWegmaBLqLOedbYI1/usu4SKmN8TEK3NCdArCTZyE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:902:ed45:b0:1cc:533e:f52b with SMTP id y5-20020a170902ed4500b001cc533ef52bmr49726plb.4.1698703652255; Mon, 30 Oct 2023 15:07:32 -0700 (PDT) Date: Mon, 30 Oct 2023 15:07:30 -0700 In-Reply-To: <077cec97-7920-4d20-8bd3-fe07ab8bcc29@redhat.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-13-seanjc@google.com> <077cec97-7920-4d20-8bd3-fe07ab8bcc29@redhat.com> Message-ID: Subject: Re: [PATCH v13 12/35] KVM: Prepare for handling only shared mappings in mmu_notifier events From: Sean Christopherson To: Paolo Bonzini Cc: Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , "=?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?=" , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="us-ascii" On Mon, Oct 30, 2023, Paolo Bonzini wrote: > On 10/27/23 20:21, Sean Christopherson wrote: > > @@ -635,6 +635,13 @@ static __always_inline kvm_mn_ret_t __kvm_handle_hva_range(struct kvm *kvm, > > * the second or later invocation of the handler). > > */ > > gfn_range.arg = range->arg; > > + > > + /* > > + * HVA-based notifications aren't relevant to private > > + * mappings as they don't have a userspace mapping. > > It's confusing who "they" is. Maybe > > * HVA-based notifications provide a userspace address, > * and as such are only relevant for shared mappings. Works for me.