From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A97E146A75 for ; Fri, 12 Apr 2024 14:54:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712933667; cv=none; b=l07J4oVSeo37Zr+5QramqAm8KXmtiTdOOtn1U235wpm1npIfi31bKpAg3b7LML5XbKkDgODfEaxJ8JaNQdwnLQLAGn6ewvUc9SJizztHBQk/rsqVQ/WPAY0ox+6BBsE0gLR9Zc7F4Uovm+0THg3Y/UB68bOZpCM0FkqI6dri3oI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712933667; c=relaxed/simple; bh=ZtUMxIcPii7SYptK1bsvjnMTv2XY+8o/C+H99TV4mko=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=EiCYEkzwqaT1YYCirNJ9na+NyYRpO9UQ+7dsP6HM+R62x4ZHVm+VYtzysc3KO3pOH6if/8xg8wsFjGEh7YC0KLgWR+/N51itjlrKlawWPQNs2rkw9X0BzmWIZeO+HIur6MUZzFvxWSIn3GE7w4pNo6grdq27712i2AmC0hQSY74= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=mp30zKCu; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="mp30zKCu" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-6ed5a1724b2so681050b3a.1 for ; Fri, 12 Apr 2024 07:54:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712933664; x=1713538464; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ZrmdCrVWtwb7lFW6AyHWbgOgdloa5ymd2fy0iQuLqTo=; b=mp30zKCuOWlA7zV7oWFuyKggXl7KNGlawa+eBechqGUQvE7UtNiKEjS7poIcbb8q9X Z9wb7f3vrGQ9yyZhqmY0gXDxVQamh+QEj2F30gVn9hrVZCwmPlV8jwETWcDstHR7rNwk GJtLnSEyGl6oVl9Kz4KCeAxFPSZT6LeMci25FCV//01KZglP3cjt3twvNAXhW0vuevr1 B98cLi3Ch0D9ajrpijyns42sb1Sgp0H4gsYxvIPRNmMV9yrffWKQE/roG1PlXCKJ2h8N imKtMz+pgzCTjUZcUjLPkdABMW+Bd5zTW5ynodSU1QyYxy+YF0AHlq+5o2YWNXPrmTUy bfWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712933664; x=1713538464; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZrmdCrVWtwb7lFW6AyHWbgOgdloa5ymd2fy0iQuLqTo=; b=xF23+hCgAslKu8FaodgEVpT0lZCJV9y6KFfRAqoXf+gdEhrWKAnrjT9B/eHsAyYY1a 5f2rLsTMTdXDC0SiAvSqsCMTW8M91WcPoKjmf+tdptnS5R1TVsQnTcGMukgPM9yiutKs EB12mobNy+osXEOLsCUqv+UBXhr/2yF5kWp/y3aw6FsgiJuPNZ7579QwD6OZ9K6E0dF4 AZbqKEBnly7OKIX//8J162HhHoLiu0bbj1b/Wcps6NHIljASv0CFwHK+6+P4tDENKtww 0v5F9B5CdURfDAwCwLaKK3+1TbBTwp+O2PO33m624jk16qbcOMDFEAy8xQDgFwkMLInr zEvA== X-Forwarded-Encrypted: i=1; AJvYcCWA+KcPIvhPpEfUpLwFEizxNQRdTRpgZ0bUghqLiFyTGSoiGnmxL082KuVKR6BJ4YW64Lf+7oqRKZB2/FLP24XE+anMS1hT X-Gm-Message-State: AOJu0Yw16FYOZfeciRJB6zfaraCVNnCTiycvZF5KpjWw9itCQhPbMa6I GevMPPgbDqLGOytJBG3fjKR7c2G8udJB153iMPZXpanQYOzaFA2UErbO6mVqEb+35NFk/FZLwOp OHw== X-Google-Smtp-Source: AGHT+IE8CrGE6yHurBu6oRRUdhNStzcxsQMqGws9O1toyt+VIrjo1lbnGIr3E72VqB9zErBllk+K4v4iLAw= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6a00:2d94:b0:6ed:95ce:3417 with SMTP id fb20-20020a056a002d9400b006ed95ce3417mr191844pfb.5.1712933663717; Fri, 12 Apr 2024 07:54:23 -0700 (PDT) Date: Fri, 12 Apr 2024 07:54:22 -0700 In-Reply-To: <86jzl2sovz.wl-maz@kernel.org> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240405115815.3226315-1-pbonzini@redhat.com> <20240405115815.3226315-2-pbonzini@redhat.com> <20240412104408.GA27645@willie-the-truck> <86jzl2sovz.wl-maz@kernel.org> Message-ID: Subject: Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback From: Sean Christopherson To: Marc Zyngier Cc: Will Deacon , Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Oliver Upton , Tianrui Zhao , Bibo Mao , Thomas Bogendoerfer , Nicholas Piggin , Anup Patel , Atish Patra , Andrew Morton , David Hildenbrand , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Fri, Apr 12, 2024, Marc Zyngier wrote: > On Fri, 12 Apr 2024 11:44:09 +0100, Will Deacon wrote: > > On Fri, Apr 05, 2024 at 07:58:12AM -0400, Paolo Bonzini wrote: > > Also, if you're in the business of hacking the MMU notifier code, it > > would be really great to change the .clear_flush_young() callback so > > that the architecture could handle the TLB invalidation. At the moment, > > the core KVM code invalidates the whole VMID courtesy of 'flush_on_ret' > > being set by kvm_handle_hva_range(), whereas we could do a much > > lighter-weight and targetted TLBI in the architecture page-table code > > when we actually update the ptes for small ranges. > > Indeed, and I was looking at this earlier this week as it has a pretty > devastating effect with NV (it blows the shadow S2 for that VMID, with > costly consequences). > > In general, it feels like the TLB invalidation should stay with the > code that deals with the page tables, as it has a pretty good idea of > what needs to be invalidated and how -- specially on architectures > that have a HW-broadcast facility like arm64. Would this be roughly on par with an in-line flush on arm64? The simpler, more straightforward solution would be to let architectures override flush_on_ret, but I would prefer something like the below as x86 can also utilize a range-based flush when running as a nested hypervisor. diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index ff0a20565f90..b65116294efe 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -601,6 +601,7 @@ static __always_inline kvm_mn_ret_t __kvm_handle_hva_range(struct kvm *kvm, struct kvm_gfn_range gfn_range; struct kvm_memory_slot *slot; struct kvm_memslots *slots; + bool need_flush = false; int i, idx; if (WARN_ON_ONCE(range->end <= range->start)) @@ -653,10 +654,22 @@ static __always_inline kvm_mn_ret_t __kvm_handle_hva_range(struct kvm *kvm, break; } r.ret |= range->handler(kvm, &gfn_range); + + /* + * Use a precise gfn-based TLB flush when possible, as + * most mmu_notifier events affect a small-ish range. + * Fall back to a full TLB flush if the gfn-based flush + * fails, and don't bother trying the gfn-based flush + * if a full flush is already pending. + */ + if (range->flush_on_ret && !need_flush && r.ret && + kvm_arch_flush_remote_tlbs_range(kvm, gfn_range.start + gfn_range.end - gfn_range.start + 1)) + need_flush = true; } } - if (range->flush_on_ret && r.ret) + if (need_flush) kvm_flush_remote_tlbs(kvm); if (r.found_memslot)