From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EBA714C5A1 for ; Mon, 5 Aug 2024 23:53:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722901985; cv=none; b=BTo8vPSBVjpVG9Bz+3CdLlqm24cW7aErRNyWtt8vzKdR08r5HNzF9K8zS5SKe9IbAno//QlpB2bHcnXtYw4GxDieb30rMD9zllk9HMf87jVmZdWW1wA1CudL7hQJoP/kOhPyMrTa99AvtBfE/302BtgUaaNOl6I4HSzBrx+v+aA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722901985; c=relaxed/simple; bh=XE64EO9QsKUjNS+RxiZtVEDU63XJXco52ktIOyCusQg=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=pD1Or3ZFxwTugC4i17r+ryDaU6ImGsDAOMvPa/Cgw2Iw1AE7srkTQXg25Qd+MyuqZR489L75b3HoYp4A0CyLZxBpmXprEs9Ah7NU1Br8GBjPPfyrIen28hDcag50Ter3b8f23FTxvRYMQ85Odx020tf7ozhqNg4Vxwr6YNEtGRQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=T2pOljBt; arc=none smtp.client-ip=209.85.128.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="T2pOljBt" Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-664916e5b40so4660237b3.1 for ; Mon, 05 Aug 2024 16:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1722901982; x=1723506782; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=8tNxfozveIy4KhK+t6BTSFuKqZ3CnwWBfLDeoqvVNkU=; b=T2pOljBtwUyz1Oo9FHySrT2DnYTzLDXNeZ8dbCiLQqL9bhcboYvIu4Rr/eAPDwpsgw B2mcAplYIXgYn8NxbW7fTrAJUpgRTjB0je0ZqbJB54jGPCqwAox92o9apSnaurEFBBJV Iizpe6c7DCVzRCw6zLfeEDf1PCexgqF0pTmBOo7mvxE33HE8+VyXis++tyEv2Aih6zV1 CumRcH+4ayx9iUW0z+bD0WMBUkejvMiU0F6yyTpq+RTDz/+rA3yLsaUSUKCvdJ5hrMYo NX9gMHW7AMq48wgXNsnQaB7Y3h1SuOrGo3FaAdTDQD9xr4WVvlX84kqjYY6VWgkkaREx rBfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722901982; x=1723506782; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8tNxfozveIy4KhK+t6BTSFuKqZ3CnwWBfLDeoqvVNkU=; b=uolqfX+m9HbVA9khEPl+tVZQbeOHlQzaBwnGbdUPELgJJJvZjT4MuFXPIpZXWyhmva gk7IwckGYpG8OZl7Nl/Jj1Qkx84O2tZcra2flkiMIZKSWEMwS5hCgmZuQilyQ5KM6nTN IzYGsVRrkbHxSr67qC4yzvbXlapCw+GYJIvK0QEzhgXRBInRPBd4TjphSa+BwhA0u0bh 7RlBPNMqu3rlc1cgIQZoc4sEGd5os4noGcxkm0C5US617dQg74yBh92K7s/1iy1PMW41 RRthumBeLAuoQiEZOMTWtastOFhd14sFBe0fQ0GDMcEWeygTU0BXstaMP4QcQzHfad+t w/iQ== X-Forwarded-Encrypted: i=1; AJvYcCUisoCBidGkDGJO5jxUltxPognJqxbLgUBQRhLaogs857JtJXcJ9hZu7odk7CRYY0jOYrn44kQ+q6xTGwPfZBjAjaB0CMJd X-Gm-Message-State: AOJu0YxNdI5pbltpIaSyOSzV7JzmLC2c9tuqDwT15uxXo7Si3oawrrSt vF1aJywkBrqUnTZ91BIKNEXdt5GWQsVBIfo+YjSvZItfEMrOQIvcBWHlKoZn4aPXWH/wIcrnx3N +Eg== X-Google-Smtp-Source: AGHT+IHjgF0Ca8ethUSfrozdkFUFp0o0AUPtEhLPgrNZWa8lbUZ7qZQp3Z7lR+cNHb6EVM2g/AygpE/k1/Q= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:690c:f16:b0:691:a38c:a61d with SMTP id 00721157ae682-691a39bf26cmr3721507b3.3.1722901982364; Mon, 05 Aug 2024 16:53:02 -0700 (PDT) Date: Mon, 5 Aug 2024 16:53:01 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-55-seanjc@google.com> Message-ID: Subject: Re: [PATCH v12 54/84] KVM: arm64: Mark "struct page" pfns accessed/dirty before dropping mmu_lock From: Sean Christopherson To: Oliver Upton Cc: Paolo Bonzini , Marc Zyngier , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , David Stevens , Fuad Tabba Content-Type: text/plain; charset="us-ascii" On Mon, Aug 05, 2024, Oliver Upton wrote: > > > --- > > > arch/arm64/kvm/mmu.c | 10 ++++++---- > > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > > > index 22ee37360c4e..ce13c3d884d5 100644 > > > --- a/arch/arm64/kvm/mmu.c > > > +++ b/arch/arm64/kvm/mmu.c > > > @@ -1685,15 +1685,17 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, > > > } > > > > > > out_unlock: > > > + if (writable && !ret) > > > + kvm_set_pfn_dirty(pfn); > > > > I'm guessing you meant kvm_release_pfn_dirty() here, because this leaks > > a reference. Doh, I did indeed. Alternatively, this could be: if (writable && !ret) kvm_set_pfn_dirty(pfn); kvm_release_pfn_clean(pfn); It won't matter in the end, because this just becomes: kvm_release_faultin_page(kvm, page, !!ret, writable); So I guess the question is if you prefer to make the switch to an if-else in this path, or more implicitly in the conversion to kvm_release_faultin_page(). I made the same goof for RISC-V, perhaps to prove that I too can copy+paste arm64's MMU code ;-)