From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: andrew.murray@arm.com, christoffer.dall@arm.com,
marc.zyngier@arm.com, catalin.marinas@arm.com,
will.deacon@arm.com, mark.rutland@arm.com
Cc: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v9 2/5] arm64: KVM: encapsulate kvm_cpu_context in kvm_host_data
Date: Thu, 10 Jan 2019 11:36:01 +0000 [thread overview]
Message-ID: <a5ff581b-5cfb-fea2-74b8-aa4dc3403518@arm.com> (raw)
In-Reply-To: <1546872089-56278-3-git-send-email-andrew.murray@arm.com>
Hi Andrew,
On 07/01/2019 14:41, Andrew Murray wrote:
> The virt/arm core allocates a kvm_cpu_context_t percpu, at present this is
> a typedef to kvm_cpu_context and is used to store host cpu context. The
> kvm_cpu_context structure is also used elsewhere to hold vcpu context.
> In order to use the percpu to hold additional future host information we
> encapsulate kvm_cpu_context in a new structure and rename the typedef and
> percpu to match.
>
> Signed-off-by: Andrew Murray <andrew.murray@arm.com>
> ---
> arch/arm/include/asm/kvm_host.h | 8 ++++++--
> arch/arm64/include/asm/kvm_asm.h | 4 ++--
> arch/arm64/include/asm/kvm_host.h | 14 +++++++++-----
> arch/arm64/kernel/asm-offsets.c | 2 +-
> virt/kvm/arm/arm.c | 12 +++++++-----
> 5 files changed, 25 insertions(+), 15 deletions(-)
>
> diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h
> index 79906ce..71645ba 100644
> --- a/arch/arm/include/asm/kvm_host.h
> +++ b/arch/arm/include/asm/kvm_host.h
> @@ -145,7 +145,11 @@ struct kvm_cpu_context {
> u32 cp15[NR_CP15_REGS];
> };
>
> -typedef struct kvm_cpu_context kvm_cpu_context_t;
> +struct kvm_host_data {
> + struct kvm_cpu_context host_ctxt;
> +};
> +
> +typedef struct kvm_host_data kvm_host_data_t;
>
> struct kvm_vcpu_arch {
> struct kvm_cpu_context ctxt;
> @@ -163,7 +167,7 @@ struct kvm_vcpu_arch {
> struct kvm_vcpu_fault_info fault;
>
> /* Host FP context */
> - kvm_cpu_context_t *host_cpu_context;
> + struct kvm_cpu_context *host_cpu_context;
>
> /* VGIC state */
> struct vgic_cpu vgic_cpu;
> diff --git a/arch/arm64/include/asm/kvm_asm.h b/arch/arm64/include/asm/kvm_asm.h
> index 102b5a5..6a9bfd4 100644
> --- a/arch/arm64/include/asm/kvm_asm.h
> +++ b/arch/arm64/include/asm/kvm_asm.h
> @@ -102,12 +102,12 @@ extern u32 __init_stage2_translation(void);
> .endm
>
> .macro get_host_ctxt reg, tmp
> - hyp_adr_this_cpu \reg, kvm_host_cpu_state, \tmp
> + hyp_adr_this_cpu \reg, kvm_host_data, \tmp
> .endm
minor nit: We now load "kvm_host_data" instead of the host_ctxt here,
even though they both are same. Do we need to make this explicitly load
the address of the host_ctxt member to make sure this doesn't break
with future changes to the structure ?
i.e,
add \reg, \reg, #HOST_DATA_CONTEXT
Otherwise,
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
next prev parent reply other threads:[~2019-01-10 11:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 14:41 [PATCH v9 0/5] arm64: Support perf event modifiers :G and :H Andrew Murray
2019-01-07 14:41 ` [PATCH v9 1/5] arm64: arm_pmu: remove unnecessary isb instruction Andrew Murray
2019-01-07 14:41 ` [PATCH v9 2/5] arm64: KVM: encapsulate kvm_cpu_context in kvm_host_data Andrew Murray
2019-01-10 11:36 ` Suzuki K Poulose [this message]
2019-01-10 15:16 ` Andrew Murray
2019-01-14 12:07 ` Suzuki K Poulose
2019-01-07 14:41 ` [PATCH v9 3/5] arm64: KVM: add accessors to track guest/host only counters Andrew Murray
2019-01-07 14:41 ` [PATCH v9 4/5] arm64: arm_pmu: Add support for exclude_host/exclude_guest attributes Andrew Murray
2019-01-07 14:41 ` [PATCH v9 5/5] arm64: KVM: Enable support for :G/:H perf event modifiers Andrew Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5ff581b-5cfb-fea2-74b8-aa4dc3403518@arm.com \
--to=suzuki.poulose@arm.com \
--cc=andrew.murray@arm.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox