From: Marc Zyngier <maz@kernel.org>
To: John Gong <johngong0791@163.com>
Cc: kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH] KVM/ARM: vgic: Delete the redundant lines of code
Date: Mon, 12 Jul 2021 15:16:11 +0100 [thread overview]
Message-ID: <a97545a9e80c6799507a9f9d93817625@kernel.org> (raw)
In-Reply-To: <20210712124933.1153992-1-johngong0791@163.com>
On 2021-07-12 13:49, John Gong wrote:
> delete redundant lines of code
>
> Signed-off-by: John Gong <johngong0791@163.com>
> ---
> arch/arm64/kvm/vgic/vgic-mmio.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/kvm/vgic/vgic-mmio.c
> b/arch/arm64/kvm/vgic/vgic-mmio.c
> index 48c6067fc5ec..19cf661c451e 100644
> --- a/arch/arm64/kvm/vgic/vgic-mmio.c
> +++ b/arch/arm64/kvm/vgic/vgic-mmio.c
> @@ -1004,8 +1004,6 @@ static int dispatch_mmio_read(struct kvm_vcpu
> *vcpu, struct kvm_io_device *dev,
>
> switch (iodev->iodev_type) {
> case IODEV_CPUIF:
> - data = region->read(vcpu, addr, len);
> - break;
> case IODEV_DIST:
> data = region->read(vcpu, addr, len);
> break;
I'm not overly keen on this. Why isn't the write path treated the same
way?
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
prev parent reply other threads:[~2021-07-12 14:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 12:49 [PATCH] KVM/ARM: vgic: Delete the redundant lines of code John Gong
2021-07-12 14:16 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a97545a9e80c6799507a9f9d93817625@kernel.org \
--to=maz@kernel.org \
--cc=johngong0791@163.com \
--cc=kvmarm@lists.cs.columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox