Re: [PATCH v4 1/6] KVM: arm64: Disambiguate support for vSGIs v. vLPIs

[Oliver Upton <oliver.upton@linux.dev>]

On Thu, Jul 10, 2025 at 09:59:14AM +0100, Ben Horgan wrote:
> Hi Oliver,
> 
> On 7/9/25 22:14, Oliver Upton wrote:
> > vgic_supports_direct_msis() is a bit of a misnomer, as it returns true
> > if either vSGIs or vLPIs are supported. Pick it apart into a few
> > predicates and replace some open-coded checks for vSGIs.
> > 
> > Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
> > ---
> >   arch/arm64/kvm/vgic/vgic-init.c    |  4 ++--
> >   arch/arm64/kvm/vgic/vgic-mmio-v3.c | 16 ++++++++++------
> >   arch/arm64/kvm/vgic/vgic-v4.c      |  4 ++--
> >   arch/arm64/kvm/vgic/vgic.c         |  4 ++--
> >   arch/arm64/kvm/vgic/vgic.h         |  7 +++++++
> >   5 files changed, 23 insertions(+), 12 deletions(-)
> > 
> [snip]
> >   		/* Dist stays enabled? nASSGIreq is RO */
> > @@ -133,7 +137,7 @@ static void vgic_mmio_write_v3_misc(struct kvm_vcpu *vcpu,
> >   		if (is_hwsgi != dist->nassgireq)
> >   			vgic_v4_configure_vsgis(vcpu->kvm);
> > -		if (kvm_vgic_global_state.has_gicv4_1 &&
> > +		if (vgic_supports_direct_sgis(vcpu->kvm) &&
> >   		    was_enabled != dist->enabled)
> >   			kvm_make_all_cpus_request(vcpu->kvm, KVM_REQ_RELOAD_GICv4);
> >   		else if (!was_enabled && dist->enabled)
> > @@ -178,7 +182,7 @@ static int vgic_mmio_uaccess_write_v3_misc(struct kvm_vcpu *vcpu,
> >   		}
> >   	case GICD_CTLR:
> >   		/* Not a GICv4.1? No HW SGIs */
> > -		if (!kvm_vgic_global_state.has_gicv4_1)
> > +		if (vgic_supports_direct_sgis(vcpu->kvm))
> Missing negation.

Oops, very well spotted. Thanks Ben!

Thanks,
Oliver