From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02E2E22A4F6 for ; Thu, 8 Jan 2026 20:29:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767904155; cv=none; b=XV+lf6ZTBClvtCWJgvJiqlnpF3iuuIyQA9nPzA9jfF/i7yuMemz7AQhDCsbSFf18NWhVG3d+W7coR3bBq6r6BzMSzv65eAFnD6Ws00f4VBBfPC2ha6S6JRpkDGuyK2radezcucOMkH5//iWnPvNzmtJ/v2fFwqcDOWOkRsfyQZk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767904155; c=relaxed/simple; bh=COjeahyQKq/WjlvRhmJa/k/eFDaGlubJQKHvMo2HvWI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=KC2y4kVnqt4qAiFDAhNUAAxZtaGCg+p2u92/OkJ4Vs7shL/jR+mpYCr98ICghPZgbSw6DjD1LEP8I+p+jPLwFoeRg0agbii/54pAXJ9P2PWUVC2DOA5EQa+NnAawrvJH66OaKdnbPu7XSQ9+eCccs6pAK4r1xm9zizJY3xJuIDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ktxchsgK; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ktxchsgK" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-34c21341f56so7549112a91.2 for ; Thu, 08 Jan 2026 12:29:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1767904151; x=1768508951; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=ncr9wQixKp0DuZvt8wQRxeDUwFvl6Ym9a7uU4tCK5vA=; b=ktxchsgK2yxobDr/nm3vyGJhWqnHzrbx0Ct4LZBsTUxVDLKTICOEZUfINmMZS56YgS kpQIY0m0YBS3HqOFO5y1VEVxAdjs51lbKOFxV2a3UFcluGo6kKz3qnWYueoIpezS1ZNX hvQwPiQ9DzbqelxUD81bXdASGKCSelXqt5wjnw/yeSj7WbKyc/5CzQ1XFob8VWt8n856 5cukd8B1rn2CYy5sp+D+Pa6vCXdYDnk2RH77xA17L3ciIBQhE21wVvtSnsy5Oldgld98 sgRpXm/LH9TXI5dny24wgyZRPEy7lHvuslwoAN24GhhM3dmQThAgTM9uSo6KSr781wdt 7qLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767904151; x=1768508951; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ncr9wQixKp0DuZvt8wQRxeDUwFvl6Ym9a7uU4tCK5vA=; b=Ooz5rFt2HEh2CWyfyTH3RRwYM2W+qA1rwj3woAoc4YKvHb/84v9BwPe1jz9vi6fEoN TBzxF8Byk1Daj9pvj+5+4vm4fg1xjtCcnAfGB5a9HanhOekDHEJJfSrbC9oU4fIJ7ORN xrJDTQ5iUG+9gcv9eVqpz++P5ly/ADbq7xEjvUoxtN3NinF5vK1R/rzJIL8vfWHrKhgR lh/fm7fAghcT4/p9arpCsQoErcSGJfGmFmKp0fbTxM0LyPXHGBCl79N0gfdT/qYZY4zI QQ2ZhUSeAFAcQLatzdfotjHX+XSEfQ7uwK+NaPxsIkNGthHEA9VZTID9sw8RL8Rh3TC1 UyQw== X-Forwarded-Encrypted: i=1; AJvYcCWkbsrCh0iyAzqzJbGdVTNwxv7LjmeOswMjVJxMjL2+5ai1iNm2Cv9GrXQJE8jR65yPDmxrUyg=@lists.linux.dev X-Gm-Message-State: AOJu0YzzeK6iLaQ5oNGLVjG4oyGZgDMNK8J03CAR6gLW4q1LeF6vgQRw m8t9M7Buz4dGVFvAhcoKo6GMxgD7syfh19GRG9r5fKmK/h4sd9wQZ09kz3XE+THFIecbbYLvYf+ eEvSd7g== X-Google-Smtp-Source: AGHT+IESJ6DBGvd9XcEdp+Peyz/5rANQAvVoqUp8W0UHChsh0K8dNusc9fRWmWPXBczuvgljaqvYKeQ4Bc0= X-Received: from pjop14.prod.google.com ([2002:a17:90a:930e:b0:33b:52d6:e13e]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:2647:b0:340:dd2c:a3f5 with SMTP id 98e67ed59e1d1-34f68c30870mr6773023a91.3.1767904151387; Thu, 08 Jan 2026 12:29:11 -0800 (PST) Date: Thu, 8 Jan 2026 12:29:09 -0800 In-Reply-To: <3xrew6ag7pefka7wava4z7ht54e6xlpwbywcm2ivsgnkdbahe4@yqzsaxnhedj7> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20251230230150.4150236-1-seanjc@google.com> <20251230230150.4150236-22-seanjc@google.com> <3xrew6ag7pefka7wava4z7ht54e6xlpwbywcm2ivsgnkdbahe4@yqzsaxnhedj7> Message-ID: Subject: Re: [PATCH v4 21/21] KVM: selftests: Test READ=>WRITE dirty logging behavior for shadow MMU From: Sean Christopherson To: Yosry Ahmed Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Thu, Jan 08, 2026, Yosry Ahmed wrote: > On Thu, Jan 08, 2026 at 10:31:22AM -0800, Sean Christopherson wrote: > > On Thu, Jan 08, 2026, Yosry Ahmed wrote: > > > > /* > > > > - * Add an identity map for GVA range [0xc0000000, 0xc0002000). This > > > > + * Add an identity map for GVA range [0xc0000000, 0xc0004000). This > > > > * affects both L1 and L2. However... > > > > */ > > > > - virt_map(vm, GUEST_TEST_MEM, GUEST_TEST_MEM, TEST_MEM_PAGES); > > > > + virt_map(vm, TEST_MEM_BASE, TEST_MEM_BASE, TEST_MEM_PAGES); > > > > > > > > /* > > > > - * ... pages in the L2 GPA range [0xc0001000, 0xc0003000) will map to > > > > - * 0xc0000000. > > > > + * ... pages in the L2 GPA ranges [0xc0001000, 0xc0002000) and > > > > + * [0xc0003000, 0xc0004000) will map to 0xc0000000 and 0xc0001000 > > > > + * respectively. > > > > > > Are these ranges correct? I thought L2 GPA range [0xc0002000, > > > 0xc0004000) will map to [0xc0000000, 0xc0002000). > > > > Gah, no. I looked at the comments after changing things around, but my eyes had > > glazed over by that point. > > > > > Also, perhaps it's better to express those in terms of the macros? > > > > > > L2 GPA range [TEST_MEM_ALIAS_BASE, TEST_MEM_ALIAS_BASE + 2*PAGE_SIZE) > > > will map to [TEST_MEM_BASE, TEST_MEM_BASE + 2*PAGE_SIZE)? > > > > Hmm, no, at some point we need to concretely state the addresses, so that people > > debugging this know what to expect, i.e. don't have to manually compute the > > addresses from the macros in order to debug. > > I was trying to avoid a situation where the comment gets out of sync > with the macros in a way that gets confusing. Maybe reference both if > it's not too verbose? > > /* > * ... pages in the L2 GPA range [0xc0002000, 0xc0004000) at > * TEST_MEM_ALIAS_BASE will map to [[0xc0000000, 0xc0002000) at > * TEST_MEM_BASE. > */ Heh, your solution to a mitigate a comment getting out of sync is to add more things to the comment that can get out of sync :-D Unless you feel very strongly about having the names of the macros in the comments, I'd prefer to keep just the raw addresses.