Re: [RFC PATCH v6 01/35] arm64/sysreg: Add new SPE fields

Alexandru Elisei
2025-12-12T09:39:49Z

Hi Leo,

On Wed, Dec 10, 2025 at 06:38:27PM +0000, Leo Yan wrote:
> On Fri, Nov 14, 2025 at 04:06:42PM +0000, Alexandru Elisei wrote:
>
> [...]
>
> > Sysreg PMBIDR_EL1 3 0 9 10 7
> > -Res0 63:12
> > +Res0 63:48
> > +Field 47:32 MaxBuffSize
> > +Res0 31:12
> > Enum 11:8 EA
> > 0b0000 NotDescribed
> > 0b0001 Ignored
> > 0b0010 SError
> > EndEnum
> > -Res0 7:6
> > +Enum 7:6 AddrMode
> > + 0b00 VM_ONLY
> > + 0b01 BOTH
> > + 0b10 RESERVED
> > + 0b11 nVM_ONLY
> > +EndEnum
>
> Not sure how to select the enum names, but seems names above don't match
> well to the definitions. How about:
>
> Enum 7:6 AddrMode
> 0b00 VA_ONLY // Virtual address only
> 0b01 VA_PA // Virtual and physical address supported
> 0b10 RESERVED
> 0b11 VM_PA_ONLY // Physical address only in VM

Why not, but I would name the last value PA_ONLY.

Thanks,
Alex