From: Oliver Upton <oupton@kernel.org>
To: Marc Zyngier <maz@kernel.org>
Cc: sashiko-reviews@lists.linux.dev, kvmarm@lists.linux.dev
Subject: Re: [PATCH 3/3] KVM: arm64: vgic: Stop the VM when disabling LPIs
Date: Wed, 23 Sep 2026 11:21:36 -0700 [thread overview]
Message-ID: <arQYsPRcPBlqSR9L@kernel.org> (raw)
In-Reply-To: <86tsnf4zt8.wl-maz@kernel.org>
On Wed, Sep 23, 2026 at 06:56:03PM +0100, Marc Zyngier wrote:
> On Wed, 23 Sep 2026 17:41:53 +0100,
> Oliver Upton <oupton@kernel.org> wrote:
> >
> > No issues with this approach but it is worth noting that all other
> > callers of kvm_arm_halt_guest() do so behind the config_lock today. You
> > could probably do the same with the LPI disable path.
>
> Not quite. The IRQ bypass stuff doesn't know about the lock... But
> maybe we can fix it the same way. I'll investigate.
>
Ah, right, good point.
On second thought, that'd require we hold the config_lock between
->stop() and ->start() on the irqbypass side of things and I'd prefer we
not externalize config_lock and how it ties into the locking hierarchy.
So ignore my feedback, I'm happy with the refcounting implementation.
Thanks,
Oliver
prev parent reply other threads:[~2026-09-23 18:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 21:42 [PATCH 0/3] KVM: arm64: vgic-v3: Make LPI disabling robust Marc Zyngier
2026-09-22 21:42 ` [PATCH 1/3] KVM: arm64: vgic: Allow last_lr_irq to be NULL when LRs are not overflowing Marc Zyngier
2026-09-22 21:42 ` [PATCH 2/3] KVM: arm64: vgic: Take a refcount on IRQs referenced by last_lr_irq Marc Zyngier
2026-09-22 21:42 ` [PATCH 3/3] KVM: arm64: vgic: Stop the VM when disabling LPIs Marc Zyngier
2026-09-22 22:01 ` sashiko-bot
2026-09-22 23:21 ` Marc Zyngier
2026-09-23 16:41 ` Oliver Upton
2026-09-23 17:56 ` Marc Zyngier
2026-09-23 18:21 ` Oliver Upton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arQYsPRcPBlqSR9L@kernel.org \
--to=oupton@kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=maz@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox