From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6131361668 for ; Tue, 25 Aug 2026 06:35:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787639756; cv=none; b=T946SU3qwoJmCG/Y1rFaglNEBtJRqJ8EKIuVjR2CL4wFQMVKCUzSOYai3Egy7oJ1QPHgwQLsWm2nhCOgIXotOnRm/bdzkiVmgdTv4oudpMoPY33AlmUJE9EXPn1sWhW3chqMoJ3ThBZE95y3lcC/c3SYgbAqTtiTz/ETLKKMRdo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787639756; c=relaxed/simple; bh=UsPbBhBedMxMfR6IlID7gClCSRn2+0AwwuT7RAH+urE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Doj2yATXqgRSm//QUo/I8W3JQteCsgYaM+OZoRx5O6PtHkhO0sLmkBl/y6Dc43QyDED2Lqydw+8NqSyfbhHYFtQLz/W3eInL5Rrpakv3cAbvGQ8nkV+phhrk2rYF9DhDgE674haoDcMymFVgO546Z5TRj072kQkyENix0WAEE64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FYTfWjY/; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FYTfWjY/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787639752; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rzmv7Xt4+tmby9i7mh1UPdZNqT5kqdR283MWOsFVSOU=; b=FYTfWjY/DGJa7w7xtJdzab1ZeDr+sqL752AqxgS5rGZtUgE4h4XXIx8syexxDTRBby3rCU BKscO4TQOSgqo9ZU19405ftDWmSrKD/NRkCQc1Qom9Sy/5Hkb48M1A5BQg0tnwj2kzk4li 9v6GimjFApLj7P8smXgiCOv45tmvaU0= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-346-tpidtLBcMZOLADNMcM102w-1; Tue, 25 Aug 2026 02:35:50 -0400 X-MC-Unique: tpidtLBcMZOLADNMcM102w-1 X-Mimecast-MFC-AGG-ID: tpidtLBcMZOLADNMcM102w_1787639750 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-c15cec1ccb6so364759566b.1 for ; Mon, 24 Aug 2026 23:35:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787639749; x=1788244549; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:content-language:subject:reply-to:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rzmv7Xt4+tmby9i7mh1UPdZNqT5kqdR283MWOsFVSOU=; b=RjZ89YtUBPZWxrCPFajpVqJEfXZKvPOEeRazxyhECV09/yxE2AtP/CQ++Kxf5EEjYa GDgSvHkVWtKC48KDiaL0MQQLBh+56g8/kYB5RUGQaFzBTithzUqpj1U4dImGL8EV9RtT cbrP25XrWWf2MiWqSvOCJwwMABWnXMor/8SdE/PVxbF8J7S3zgjbtmTuOae7kGEMueoa OXU85GeDoHiS2XFcY5aq1gI9ayE/ebXXW6q9ta6p7afKVymL3LaE3a+LjcSQyOMG9vYV kGPVtM4ahgqP6nTGRMh6VxaKcwCCgSGhoUCjGvr+wHDrtOAunTdaxIhNWFWK3M5DufUq xnIA== X-Forwarded-Encrypted: i=1; AHgh+Rrfel1Qf84ziL/D3h/qUvshQ0tTc58zRKrRgHzmtvCoXxO02ZHC8fJOo4JRIfqnenxLc9N1xIE=@lists.linux.dev X-Gm-Message-State: AFuF++mJe+1Gb0yGPXjactgBDPaPStOk2Q494ktj8JH9y224WeV9JfeZ RRDg2CSx3guhV6OiIQfYCyawB8KpYQI2CdnC2PtQtl4A4ZKvxOBkBuPO246YJePWtgRgeb5JTW2 R1S17E9xBq2fbqCYh7UqqUS398a026HB5TEk9SlnSS5viS/ldtG44bgGrMw== X-Gm-Gg: AR+sD13j/K526s/F57gpfoY/4OkZYAkjMZNP80QemOcexgAtH4aFxtf08CQHyUgeZmu ipNzNmQz/1CLxQiAVlNrOnLfVBpHV3AhPjh+/OxMJFEH9JXzaYHdtw4zCGIp5WqfBJbSLhkfAL0 LbpPty8+91MPfoPVWwxhJNtOBTFwKtlwwMwYhXoHDfI+TKdAq9Z/saNf53ecOH3gFXYBg3yWHrj DFklOU9DUCqJXAPrAgQ90p8kyqP3Vmh+++WlFpR07Sbec9RhjrSrejADDidarO1ARqOSI/iXbWi Q3lKbijeGaR6s55VmZOcdMB1D8oPZGntbobZXQ75Xumv8WyEr6vTkUJz22NzppnZqxFLT309x3Z 8cPPdp9XQG64v+eMEwUm+YAiX5BSC/RRw5fUjSJEPC+3tvEjs X-Received: by 2002:a17:907:930d:b0:c24:6f60:3f7e with SMTP id a640c23a62f3a-c24e5c8d119mr432331666b.2.1787639749529; Mon, 24 Aug 2026 23:35:49 -0700 (PDT) X-Received: by 2002:a17:907:930d:b0:c24:6f60:3f7e with SMTP id a640c23a62f3a-c24e5c8d119mr432324866b.2.1787639749062; Mon, 24 Aug 2026 23:35:49 -0700 (PDT) Received: from ?IPV6:2a01:e0a:f0e:9070:527b:9dff:feef:3874? ([2a01:e0a:f0e:9070:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c249606a8fasm1764776066b.8.2026.08.24.23.35.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2026 23:35:47 -0700 (PDT) Message-ID: Date: Tue, 25 Aug 2026 08:35:45 +0200 Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: eric.auger@redhat.com Subject: Re: [RFC PATCH v7 00/18] kvm/arm: Introduce a customizable aarch64 KVM host model To: Khushit Shah Cc: "eric.auger.pro@gmail.com" , "qemu-devel@nongnu.org" , "qemu-arm@nongnu.org" , "kvmarm@lists.linux.dev" , "peter.maydell@linaro.org" , Shaju Abraham , "yangjinqian1@huawei.com" , "cohuck@redhat.com" , "richard.henderson@linaro.org" , "sebott@redhat.com" , "skolothumtho@nvidia.com" , "philmd@oss.qualcomm.com" , "maz@kernel.org" , "oliver.upton@linux.dev" , "pbonzini@redhat.com" , "armbru@redhat.com" , "berrange@redhat.com" , "abologna@redhat.com" , "jdenemar@redhat.com" References: <20260726153221.24773-1-eric.auger@redhat.com> <3057A3BC-2BE9-4D2B-9D04-E3B31A6D0599@nutanix.com> <2C1E0EFD-7BD3-4177-90F8-14894B34F726@nutanix.com> From: Eric Auger In-Reply-To: <2C1E0EFD-7BD3-4177-90F8-14894B34F726@nutanix.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: vOaiwSuweetamF4SXIIOEe3B-xq1ce3oocCJ1OQ0RK0_1787639750 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 8/24/26 10:19 AM, Khushit Shah wrote: > >> On 20 Aug 2026, at 11:57 AM, Khushit Shah wrote: >> >> >> >>> On 26 Jul 2026, at 8:59 PM, Eric Auger wrote: >>> >>> !-------------------------------------------------------------------| >>> CAUTION: External Email >>> >>> |-------------------------------------------------------------------! >>> >>> This series enhances the current host KVM model with capability to >>> set writable ID reg fields. >>> >>> Since v6.7 kernel, KVM/arm allows the userspace to overwrite the values >>> of a subset of ID regs. The list of writable fields continues to grow. >>> The feature ID range is defined as the AArch64 System register space >>> with op0==3, op1=={0, 1, 3}, CRn==0, CRm=={0-7}, op2=={0-7}. >>> >>> The end goal is to get more flexibility when migrating guests >>> between different host hardware. >>> >>> QEMU retrieves the writable ID fields from KVM UAPI [1] and >>> match them against a generated description of ID regs and their >>> named fields that stem from AARCHMRS Registers.json file. >>> Current description is based on latest 2026-03 edition. >>> The content of the generated files was compared against kernel >>> linux/arch/arm64/tools/sysreg file. It is not straightforward >>> to have unit tests for python scripts as there are many cases for >>> field extraction. >>> >>> For each writable named field a uint64 property is created >>> following the "SYSREG__" naming convention. REG and >>> FIELD names are those described in ARM ARM Reference manual. >>> >>> The list of SYSREG_ID properties can be retrieved through the qmp >>> monitor using query-cpu-model-expansion [2]. >>> >>> For the record, Jinqian was able to migrate between Hisilicon KunPeng >>> HIP09 and HIP12 chips with this series using this kind of command: >>> >>> -cpu host,pauth=off,pmu=off,sve=off,\ >>> SYSREG_ID_AA64PFR1_EL1_NMI=0x0,\ >>> SYSREG_ID_AA64ISAR1_EL1_LS64=0x0,\ >>> SYSREG_ID_AA64ISAR1_EL1_XS=0x0,\ >>> SYSREG_ID_AA64ISAR1_EL1_LRCPC=0x2,\ >>> SYSREG_ID_AA64ISAR2_EL1_RPRFM=0x0,\ >>> SYSREG_ID_AA64ISAR2_EL1_CLRBHB=0x0,\ >>> SYSREG_ID_AA64ISAR2_EL1_PAC_frac=0x0,\ >>> SYSREG_ID_AA64ISAR2_EL1_BC=0x0,\ >>> SYSREG_ID_AA64ISAR2_EL1_RPRES=0x0,\ >>> SYSREG_ID_AA64ISAR2_EL1_WFxT=0x0,\ >>> SYSREG_ID_AA64MMFR0_EL1_FGT=0x0,\ >>> SYSREG_ID_AA64MMFR0_EL1_BigEnd=0x0,\ >>> SYSREG_ID_AA64MMFR1_EL1_ECBHB=0x0,\ >>> SYSREG_ID_AA64MMFR1_EL1_CMOW=0x0,\ >>> SYSREG_ID_AA64MMFR1_EL1_TIDCP1=0x0,\ >>> SYSREG_ID_AA64MMFR1_EL1_nTLBPA=0x0,\ >>> SYSREG_ID_AA64MMFR1_EL1_AFP=0x0,\ >>> SYSREG_ID_AA64MMFR1_EL1_HCX=0x0,\ >>> SYSREG_ID_AA64MMFR1_EL1_ETS=0x0,\ >>> SYSREG_ID_AA64MMFR1_EL1_PAN=0x2,\ >>> SYSREG_ID_AA64MMFR1_EL1_HAFDBS=0x2,\ >>> SYSREG_ID_AA64MMFR2_EL1_CnP=0x0,\ >>> SYSREG_ID_AA64MMFR3_EL1_TCRX=0x0,\ >>> SYSREG_ID_AA64DFR0_EL1_PMUVer=0x6,\ >>> SYSREG_ID_AA64DFR0_EL1_DebugVer=0x9,\ >>> SYSREG_ID_AA64DFR0_EL1_DoubleLock=0xf,\ >>> SYSREG_ID_AA64ZFR0_EL1_F64MM=0x0,\ >>> SYSREG_ID_AA64ZFR0_EL1_F32MM=0x0,\ >>> SYSREG_ID_AA64ZFR0_EL1_SM4=0x0,\ >>> SYSREG_ID_AA64ZFR0_EL1_SHA3=0x0,\ >>> SYSREG_ID_AA64ZFR0_EL1_BitPerm=0x0,\ >>> SYSREG_ID_AA64ZFR0_EL1_AES=0x0,\ >>> SYSREG_ID_AA64ZFR0_EL1_SVEver=0x0,\ >>> SYSREG_CTR_EL0_L1Ip=0x2 \ >>> >>> Connie & Eric >>> >>> This series can be found at: >>> https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_eauger_qemu_tree_arm-2Dcpu-2Dmodel-2Dv7&d=DwIDAg&c=s883GpUCOChKOHiocYtGcg&r=PGWMyignA0NiDmTlyP7vOTHozBws_VN86yrVmSMkBp0&m=xh5u7-r6auXiWQScafdj-0wW70mXB4FhClh58GryHmExkx8uZN-h9j4B2c90Lowd&s=Ro4v_mjoNaLsznyxm781lzXBcRtXTudjibmgIhoJsNM&e= >>> >>> History: >>> -------- >>> v6 -> v7: >>> - query-cpu-model-expansion now applies the sysreg props >>> onto a scratch vcpu (POC) allowing a finer validation of settings >>> (not perfect though as init may be revisited depending on >>> settings) >>> - Properly handle ValueRange (Khushit) >>> - Remove cpu parameter in get_host_cpu_idregs call chain >>> (Khushit) >>> >>> v5 -> v6: >>> v6 is mostly for Khushit to see how he may work on top >>> of this series. It fulfills some of his requirements: >>> - Upon Khushit request I added description for enum values >>> and reserved fields >>> - set_sysreg_prop checks the input value against enum values >>> if any >>> - writable_bitmap is now dispatched into the sysreg descripton >>> and not stored in vcpu state anymore (besides it is VM wide) >>> - implemented write for qmp inspection. However this is not >>> yet checked against KVM. That's the next step I think, ie. >>> instantiate a scratch vcpu to test if the field value can be >>> applied? >>> - if some inconsistencies between writable mask and idreg >>> field, reserved fields only produce traces >>> - this version does not yet fix some reported issues about host >>> supporting nested virt. I will further sync with Khushit. >>> so this is definitively not candidate to be applied, hence the >>> RFC tag. >>> >>> Cornelia Huck (3): >>> target/arm/kvm: Retrieve writable ID reg map >>> arm/cpu-features: document ID reg properties >>> arm-qmp-cmds: introspection for ID register props >>> >>> Eric Auger (14): >>> scripts: introduce scripts/update-aarch64-cpu-sysregs-header.py >>> target/arm/cpu-sysregs.h.inc: Sort by name alphabetical order >>> target/arm/cpu-sysregs.h.inc: Update with automatic generation >>> arm/cpu: Add infra to handle generated ID register definitions >>> scripts: Introduce scripts/aarch64_sysreg_helpers module >>> scripts: Introduce scripts/update-aarch64-cpu-sysreg-properties.py >>> target/arm/cpu-idregs.h.inc: generate with script >>> target/arm/cpu-idregs.h.inc: Generate enum values >>> arm/kvm: Initialize all writable ID registers from host >>> target/arm/kvm: Introduce kvm_arm_expose_idreg_properties >>> target/arm/cpu: Expose writable ID reg field properties on the kvm >>> host vcpu model >>> target/arm/cpu-idregs.h.inc: Generate reserved fields >>> target/arm/kvm: Ignore and trace unexpected writable reserved fields >>> target/arm/kvm: add utility to write idregs in scratch vcpu >>> >>> Shaju Abraham (1): >>> target/arm/cpu_idregs: generate tables for Arm64 ID registers and >>> fields >>> >>> docs/system/arm/cpu-features.rst | 106 +- >>> target/arm/cpu-idregs.h | 41 + >>> target/arm/kvm_arm.h | 13 + >>> target/arm/cpu-idregs.h.inc | 2164 +++++++++++++++++ >>> target/arm/cpu-sysregs.h.inc | 57 +- >>> target/arm/arm-qmp-cmds.c | 98 + >>> target/arm/cpu-idregs.c | 96 + >>> target/arm/cpu64.c | 5 + >>> target/arm/kvm-stub.c | 6 + >>> target/arm/kvm.c | 360 ++- >>> scripts/aarch64_sysreg_helpers.py | 109 + >>> .../update-aarch64-cpu-sysreg-properties.py | 290 +++ >>> scripts/update-aarch64-cpu-sysregs-header.py | 51 + >>> target/arm/meson.build | 1 + >>> target/arm/trace-events | 8 + >>> 15 files changed, 3373 insertions(+), 32 deletions(-) >>> create mode 100644 target/arm/cpu-idregs.h >>> create mode 100644 target/arm/cpu-idregs.h.inc >>> create mode 100644 target/arm/cpu-idregs.c >>> create mode 100644 scripts/aarch64_sysreg_helpers.py >>> create mode 100644 scripts/update-aarch64-cpu-sysreg-properties.py >>> create mode 100755 scripts/update-aarch64-cpu-sysregs-header.py >>> >>> -- >>> 2.53.0 >>> >> Hi, >> >> On my box the build is failing with: >> [97/2192] Linking target qemu-system-arm >> FAILED: qemu-system-arm >> cc @qemu-system-arm.rsp >> /usr/bin/ld: libsystem_arm.a.p/target_arm_arm-qmp-cmds.c.o: in function `qmp_query_cpu_model_expansion': >> /home/ahv/qemu/build/../target/arm/arm-qmp-cmds.c:144:(.text+0x4d4): undefined reference to `kvm_check_extension' >> /usr/bin/ld: /home/ahv/qemu/build/../target/arm/arm-qmp-cmds.c:145:(.text+0x4e4): undefined reference to `kvm_check_extension' >> /usr/bin/ld: /home/ahv/qemu/build/../target/arm/arm-qmp-cmds.c:151:(.text+0x514): undefined reference to `kvm_check_extension' >> /usr/bin/ld: /home/ahv/qemu/build/../target/arm/arm-qmp-cmds.c:168:(.text+0x554): undefined reference to `kvm_arm_create_scratch_host_vcpu' >> /usr/bin/ld: /home/ahv/qemu/build/../target/arm/arm-qmp-cmds.c:152:(.text+0x7d4): undefined reference to `kvm_check_extension' >> /usr/bin/ld: /home/ahv/qemu/build/../target/arm/arm-qmp-cmds.c:247:(.text+0x8f4): undefined reference to `kvm_arm_destroy_scratch_host_vcpu' >> collect2: error: ld returned 1 exit status > > If I add appropriate stubs, Following test fails: > 30/1079 qemu:qtest+qtest-aarch64 / qtest-aarch64/device-introspect-test ERROR 1.58s killed by signal 6 SIGABRT > 126/1079 qemu:qtest+qtest-aarch64 / qtest-aarch64/qom-test ERROR 46.65s killed by signal 6 SIGABRT > 426/1079 qemu:qtest+qtest-aarch64 / qtest-aarch64/arm-cpu-features ERROR 0.51s killed by signal 6 SIGABRT > 467/1079 qemu:qtest+qtest-arm / qtest-arm/arm-cpu-features ERROR 0.46s killed by signal 6 SIGABRT all the above are fixed now. > 966/1079 qemu:block / io-qcow2-161 ERROR 1.95s exit status 1 this one looks unrelated to this series. I did not encounter it. Thanks Eric >