From: Julien Grall <julien@xen.org>
To: Marc Zyngier <maz@kernel.org>,
james.morse@arm.com, julien.thierry.kdev@gmail.com,
suzuki.poulose@arm.com
Cc: "George.Dunlap@eu.citrix.com" <George.Dunlap@eu.citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org,
Bertrand Marquis <Bertrand.Marquis@arm.com>
Subject: I{S,C}ACTIVER implemention question
Date: Mon, 6 Apr 2020 14:16:39 +0100 [thread overview]
Message-ID: <c90bdfa0-00cf-170b-4319-e270e8aaef7e@xen.org> (raw)
Hi,
Xen community is currently reviewing a new implementation for reading
I{S,C}ACTIVER registers (see [1]).
The implementation is based on vgic_mmio_read_active() in KVM, i.e the
active state of the interrupts is based on the vGIC state stored in memory.
While reviewing the patch on xen-devel, I noticed a potential deadlock
at least with Xen implementation. I know that Xen vGIC and KVM vGIC are
quite different, so I looked at the implementation to see how this is dealt.
With my limited knowledge of KVM, I wasn't able to rule it out. I am
curious to know if I missed anything.
vCPU A may read the active state of an interrupt routed to vCPU B. When
vCPU A is reading the state, it will read the state stored in memory.
The only way the memory state can get synced with the HW state is when
vCPU B exit guest context.
AFAICT, vCPU B will not exit when deactivating HW mapped interrupts and
virtual edge interrupts. So vCPU B may run for an abritrary long time
before been exiting and syncing the memory state with the HW state.
Looking at Linux (5.4 and onwards) use of the active state, vCPU A would
loop until the interrupt is not active anymore. So wouldn't the task on
vCPU A be blocked for an arbitrary long time?
Cheers,
[1]
https://lists.xenproject.org/archives/html/xen-devel/2020-03/msg01844.html
--
Julien Grall
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
next reply other threads:[~2020-04-06 13:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 13:16 Julien Grall [this message]
2020-04-06 15:14 ` I{S,C}ACTIVER implemention question Marc Zyngier
2020-04-10 10:14 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c90bdfa0-00cf-170b-4319-e270e8aaef7e@xen.org \
--to=julien@xen.org \
--cc=Bertrand.Marquis@arm.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=sstabellini@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox