From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFD701A8F97 for ; Wed, 29 Jan 2025 23:06:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738192021; cv=none; b=MwyKNkWuhyBgZrShCfcTH9Gvvvb9+PDhyjhZvFpA9BNNh1hjcmBsefh4h0MIb1Vzw4S6swfS1e16FNxP/EggWY1D5tKoq5RtgiCb2bQ10dQbmXtiIEp8kji+4koz30rM6VjpPTbH8WDChATxLKQaRSHbg1fL/lCZUAvvctsweA8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738192021; c=relaxed/simple; bh=zUh44u3xHyFvSH3tS0Wr7/FzaJHez2vFFdMcDL88fsI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZERbIshjg7FG1XqcEyX5mHN3EhmNTjY27ayJjdx6rapZ0EjCpkPIMn/oOsZrAIBFsCORstk+iB8uQT8FPsTcoR82/6VV5xyd7UsEqSvPejLAmTHudBnBeooAQCJhru66ILlUEPoC/20XUn+4Y6XwagUIKD+Z9bO0VWOYwjlxEn8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=W67kCPEP; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="W67kCPEP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738192018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KyHbZ+Pwxh06r8uU1Lo24oDU5q1mx0zS6wBE1H4R6WI=; b=W67kCPEP/yZdGQkg2Gmrl9fEB9XzKOwBLbXJIhk9Os0f8qMBtek1zkD+XA3iOhMuAILlXy h5sFNKx82O7x8WknJ+ZIrHqIybOeMf/bWPFVfaUdNZITyiXPkFAhrnVPlzBVWZev9OrVq7 wApN7rU+ttxP4aRYg4qNTUcvfbOqfEk= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-588-hL8_aTJCMMCANfy4PfjmeA-1; Wed, 29 Jan 2025 18:06:57 -0500 X-MC-Unique: hL8_aTJCMMCANfy4PfjmeA-1 X-Mimecast-MFC-AGG-ID: hL8_aTJCMMCANfy4PfjmeA Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-2ef728e36d5so252934a91.3 for ; Wed, 29 Jan 2025 15:06:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738192016; x=1738796816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KyHbZ+Pwxh06r8uU1Lo24oDU5q1mx0zS6wBE1H4R6WI=; b=WpLKUFgHA7DBVMekEEKyMm1P+p9kASx1UFIylDb0hLs+GpFQD7GzpsiMKjHdILN8OT 12Rj2VKo5cu1zYliPICBTufWLypQ0LVWu6U/9giwNm7gusQXa71AqjnmixzYlhMNoDP9 ZGig2MIORnf7Hl7EU1QpzV53dmJkhghWsfjQiszhhALWpXUL7UP5m4pboE7hPyvfdzeJ fFttPvpePX5sxkNNUrAMK/aaS/JES3yzi9yjnKghjITviGr3LgraWH6gHgLo9Cld8DIw oLRyh9DGvCUEBLo/DPxIzWYzjMQ6A10m7IP6CTaAC8fZD4dSCeLsyZdfadrDoSf+1AXH GTPg== X-Forwarded-Encrypted: i=1; AJvYcCXDzj4sidxD0ywjQ2aTz995S5Cj6Abr1r0eAb8o0MXp0ajOR7i6QUoUB/OqNS6bTSMgE+AZRvQ=@lists.linux.dev X-Gm-Message-State: AOJu0YwNKlmibHhj2E2zbrGICmv3pUNl3TpvmPxGxLD+t3BJkoo7sY6J 4bd27pb/5Q7uD1929nq5h4uePiRqYcduwodwB0M5X4AHq+om0fddbMtzlYjxQdaVvN1/y29moCP ymh/lq79gOYVsHVDwBneMJbMhpWzimVz4g0J9tiYoA5ZJUa3aqpYnpg== X-Gm-Gg: ASbGncsUr85ohn11LRbUdssv9o6/FLilR81XG4eCaLxgya5kNAEZz19AHSM68jFs32q WVPLsqtopKcIQ2ixQ1AIX1Ly1ukpUd/qHLfqimbOrGQOLd8N9OhUrbMie4MsEsjEIuc8AkrkubE 1i19tZe//Y/YR/bE8v+1hkql1l8Z0Uot6pal+2Dd3x/PXYRwQn7OVZOMJ6NwNEebdGv7TtDL+WI XSuERqug0fH0T2CYVnQOGwrVXW6vAVLPI0W43y2dimBsNaM/8IRnuk37bwtU2AhF6PA4lkX5sV8 a1AoAg== X-Received: by 2002:a05:6a00:1396:b0:725:db34:6a7d with SMTP id d2e1a72fcca58-72fd0c7c6c5mr7442926b3a.23.1738192016160; Wed, 29 Jan 2025 15:06:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IHK+GFtKGuVAzhj66wtlYDvlWWvG3WVubkOllbBq8t3Ltf+GMVUhA51a8pFaMKDNQBYDvAy4Q== X-Received: by 2002:a05:6a00:1396:b0:725:db34:6a7d with SMTP id d2e1a72fcca58-72fd0c7c6c5mr7442904b3a.23.1738192015836; Wed, 29 Jan 2025 15:06:55 -0800 (PST) Received: from [192.168.68.55] ([180.233.125.64]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72fe631bfb0sm30521b3a.23.2025.01.29.15.06.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2025 15:06:55 -0800 (PST) Message-ID: Date: Thu, 30 Jan 2025 09:06:47 +1000 Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 11/43] arm64: RME: RTT tear down To: Steven Price , kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Shanker Donthineni , Alper Gun , "Aneesh Kumar K . V" References: <20241212155610.76522-1-steven.price@arm.com> <20241212155610.76522-12-steven.price@arm.com> From: Gavin Shan In-Reply-To: <20241212155610.76522-12-steven.price@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1jkoIM7GjNsrxCR56C0zYd5kWpP2qIPXfSoU-Jn9PIM_1738192016 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/13/24 1:55 AM, Steven Price wrote: > The RMM owns the stage 2 page tables for a realm, and KVM must request > that the RMM creates/destroys entries as necessary. The physical pages > to store the page tables are delegated to the realm as required, and can > be undelegated when no longer used. > > Creating new RTTs is the easy part, tearing down is a little more > tricky. The result of realm_rtt_destroy() can be used to effectively > walk the tree and destroy the entries (undelegating pages that were > given to the realm). > > Signed-off-by: Steven Price > Reviewed-by: Suzuki K Poulose > --- > Changes since v5: > * Rename some RME_xxx defines to do with page sizes as RMM_xxx - they are > a property of the RMM specification not the RME architecture. > Changes since v2: > * Moved {alloc,free}_delegated_page() and ensure_spare_page() to a > later patch when they are actually used. > * Some simplifications now rmi_xxx() functions allow NULL as an output > parameter. > * Improved comments and code layout. > --- > arch/arm64/include/asm/kvm_rme.h | 19 ++++++ > arch/arm64/kvm/mmu.c | 6 +- > arch/arm64/kvm/rme.c | 112 +++++++++++++++++++++++++++++++ > 3 files changed, 134 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/include/asm/kvm_rme.h b/arch/arm64/include/asm/kvm_rme.h > index 209cd99f03dd..32bdedf1d866 100644 > --- a/arch/arm64/include/asm/kvm_rme.h > +++ b/arch/arm64/include/asm/kvm_rme.h > @@ -71,5 +71,24 @@ u32 kvm_realm_ipa_limit(void); > int kvm_realm_enable_cap(struct kvm *kvm, struct kvm_enable_cap *cap); > int kvm_init_realm_vm(struct kvm *kvm); > void kvm_destroy_realm(struct kvm *kvm); > +void kvm_realm_destroy_rtts(struct kvm *kvm, u32 ia_bits); > + > +#define RMM_RTT_BLOCK_LEVEL 2 > +#define RMM_RTT_MAX_LEVEL 3 > + > +#define RMM_PAGE_SHIFT 12 > +#define RMM_PAGE_SIZE BIT(RMM_PAGE_SHIFT) > +/* See ARM64_HW_PGTABLE_LEVEL_SHIFT() */ > +#define RMM_RTT_LEVEL_SHIFT(l) \ > + ((RMM_PAGE_SHIFT - 3) * (4 - (l)) + 3) > +#define RMM_L2_BLOCK_SIZE BIT(RMM_RTT_LEVEL_SHIFT(2)) > + > +static inline unsigned long rme_rtt_level_mapsize(int level) > +{ > + if (WARN_ON(level > RMM_RTT_MAX_LEVEL)) > + return RMM_PAGE_SIZE; > + > + return (1UL << RMM_RTT_LEVEL_SHIFT(level)); > +} > > #endif All those definitions can be moved to rme.c since they're only used in rme.c Thanks, Gavin